https://bugs.winehq.org/show_bug.cgi?id=48411
Bug ID: 48411 Summary: DDO: Can't login, launcher aborts with "Connection Closed" Product: Wine Version: 5.0-rc2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: sutupud@yahoo.com Distribution: ---
Created attachment 66182 --> https://bugs.winehq.org/attachment.cgi?id=66182 git bisect log
Login works fine on 5.0-rc1 but is broken on 5.0-rc2
Since DDO is from the same company as LOTRO and basically uses the same launcher, this is probably the same as #48388
By bisecting I tracked down the first bad commit to b4a1d80ae35d35f5c170e101922bf1563488be18:
diff --git a/server/sock.c b/server/sock.c index 1a53ce4b09..29542cd01f 100644 --- a/server/sock.c +++ b/server/sock.c @@ -1228,7 +1228,7 @@ DECL_HANDLER(set_socket_event) FILE_WRITE_ATTRIBUTES, &sock_ops))) return; old_event = sock->event; sock->mask = req->mask; - sock->hmask &= ~req->mask; /* re-enable held events */ + sock->hmask &= (FD_WRITE | ~req->mask); /* re-enable held events */ sock->event = NULL; sock->window = req->window; sock->message = req->msg;
https://bugs.winehq.org/show_bug.cgi?id=48411
mata sutupud@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |b4a1d80ae35d35f5c170e101922 | |bf1563488be18
https://bugs.winehq.org/show_bug.cgi?id=48411
mata sutupud@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |x86-64
https://bugs.winehq.org/show_bug.cgi?id=48411
mata sutupud@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=48411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be Summary|DDO: Can't login, launcher |Dungeons and Dragons |aborts with "Connection |Online: Can't login, |Closed" |launcher aborts with | |"Connection Closed"
https://bugs.winehq.org/show_bug.cgi?id=48411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.ddo.com/en Keywords| |download
--- Comment #1 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Added URL and download keyword.
Does reverting the bad commit fix the issue?
Regards.
https://bugs.winehq.org/show_bug.cgi?id=48411
--- Comment #2 from mata sutupud@yahoo.com --- Yes, reverting the commit on top of the current master (5.0-rc4) fixes the problem. Without reverting, it is still present.
https://bugs.winehq.org/show_bug.cgi?id=48411
Alexandr Oleynikov sashok.olen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sashok.olen@gmail.com
--- Comment #3 from Alexandr Oleynikov sashok.olen@gmail.com --- Duplicate of https://bugs.winehq.org/show_bug.cgi?id=48357 Nice to see there's a new and perhaps less complicated test app though.
https://bugs.winehq.org/show_bug.cgi?id=48411
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE
--- Comment #4 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Marking duplicate.
Regards.
*** This bug has been marked as a duplicate of bug 48357 ***
https://bugs.winehq.org/show_bug.cgi?id=48411
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing Duplicate