[Bug 39556] New: Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

Bug ID: 39556
           Summary: Dead code in DIALOG_CreateControls32
           Product: Wine
           Version: 1.7.54
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

DIALOG_CreateControls32 sets hwndDefButton to 0, then checks if
(hwndDefButton), then sets hwndDefButton to hwndCtrl. The code would do the
exact same thing if everything related to hwndDefButton was deleted.

https://source.winehq.org/git/wine.git/blob/cbaab82d086e36dacaa22c6adf80f911...

[Bug 39556] Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

[Bug 39556] Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

--- Comment #1 from Nikolay Sivov  ---
I don't see a problem with that. It runs a loop through all dialog items.

[Bug 39556] Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Fabian Maurer  ---
Don't see a problem either. Should probably be closed.

[Bug 39556] Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #3 from Alex Henrie  ---
I missed the loop. Sorry for the noise.

[Bug 39556] Dead code in DIALOG_CreateControls32

https://bugs.winehq.org/show_bug.cgi?id=39556

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Austin English  ---
Closing.