http://bugs.winehq.org/show_bug.cgi?id=32749
Bug #: 32749 Summary: Implement atl100.dll.AtlAxDialogBoxW to show error dialogs (Visual Studio 2010 (10.0) Express Edition) Product: Wine Version: 1.5.21 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: atl AssignedTo: wine-bugs@winehq.org ReportedBy: focht@gmx.net Classification: Unclassified
Hello folks,
continuation of bug 32564 (Visual Studio 2010 (10.0) Express Edition needs atl100.dll.AtlAxDialogBoxW). Although it's stubbed for now it might be useful to load and show the dialog resource.
--- snip --- 0009:fixme:atl:AtlAxDialogBoxW (0x401f0000 #00cc 0x2008a 0x401b589f 0) --- snip ---
The user doesn't know what happened in this case.
Regards
http://bugs.winehq.org/show_bug.cgi?id=32749
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://go.microsoft.com/?li | |nkid=9709949 Severity|normal |enhancement
http://bugs.winehq.org/show_bug.cgi?id=32749
Sylvain Petreolle spetreolle@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spetreolle@yahoo.fr
https://bugs.winehq.org/show_bug.cgi?id=32749
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fracting@gmail.com
--- Comment #1 from Qian Hong fracting@gmail.com --- Created attachment 48227 --> https://bugs.winehq.org/attachment.cgi?id=48227 Patch: Implement AtlAxDialogBox
Hi Anastasius,
Could you test this patch?
The only difference between AtlAxDialogBox and AtlAxCreateDialog is, one is modal dialog box, the other is modeless dialog box. I reuse the existing code from AtlAxCreateDialog to implement AtlAxDialogBox.
However, msdn says AtlAxDialogBox/AtlAxCreateDialog is able to create a dialog with an ActiveX control, I don't think we've support that, will be great to find some test case.
https://bugs.winehq.org/show_bug.cgi?id=32749
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #48227|0 |1 is patch| |
https://bugs.winehq.org/show_bug.cgi?id=32749
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=32749
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #2 from super_man@post.com --- The patch still applies against git
patching file dlls/atl/atl_ax.c Hunk #1 succeeded at 1360 (offset 44 lines). Hunk #2 succeeded at 1405 with fuzz 2 (offset 44 lines).
Someone just needs to test it.
https://bugs.winehq.org/show_bug.cgi?id=32749
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #3 from super_man@post.com --- patching file dlls/atl/atl_ax.c Hunk #1 succeeded at 1363 (offset 47 lines). Hunk #2 succeeded at 1408 with fuzz 2 (offset 47 lines).
Maybe staging is interested?
Still applies against 1.8.rc3
https://bugs.winehq.org/show_bug.cgi?id=32749
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com Status|NEW |STAGED Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/atl-AtlAxDialogB | |ox
https://bugs.winehq.org/show_bug.cgi?id=32749
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://go.microsoft.com/?li |https://web.archive.org/web |nkid=9709949 |/20111016110147/http://down | |load.microsoft.com/download | |/1/E/5/1E5F1C0A-0D5B-426A-A | |603-1798B951DDAE/VS2010Expr | |ess1.iso
--- Comment #4 from Anastasius Focht focht@gmx.net --- Hello folks,
revisiting, still present.
https://web.archive.org/web/20111016110147/http://download.microsoft.com/dow...
Needs semi-stub or full impl. of JScript_AddTypeLib() -> bug 32562 as prerequisite.
--- quote --- Try to create a new project using project wizard (doesn't matter which type). When you press "OK" to create the project the GUI wizard is shown again and nothing happened. --- quote ---
The Wine-Staging implementation does its job. I've tested different types of errors (invalid characters in project name, valid project name but Wine insufficiencies) and meaningful information is shown in each case. I didn't encounter a case where the dialog template has an ActiveX control embedded.
$ wine --version wine-4.7-99-g590683d369
Regards
https://bugs.winehq.org/show_bug.cgi?id=32749
Andrey andrey.gursky@e-mail.ua changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrey.gursky@e-mail.ua
https://bugs.winehq.org/show_bug.cgi?id=32749
Julian Rüger jr98@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98@gmx.net
https://bugs.winehq.org/show_bug.cgi?id=32749
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |z.figura12@gmail.com Fixed by SHA1| |f987d8ac3b6bf2fb02719616298 | |5477c8daf27d2 Status|STAGED |RESOLVED
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/f987d8ac3b6bf2fb027196162985477c8daf27d2.
https://bugs.winehq.org/show_bug.cgi?id=32749
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.9.
https://bugs.winehq.org/show_bug.cgi?id=32749
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |6.0.x
https://bugs.winehq.org/show_bug.cgi?id=32749
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|6.0.x |---
--- Comment #7 from Michael Stefaniuc mstefani@winehq.org --- Removing the 6.0.x milestone from bug fixes included in 6.0.2.