[Bug 54770] New: missing check of malloc in loader/main.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54770

Bug ID: 54770
           Summary: missing check of malloc in loader/main.c
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: loader
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

we put a fault injection fuzzing on wine,
and find two potential bugs in loader/main.c.
it may miss a malloc check before memcpy

the call stack looks like this:

main ->
        load_ntdll ->
                get_self_exe ->
                        build_path ->
                                memcpy

main ->
        load_ntdll ->
                remove_tail ->
                        memcpy

[Bug 54770] missing check of malloc in loader/main.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54770

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Alexandre Julliard  ---
If malloc fails on startup then nothing will work, there's no need to add
checks for this.

[Bug 54770] missing check of malloc in loader/main.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54770

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Gijs Vermeulen  ---
Closing.