[Bug 17251] New: Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Summary: Torrents renaming each other
           Product: Wine
           Version: 1.1.13
          Platform: PC
               URL: http://www.utorrent.pro/AU/
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Torrents which take on the names of other torrents in the list after being
clicked on just so... Here are the steps:

1. Start with uTorrent showing more than one torrent in a list.
2. Select a torrent in the list.
3. Click once on that selected torrent's NAME FIELD.  The field now becomes
editable.
4. Leave it editable, and select a different torrent by clicking anywhere that
other torrent's row.
5. The one JUST clicked on is now renamed to the same name as the FIRST one I
clicked on.

The link below relates to the forum discussion of the issue.  I have tested the
scenario and reproduced the problem

http://forum.utorrent.com/viewtopic.php?pid=392247

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Diaa Sami  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Diaa Sami   2009-04-14 15:56:28 ---
I can confirm this happening with 1.1.16 also

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Alex Balut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alex Balut   2009-04-24 21:17:47 ---
Also happens with wine-1.1.19

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

nzukca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from nzukca   2009-04-24 21:38:18 ---
Can confirm this happens with Wine-1.1.19 - will retest with 1.1.20 as soon as
package for ubuntu released/installed.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #4 from nzukca   2009-04-25 16:04:48 ---
OK downloaded wine 1.1.20 but problem still remains.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Jeff L  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Jeff L   2009-04-26 20:46:55 ---
Have found the problem in EditLblWndProcT and will submit a patch

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Jeff L  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|ASSIGNED                    |NEW
          Component|-unknown                    |comctl32
            Version|1.1.13                      |1.1.20

--- Comment #6 from Jeff L   2009-04-26 20:54:10 ---
Patch for this is at
http://www.winehq.org/pipermail/wine-patches/2009-April/072330.html

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.20                      |1.1.13

--- Comment #7 from Vitaliy Margolen   2009-04-27 00:03:33 ---
Don't change original reported Wine version.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Wiebe Cazemier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #8 from Alex Balut   2009-05-24 08:42:56 ---
I tried with Wine 1.1.21, the problem still remains.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #9 from Nikolay Sivov   2009-06-01 04:38:57 ---
(In reply to comment #6)
> Patch for this is at
> http://www.winehq.org/pipermail/wine-patches/2009-April/072330.html

This patch is wrong. It blocks changing text when edit is destroyed by focus
loss.
Native saves new text on this case.

I've sent a test to show it, your patch makes it fail on Wine:

http://www.winehq.org/pipermail/wine-patches/2009-June/073598.html

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #10 from Jeff L   2009-06-01 15:57:41 ---
I have tried to run your patch but it fails to create a window.  The statement
hwnd = create_listview_control(LVS_EDITLABELS); creates a window with WS_CHILD
but this seems to be invalid with LVS_EDITLABELS.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #11 from Nikolay Sivov   2009-06-01 16:15:31 ---
(In reply to comment #10)
> I have tried to run your patch but it fails to create a window.  The statement
> hwnd = create_listview_control(LVS_EDITLABELS); creates a window with WS_CHILD
> but this seems to be invalid with LVS_EDITLABELS.

No, it can be used with child controls of course.
Don't follow you, sorry. Where did you try it? On Wine or native (what
version)?
Patch with test is in current git, look at test.winehq.org - it passed on lot
of boxes (and on all Wines too).

BTW, I've already got a patch that accidentally partially fixes this issue:

http://www.winehq.org/pipermail/wine-patches/2009-June/073638.html

Items aren't renamed after that, but items with equal names exist a period of
time when owner resort a list after name change. After sorting no duplicates
exist. So as I said it fixes it partially - more tests needed (I think it's
something ownerdata specific like a sorting on parent side maybe).

Nikolay S.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #12 from Nikolay Sivov   2009-06-02 10:52:11 ---
Check again please, commit:

http://source.winehq.org/git/wine.git/?a=commit;h=43d982fde6b363199c95037935...

changes things a bit.

Comment 11 still applies.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Alex Savin V  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Alex Savin V   2009-07-16 13:25:35 ---
wine-1.1.25 from openSUSE 11.1 WINE repository

bug still exist

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #14 from Eerik   2009-08-11 04:15:41 ---
Still there on wine 1.1.27 and uTorrent 1.8.2

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #15 from Alex Balut   2009-10-08 05:09:21 ---
Still there on wine-1.1.30 and uTorrent 1.8.3 (build 15772)

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #16 from Jeff L   2010-03-12 21:47:17 ---
The problem looks to be that cchTextMax is not set and hence no text is
returned.  Patch is at
http://www.winehq.org/pipermail/wine-patches/2010-March/085693.html.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #17 from Jeff L   2010-03-15 06:56:24 ---
Created an attachment (id=26818)
 --> (http://bugs.winehq.org/attachment.cgi?id=26818)
Extract from a trace before adding code to set cchTextMax

This fragment of the trace shows that there is no text returned from
LISTVIEW_GetItemW.  This leads to bSame being false and edit control text being
used.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #18 from Jeff L   2010-03-15 06:59:50 ---
Created an attachment (id=26820)
 --> (http://bugs.winehq.org/attachment.cgi?id=26820)
Extract from a trace after adding code to set cchTextMax

This fragment shows dispInfo.item.pszText being returned which causes bSame to
be true and avoid the update of the edit control

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #19 from Jeff L   2010-03-15 07:01:15 ---
Created an attachment (id=26821)
 --> (http://bugs.winehq.org/attachment.cgi?id=26821)
Code fragment showing the placement of the TRACE used for the preceeding traces

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Jeff L  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Jeff L   2010-03-17 04:08:00 ---
Patch resolving this is at
http://www.winehq.org/pipermail/wine-patches/2010-March/085794.html

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

--- Comment #21 from Nikolay Sivov   2010-03-17 05:28:47 ---
Fixed by 4f20455e4c467d79a044558816a7cae90552b03e.

[Bug 17251] Torrents renaming each other

http://bugs.winehq.org/show_bug.cgi?id=17251

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Alexandre Julliard   2010-03-19 14:10:24 ---
Closing bugs fixed in 1.1.41.