[Bug 44163] New: Far Cry crashes when opening the save game menu

https://bugs.winehq.org/show_bug.cgi?id=44163

Bug ID: 44163
           Summary: Far Cry crashes when opening the save game menu
           Product: Wine
           Version: 2.22
          Hardware: x86
               URL: http://www.gamershell.com/download_4929.shtml
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 67926ec8c344db4250f1e74a5943d0b8a536e950
      Distribution: ---

Created attachment 59922
  --> https://bugs.winehq.org/attachment.cgi?id=59922
terminal output

Similar to bug #44091 except the crash still occurs in current git
(wine-3.0-rc1-17-g162e6c1e40).
Can be reproduced with the demo version.

The game crashes when I open the save game menu.

To reproduce the problem in the demo:
1. install and launch the demo, in the main menu select <Launch demo>. The game
always performs an autosave once the demo level is loaded.
2. press <ESC> which should bring up the save game menu but the game crashes
here, showing only a blank window titled "Exception". Sorry, but couldn't
produce a backtrace, probably the game's own exception handler is hijacking
winedbg or something.

Reverting the following commit on top of git fixes the crash:

commit 67926ec8c344db4250f1e74a5943d0b8a536e950
Author: Piotr Caban 
Date:   Tue Nov 28 19:48:33 2017 +0100

msvcrt: Set errno when close() is called on already closed fd.

Tested and reproduced with the GOG.com version of the game as well as with the
original demo version.

DemoFarCry.zip (497M)
md5sum: d5f389d6b99c1d69f0491c3e03e50877

wine-3.0-rc1-17-g162e6c1e40

[Bug 44163] Far Cry crashes when opening the save game menu

https://bugs.winehq.org/show_bug.cgi?id=44163

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bernhard Übelacker  ---
Created attachment 59928
  --> https://bugs.winehq.org/attachment.cgi?id=59928
Minimal test case.

It looks like FarCry executes these steps:
- open some file (_wfsopen)
- get fd for this file (_fileno)
- open this file again via the fd (_wfdopen)
- closing second file pointer.
- closing first file pointer - crashes as it thinks the file is already closed.

Attached test program tries to show this.
In wine it crashes like FarCry, on Windows no crash happens.

[Bug 44163] Far Cry crashes when opening the save game menu

https://bugs.winehq.org/show_bug.cgi?id=44163

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8ee96fec2b305fb57a8107c0a65
                   |                            |fc73c58a096d9
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Béla Gyebrószki  ---
Fixed with
https://source.winehq.org/git/wine.git/commit/8ee96fec2b305fb57a8107c0a65fc7...

[Bug 44163] Far Cry crashes when opening the save game menu

https://bugs.winehq.org/show_bug.cgi?id=44163

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 3.0-rc3.