[Bug 16513] New: locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Summary: locomotive like noise effects with Syberia 2
           Product: Wine
           Version: 1.1.10
          Platform: PC
               URL: http://www.4players.de/4players.php/download_start/PC-
                    CDROM/Download/6172.html
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winmm&mci
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

To close bug #12255 for 1.1.6, Dmitry Timoshkov wrote a patch to winmm/mmio.c
that stopped a loud locomotive-like noise that plagued Syberia2 (retail & demo)
between versions 1.1.0 and 1.1.5.
1.1.6 worked perfectly.

Alas, Dmitry's post-1.1.6 patch to the same file
commit d40e003303d4ae2a2239ddfd5ef8b0be61959ac4 
winmm: MMIO_ALLOCBUF is ignored if mmioOpen gets a valid buffer
reintroduced the noise.

Vitaliy Margolen asked that I create a new bug item for this issue, i.e. the
old one be kept closed.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #1 from Jörg Höhle   2008-12-15 07:26:53 ---
Some additional context from bug #12255: I should have repeated here that the
noise is particularly loud in the main menu. The intro plays fine. During game
play, some scenes exhibit a different background noise, not that loud.
If you look at AppDB, other testers have acknowledged these symptoms.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Dmitry Timoshkov   2008-12-16 05:30:11 ---
I have added some tests to see what's broken, and it appears the situation
is worse than I expected. Adding simple mmioSeek() calls to existing tests
lead to memory corruption and a crash. MMIO code needs an overhaul, I'll
have a look once I have a moment.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #3 from Jörg Höhle   2009-09-11 07:38:01 ---
still present in wine-1.1.29

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail]   2009-10-16 16:07:52 ---
Still present in wine-1.1.31.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #5 from Jörg Höhle   2009-11-05 08:57:23 ---
This has my vote for 1.2. It worked in 1.0.1 (not 1.0) and 1.1.6, but has been
broken in 1.1.1-5 and since 1.1.7.
So it fulfills the "no regression since 1.0.1" condition.

IIRC, without that "small but embarrassing"(?) bug, it would get platinum
rating depending on where you got it from:
- the original French packaging is copy-protected by Starforce 3.4.50 and
probably needs a no-cd;
- the German version found on a magazine's DVD is not protected.
- the msvcp60.dll that the installer may or may not install is not essential to
the game (a standard requester appears without it).

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from GyB   2010-04-24 00:43:13 ---
Still present in Wine-1.1.43.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Steven Saric  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |BoomBox-Creations@hotmail.c
                   |                            |om

--- Comment #7 from Steven Saric   2010-07-14 05:49:29 ---
Still present in Wine 1.2-RC7

Anyone have a fix i could try and patch WINE with?

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #8 from GyB  2011-02-20 08:51:11 CST ---
The issue is still present with (vanilla) Wine-1.3.14.

The high quality resampler patches (see bug #14717) fix the sound problem in
Syberia II.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|winmm&mci                   |directx-dsound
         Depends on|                            |14717

--- Comment #9 from Jörg Höhle  2011-02-27 11:53:00 CST ---
This is incredible! Béla, thank you very much for finding this out!
We were all convinced that MMIO is the cause that nobody suspected dsound.
The effect is not present with native dsound (neither in the main menu nor in
the Youkol village), changing component.
The effect is not present with the resampler from bug #14717, adding
dependency.

IMHO, the resampler is a another example about how replacing code that's been
bug fixed many times over the years with new design and code that has solid
scientific roots has the potential to vastly inprove the quality of software.

FWIW, in the Youkol village, native dsound and the new resampler still produce
different low-level background sound.  However I can't say which one is more
correct or if there are foreign noises.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Alexander E. Patrakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Alexander E. Patrakov  2011-02-27 14:10:21 CST ---
I slightly object to adding a dependency on #14717, because the dependency is
not on "fixing the resampler in any possible way", but on "fixing the resampler
with this patch". Yes, it is a useful data point, but it is not known if the
patch will be accepted. I am currently prepare a less-intrusive, better
bisectable patch for #16513, that, however, will most likely not resolve
#16513.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Stefan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14717                       |9612

--- Comment #11 from Jörg Höhle  2011-03-21 00:32:50 CDT ---
Removing the dependency on bug #14717 as it turns out that setting
MaxShadowSize=0 in HKCU\Software\Wine\DirectSound
is another work-around (tested with wine-1.3.15).

Known work-arounds so far:
 - Set "MaxShadowSize"="0" in Wine's registry.
 - Use the resampler from bug #14717, comment #129, as its current design
   embeds what amounts to MaxShadowSize=0 in Wine's original dsound
   (GyB, this registry setting is ignored by the resampler).
 - Use native dsound.dll, or
 - Use wine-1.1.6 OOTB

These days winetricks contains a "dsoundbug9612" switch to set MaxShadowSize. 
That IMHO does not make the present bug a duplicate of bug #9612 as the
symptoms are truly different but I'm adding it as a dependency to link both.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #12 from Alexander E. Patrakov  2011-03-21 07:27:37 CDT ---
Thanks for the useful feedback on the resampler patch (i.e. confirmation that
it ignores MaxShadowSize).

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |d40e003303d4ae2a2239ddfd5ef
                   |                            |8b0be61959ac4

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

sacrediou  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #13 from GyB  2011-12-11 10:08:27 CST ---
Still present as of wine-1.3.34-202-gb0f704d and also affects the following
games:

- Jack the Ripper (another adventure game from the same developer/publisher as
Syberia 2)
- Ballance demo (a small puzzle game):
http://games.softpedia.com/get/Games-Demo/Ballance-Demo.shtml

The resampler patchset in bug #14717 fixes the audio problem in all these
games.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #14 from Alexander E. Patrakov  2011-12-11 11:09:21 CST ---
Please tell if the first patch ("always resample in mixer") is enough to get
rid of the locomotive noise. The other patches are not ready yet (the blocker
is the CPU usage) and I know I won't have time until January to improve them.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #15 from GyB  2011-12-11 11:32:53 CST ---
(In reply to comment #14)
> Please tell if the first patch ("always resample in mixer") is enough to get
> rid of the locomotive noise. The other patches are not ready yet (the blocker
> is the CPU usage) and I know I won't have time until January to improve them.

The first patch is enough to get rid of the noise in those games.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #16 from Alexander E. Patrakov  2011-12-11 12:09:23 CST ---
So you need to convince Andrew Eikum to apply it separately as an important
bugfix that fixes the root cause of bug 9612. Andrew told me over IM that it
causes regressions, but, unfortunately, didn't record concrete examples in the
bug log. IMHO the patch is good anyway, because it trades a fundamental design
flaw for fixable bugs (if any).

And the followup patches from bug 14717 won't fix any regressions introduced by
the first patch, so his position ("apply the first patch only as a part of the
whole series, because of the regressions it causes") is understandable only is
he is willing to accept the regressions together with improved sound quality.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.0

--- Comment #17 from Jörg Höhle  2011-12-12 08:33:26 CST ---
Sound bug => 1.4 milestone.  IIRC this one also was a 1.2 milestone.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

--- Comment #18 from GyB  2011-12-29 12:42:29 CST ---
Commit 663bc476029a3f867c698677f888d778246f4718
fixed the loud noise in Syberia 2 and in Jack the Ripper for me.

wine-1.3.35-273-geaa8801

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |663bc476029a3f867c698677f88
                   |                            |8d778246f4718
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Austin English  2011-12-29 15:23:24 CST ---
(In reply to comment #18)
> Commit 663bc476029a3f867c698677f888d778246f4718
> fixed the loud noise in Syberia 2 and in Jack the Ripper for me.
>
> wine-1.3.35-273-geaa8801

Fixed.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard  2011-12-30 12:57:02 CST ---
Closing bugs fixed in 1.3.36.

[Bug 16513] locomotive like noise effects with Syberia 2

http://bugs.winehq.org/show_bug.cgi?id=16513

Bug 16513 depends on bug 9612, which changed state.

Bug 9612 Summary: Silent Hunter III: Crashes on loading a savegame at sea (dsound causing out of memory condition)
http://bugs.winehq.org/show_bug.cgi?id=9612

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED