[Bug 53915] New: Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

Bug ID: 53915
           Summary: Pivot animator runs into assert
           Product: Wine
           Version: 7.20
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: d2d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 73468
  --> https://bugs.winehq.org/attachment.cgi?id=73468
Tail of the log

Download at
https://web.archive.org/web/20221113193258/https://dd21m32yacj0k.cloudfront....

Original download would be at https://www.pivotanimator.net/DownloadV5.php, but
this downloads a stub which is currently broken (bug 53914).

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20221113193258/https://dd2
                   |                            |1m32yacj0k.cloudfront.net/c
                   |                            |urrent/de/v8.979.012.00.4

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

--- Comment #1 from Nikolay Sivov  ---
This looks like an application bug:

---
0024:trace:d2d:d2d_factory_CreateDrawingStateBlock iface 036F1B50, desc
00000000, text_rendering_params 00000000, state_block 11BE6AB8.
0024:trace:d2d:d2d_factory_AddRef 036F1B50 increasing refcount to 182.
0024:trace:d2d:d2d_factory_CreateDrawingStateBlock Created state block
0BCB3D30.
0024:trace:d2d:d2d_device_context_SaveDrawingState iface 0BCB34B0, state_block
11BE6AB8.
---

Instead of passing interface pointer to SaveDrawingState(), it's passing same
out pointer.

Removing assertion helps.

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

--- Comment #2 from Nikolay Sivov  ---
Created attachment 73473
  --> https://bugs.winehq.org/attachment.cgi?id=73473
patch

This works for me.

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |798d659f04250757ee18b009619
                   |                            |f08d45e99b395

--- Comment #3 from Nikolay Sivov  ---
Fixed with 798d659f04250757ee18b009619f08d45e99b395. Still, there are glitches,
likely related to missing support for layers.

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

--- Comment #4 from Nikolay Sivov  ---
Another fix got in, a50dbd6c15f5d55cf47ca9900d7ad3c8788f9648. That's something
I spotted in the logs.

[Bug 53915] Pivot animator runs into assert

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53915

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 7.22.