http://bugs.winehq.org/show_bug.cgi?id=21087
Summary: Civilization 2 crashes during installation Product: Wine Version: 1.1.35 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: wylda@volny.cz
Created an attachment (id=25292) --> (http://bugs.winehq.org/attachment.cgi?id=25292) console log
I wanted to retest bug 20806, but discovered that Civilization 2 is not installable due to bug 21069. Check-out one commit before bug 21069 shows, that all files are installed, but then unfinished installation crashes.
1. This bug report is about crash instead asking about "Creating set of icons in Program Manager group".
2. Did a regression test between 1.1.34 and commit before bug 21069:
51770cdbbc7cc8efa59aa62f8d5f503616540e4f is first bad commit commit 51770cdbbc7cc8efa59aa62f8d5f503616540e4f Author: Alexandre Julliard julliard@winehq.org Date: Fri Dec 11 20:25:18 2009 +0100
user32: Split the handling of the 16-bit messages out of the combo winproc.
:040000 040000 8242fc1217286389685f95476a1b7a0326b963f4 f4df1ed5924aa9fee6b3351d09497e6ac983d98f M dlls
3. No other bug report suffers from this commit.
4. Revert of this patch after git checkout makes that problem goes away.
5. Adding author of this patch to CC.
--private keyword: bisected
http://bugs.winehq.org/show_bug.cgi?id=21087
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=21087
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, win16
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #1 from Alexandre Julliard julliard@winehq.org 2009-12-20 03:13:04 --- Created an attachment (id=25300) --> (http://bugs.winehq.org/attachment.cgi?id=25300) Fix combo strings check
Does this help?
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #2 from Wylda wylda@volny.cz 2009-12-20 04:38:39 --- Created an attachment (id=25302) --> (http://bugs.winehq.org/attachment.cgi?id=25302) civ2 install - patched
(In reply to comment #1)
Created an attachment (id=25300)
--> (http://bugs.winehq.org/attachment.cgi?id=25300) [details]
Does this help?
Well... It is a bit better, but does not reach quality of 1.1.34. See attachement. (or another regression??)
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #3 from Alexandre Julliard julliard@winehq.org 2009-12-20 05:29:49 --- Please attach a +message trace.
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #4 from Wylda wylda@volny.cz 2009-12-20 06:03:24 --- Created an attachment (id=25303) --> (http://bugs.winehq.org/attachment.cgi?id=25303) console log with +message trace
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2009-12-20 07:46:58 --- Do you see the same problem with 1.1.34 + offending commit + my patch? Or is this problem caused by another commit?
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #6 from Wylda wylda@volny.cz 2009-12-20 08:00:12 --- (In reply to comment #5)
Do you see the same problem with 1.1.34 + offending commit + my patch? Or is this problem caused by another commit?
Unfortunately your patch is not aplicable right after offending commit:
git checkout 51770cdbbc7cc8efa59aa62f8d5f503616540e4f patch -p1 <civ2a.patch patching file dlls/user32/msg16.c Hunk #1 FAILED at 2103. 1 out of 1 hunk FAILED -- saving rejects to file dlls/user32/msg16.c.rej
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2009-12-20 11:45:55 --- Yes that code is still in combo.c, just make the corresponding change in there.
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #8 from Wylda wylda@volny.cz 2009-12-20 12:17:09 --- (In reply to comment #7)
Yes that code is still in combo.c, just make the corresponding change in there.
Thanks for letting me know! So the situation is following:
git checkout 51770cdbbc7cc8efa59aa62f8d5f503616540e4f <--crashes
git checkout 51770cdbbc7cc8efa59aa62f8d5f503616540e4f + patched combo.c <-- does not crash, but there is missing text in textbox (see attachement in comment #2)
git checkout 51770cdbbc7cc8efa59aa62f8d5f503616540e4f; git show \ 51770cdbbc7cc8efa59aa62f8d5f503616540e4f | patch -p1 -R <--does not crash and shows text textbox (as in wine 1.1.34 - see attachement in comment #2)
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #9 from Wylda wylda@volny.cz 2009-12-22 05:19:08 ---
Can't retest under current git. Blocked by bug 21069.
http://bugs.winehq.org/show_bug.cgi?id=21087
--- Comment #10 from Wylda wylda@volny.cz 2009-12-22 12:49:22 ---
Wine-1.1.35-105-gd4a7a9d finally behaves like wine-1.1.34, i.e. FIXED.
http://bugs.winehq.org/show_bug.cgi?id=21087
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #11 from Wylda wylda@volny.cz 2009-12-22 12:50:04 ---
"You have to specify a comment when changing the status of a bug from UNCONFIRMED to RESOLVED."
http://bugs.winehq.org/show_bug.cgi?id=21087
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
--- Comment #12 from Jeff Zaroyko jeffz@jeffz.name 2010-01-09 04:44:27 --- Closing bugs fixed in 1.1.36.
http://bugs.winehq.org/show_bug.cgi?id=21087
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2010-01-22 11:02:25 --- Closing bugs fixed in 1.1.37.
http://bugs.winehq.org/show_bug.cgi?id=21087
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |51770cdbbc7cc8efa59aa62f8d5 | |f503616540e4f
-
wine-bugs＠winehq.org