[Bug 36116] New: msi/action possible leak in test_create_remove_shortcut

https://bugs.winehq.org/show_bug.cgi?id=36116

Bug ID: 36116
           Summary: msi/action possible leak in
                    test_create_remove_shortcut
           Product: Wine
           Version: 1.7.17
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]

==20424== 48 bytes in 1 blocks are possibly lost in loss record 485 of 1,049
==20424==    at 0x7BC4C735: notify_alloc (heap.c:255)
==20424==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==20424==    by 0x5069418: msi_alloc (msipriv.h:1188)
==20424==    by 0x506AE0C: get_table (table.c:601)
==20424==    by 0x506F48C: TABLE_CreateView (table.c:2161)
==20424==    by 0x5075B7D: WHERE_CreateView (where.c:1242)
==20424==    by 0x50797E1: sql_parse (sql.y:494)
==20424==    by 0x507A959: MSI_ParseSQL (sql.y:1002)
==20424==    by 0x5044749: MSI_DatabaseOpenViewW (msiquery.c:132)
==20424==    by 0x4FEC6FC: load_all_files (action.c:1300)
==20424==    by 0x4FED0F6: ACTION_CostInitialize (action.c:1544)
==20424==    by 0x4FFDEFD: ACTION_HandleStandardAction (action.c:7619)
==20424==    by 0x4FFE0F1: ACTION_PerformAction (action.c:7648)
==20424==    by 0x4FEA821: ITERATE_Actions (action.c:507)
==20424==    by 0x50448B6: MSI_IterateRecords (msiquery.c:188)
==20424==    by 0x4FEABBF: ACTION_ProcessExecSequence (action.c:590)
==20424==    by 0x4FFE945: MSI_InstallPackage (action.c:7840)
==20424==    by 0x50386E7: MsiInstallProductW (msi.c:251)
==20424==    by 0x50385D8: MsiInstallProductA (msi.c:226)
==20424==    by 0x4C3C622: test_create_remove_shortcut (action.c:5746)
==20424==

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from joaopa  ---
Created attachment 67722
  --> https://bugs.winehq.org/attachment.cgi?id=67722
console output with valgrind --trace-children=yes --leak-check=full
--show-leak-kinds=all

Looks like this bug is fixed in wine-5.12
Can an administrator close this bug as FIXED?

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Austin English  ---
Yeah, I'm not seeing this either now.

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Zebediah Figura  ---
Are we sure this is fixed? Valgrind support for heap tracking is currently
broken...

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from Austin English  ---
(In reply to Zebediah Figura from comment #3)
> Are we sure this is fixed? Valgrind support for heap tracking is currently
> broken...

Good point, wasn't aware of that, thanks. With wine-5.11-227-gaec1968788, which
is a few commits before
https://source.winehq.org/git/wine.git/commitdiff/8a169390c9ef4d8a43b604558c...,
the bug is still present.

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36116] msi/action possible leak in test_create_remove_shortcut

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36116

David Kahurani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from David Kahurani  ---
I'd have expected that the memory would balloon(As seen via system tools like
System Monitor ?!?! ), if there was indeed some leaking but this doesn't seem
to be the case after setting the suspected code to run in a massive loop.