[Bug 57163] New: Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Bug ID: 57163
           Summary: Wine Mono support msi no longer installs
           Product: Wine
           Version: 9.16
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Running "make dev-setup" in a wine-mono build tree now fails in the msiexec
step:

wine msiexec /i 'Z:\home\meh\wine-mono\image\support\winemono-support.msi'
015c:fixme:file:NtLockFile I/O completion on lock not implemented yet
make: *** [GNUmakefile:81: dev-setup] Error 123

Bisecting pointed to this commit:
14b718b69bb8d62c3ae84c52d4210e81c1d21208 is the first bad commit
commit 14b718b69bb8d62c3ae84c52d4210e81c1d21208
Author: Hans Leidekker 
Date:   Thu Aug 29 14:44:38 2024 +0200

msiexec: Don't remove quotes from properties passed on the command line.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57024

programs/msiexec/msiexec.c | 43 +++++++++++++++++++++++++++++++++----------
 1 file changed, 33 insertions(+), 10 deletions(-)

But I think the bisect is wrong. When running with a +msiexec,+msi log, it
shows the correct filename passed to MsiInstallProductW:
015c:trace:msi:MsiInstallProductW
L"Z:\home\meh\wine-mono\image\support\winemono-support.msi" (null)

But later the filename is wrong:
015c:warn:msi:MSI_OpenPackageW unable to copy package
L"Z:\home\meh\wine-mono\image\support\winemono-support.msi\0010\0006\0001uZ:\home\meh\wine-mono\image\support\winemono-support.msi"
to L"C:\windows\Installer\989.msi" (123)

Adding warn+heap to the channels causes it to succeed.

So I think what we really have is some sort of memory error in msi that the
change to msiexec happened to trigger with a different allocation pattern.

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression,
                   |                            |source

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

--- Comment #1 from Hans Leidekker  ---
I can't reproduce this.

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

--- Comment #2 from Esme Povirk  ---
I posted a merge request for this:
https://gitlab.winehq.org/wine/wine/-/merge_requests/6464

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

--- Comment #3 from Esme Povirk  ---
AFAICT this bug won't affect shared installs (as they use MsiInstallProductW
for the support msi directly), but it could affect the custom action used by
the Wine Mono runtime msi to install the support msi.

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

--- Comment #4 from Rafał Mużyło  ---
On a semi-random and not really relevant note: this reminded me of the old bug
48174 - I haven't looked at it in a long while and have no idea of its current
status, but...(it would be really hilarious if that problem had this type of
solution, though given the codebase to check, chances of finding it would be
slim)

[Bug 57163] Wine Mono support msi no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |35369ea38f35dba5ba0e4bd552d
                   |                            |24ad95a2f92a6
             Status|NEW                         |RESOLVED
    Regression SHA1|                            |14b718b69bb8d62c3ae84c52d42
                   |                            |10e81c1d21208

--- Comment #5 from Esme Povirk  ---
MR merged, it's working again for me.

[Bug 57163] msiexec sometimes fails with unquoted filenames

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wine Mono support msi no    |msiexec sometimes fails
                   |longer installs             |with unquoted filenames

[Bug 57163] msiexec sometimes fails with unquoted filenames

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57163

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 9.18.