[Bug 46560] New: Smoke not rendering properly in Castlevania: Lords of Shadow 2

https://bugs.winehq.org/show_bug.cgi?id=46560

Bug ID: 46560
           Summary: Smoke not rendering properly in Castlevania: Lords of
                    Shadow 2
           Product: Wine
           Version: 4.0
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 63432
  --> https://bugs.winehq.org/attachment.cgi?id=63432
screenshot

There were a couple of reports about a regression with
8fa5f1d8c6e2c0e0bb408de0b341b946984825c1 which is also causes this issue.
Probably it's just a trigger to another bug.

err:d3d:wined3d_debug_callback 0x1aa9d8: "GL_INVALID_OPERATION error generated.
Invalid VAO/VBO/pointer usage.".

wine-4.0-276-g84459ba94b

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

https://bugs.winehq.org/show_bug.cgi?id=46560

--- Comment #1 from Józef Kucia  ---
(In reply to Andrey Gusev from comment #0)
> err:d3d:wined3d_debug_callback 0x1aa9d8: "GL_INVALID_OPERATION error
> generated. Invalid VAO/VBO/pointer usage.".

It seems to happen because the vertex buffer is mapped and
wined3d_buffer_load() fails. In consequence, we emit a draw call with system
memory pointer.

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

https://bugs.winehq.org/show_bug.cgi?id=46560

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46560

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |df509be8c6d581b2e68ea79c282
                   |                            |289dd8840b11a

--- Comment #2 from Andrey Gusev  ---
Fixed by
https://source.winehq.org/git/wine.git/commit/df509be8c6d581b2e68ea79c282289...

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46560

--- Comment #3 from Andrey Gusev  ---
Forgot to mention that no any visible issues now, just these lines:

fixme:d3d:wined3d_buffer_load Buffer is mapped through buffer object, not
loading.
err:d3d:wined3d_debug_callback 0x1c2b968: "GL_INVALID_OPERATION error
generated. Failed to map memory for buffer.".

wine-4.17-226-g6a976801b1

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46560

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 4.18.

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46560

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 46560] Smoke not rendering properly in Castlevania: Lords of Shadow 2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46560

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.4.