[Bug 14674] New: Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Summary: Wine WordPad fails to correctly open CP1251 RTF
                    documents with russian letter "ya"
           Product: Wine
           Version: unspecified
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15132)
 --> (http://bugs.winehq.org/attachment.cgi?id=15132)
A screenshot, demonstrating the problem

If an RTF document is encoded in Windows CP1251 and contains Russian letter
"ya" ("я"), it will be truncated by Wine Wordpad at the position of that
character's first occurence.
OpenOffice.org opens the same documents without truncating.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

--- Comment #1 from Roman Mamedov   2008-07-28 01:19:39 ---
Created an attachment (id=15133)
 --> (http://bugs.winehq.org/attachment.cgi?id=15133)
Test RTF document in CP1251, containing the "ya" letter

This test document was used to create the previously attached screenshot.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |richedit

--- Comment #2 from Vitaliy Margolen   2008-07-28 12:06:48 ---
What Wine version?

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

--- Comment #3 from Roman Mamedov   2008-07-29 08:29:56 ---
Wine 1.1.2 with latest changes from Git.
Version number is 1.1.2-91-g6a21ab2.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Roman Mamedov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.2

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Lei Zhang   2008-07-29 13:23:15 ---
confirming, native richedit doesn't display anything in Wine Wordpad.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Kirill K. Smirnov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Kirill K. Smirnov   2008-07-31 07:58:36 ---
Native windows riched20.dll works correctly.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #6 from Dylan Smith   2008-10-03 00:44:16 ---
Created an attachment (id=16441)
 --> (http://bugs.winehq.org/attachment.cgi?id=16441)
richedit: Unsigned cast char to avoid EOF equality

The character appears to have a value of 0xFF which got confused with an EOF
macro of -1 in the rich test parsing code.  Casting the character to an
unsigned value before being stored in an int variable prevented this confusion.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, source

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

--- Comment #7 from Dylan Smith   2008-10-06 16:12:33 ---
my patch has been committed (commit e6c3a2beeececd4b9320f5b3a46d2874c1d24310),
so you can test against the current git tree to see if it is fixed.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English   2008-10-06 16:32:48 ---
(In reply to comment #7)
> my patch has been committed (commit e6c3a2beeececd4b9320f5b3a46d2874c1d24310),
> so you can test against the current git tree to see if it is fixed.

Works fine in git.

[Bug 14674] Wine WordPad fails to correctly open CP1251 RTF documents with russian letter "ya"

http://bugs.winehq.org/show_bug.cgi?id=14674

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2008-10-10 10:10:28 ---
Closing bugs fixed in 1.1.6.