[Bug 58050] New: Game Controllers panel crashes on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58050

Bug ID: 58050
           Summary: Game Controllers panel crashes on exit
           Product: Wine
           Version: 9.21
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: d78cbe84e5f0000c6523c4b997de476b12d929b6
      Distribution: ---

Created attachment 78306
  --> https://bugs.winehq.org/attachment.cgi?id=78306
backtrace

1. Create a 64-bit prefix.
2. Run the following command 'wine64 control joy.cpl'.
3. Select 'DInput' tab and then switch back to 'Joysticks'.
4. Click Cancel.

[Bug 58050] Game Controllers panel crashes on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58050

--- Comment #1 from Bernhard Übelacker  ---
Hello Andrey, thanks for the report and I could reproduce the issue.
It looks like we enter UnregisterDeviceNotification twice for the same handle.

With ASan enabled this also shows up with d78cbe84e5f reverted,
so this issue existed already before, just did not manifest.

Does following patch avoid the crash in your setup?
https://gitlab.winehq.org/bernhardu/wine/-/commit/05fc002f02344913cc0f691eee...

[Bug 58050] Game Controllers panel crashes on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58050

--- Comment #2 from Andrey Gusev  ---
No more crash with the patch.

[Bug 58050] Game Controllers panel crashes on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58050

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |9427e8a975199f70a0f029a690e
                   |                            |1f622aff6d256

--- Comment #3 from Bernhard Übelacker  ---
Should be resolved-fixed by
https://gitlab.winehq.org/wine/wine/-/commit/9427e8a975199f70a0f029a690e1f62...