[Bug 20270] New: Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

Summary: Open/Save File dialog cannot be resized
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Wine's "Open File(s)" or "Save File(s)" dialog cannot be resized. This is
sometimes very useful when browsing folders with lots of files.

The feature has been present in Windows since the ME edition (I could be wrong,
but around that time), and it would make sense if Wine had it too.

I'm also attaching screenshots of file dialogs (Windows vs Wine).

[Bug 20270] Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #1 from unimatrix   2009-10-05 15:00:27 ---
Created an attachment (id=23946)
 --> (http://bugs.winehq.org/attachment.cgi?id=23946)
Windows File Dialog

The resize corner is clearly visible.

[Bug 20270] Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #2 from unimatrix   2009-10-05 15:01:17 ---
Created an attachment (id=23947)
 --> (http://bugs.winehq.org/attachment.cgi?id=23947)
Wine File Dialog

No resize corner, and the window isn't resizable at all.

[Bug 20270] Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #3 from Andrew Nguyen   2009-10-05 15:43:21 ---
I can't reproduce the problem with wine-1.1.30-287-g3c98992 using the Open/Save
dialogs spawned with Wine's notepad.exe. I believe resizable dialog
functionality has been available for some time.

[Bug 20270] Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #4 from unimatrix   2009-10-05 15:44:04 ---
(In reply to comment #3)
> I can't reproduce the problem with wine-1.1.30-287-g3c98992 using the Open/Save
> dialogs spawned with Wine's notepad.exe. I believe resizable dialog
> functionality has been available for some time.

Hmm, maybe it's more specific then.
Could you try it with Winamp?

[Bug 20270] Open/Save File dialog cannot be resized

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #5 from Andrew Nguyen   2009-10-05 16:29:46 ---
With Winamp 5.56, I do indeed see the problem you describe. The open file
dialog (spawned with File -> Play file...) isn't resizable with
wine-1.1.30-287-g3c98992, while the dialog on Windows XP is indeed resizable.
The description and information of the bug should probably be revised
accordingly.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

unimatrix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Open/Save File dialog       |Open file dialog in Winamp
                   |cannot be resized           |not resizable

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #6 from Vitaliy Margolen   2009-10-05 20:09:10 ---
You talking about new stile Open File dialog. Old style was not resizable.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #7 from Dmitry Timoshkov   2009-10-05 23:18:44 ---
Wine version? The bug 10394 for that problem has been fixed.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #8 from Andrew Nguyen   2009-10-05 23:49:29 ---
My tests were with wine-1.1.30-287-g3c98992. While I'm aware that bug 10394 is
fixed, there's probably another issue that's causing the display of a open file
dialog that isn't resizable, when it should be.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

unimatrix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.30

--- Comment #9 from unimatrix   2009-10-06 03:29:12 ---
I've tested it in 1.1.30 final, just to be clear. I doubt much has changed in
git since.

Anyway, like Andrew said, the dialog in Winamp should've been resizable. I will
add a screenshot of it in Windows.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #10 from unimatrix   2009-10-06 03:30:23 ---
Created an attachment (id=23951)
 --> (http://bugs.winehq.org/attachment.cgi?id=23951)
Winamp Open File Dialog in Windows

Resize corner clearly visible (and obviously serves the purpose well).

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Version|1.1.30                      |unspecified
     Ever Confirmed|0                           |1

--- Comment #11 from Rein Klazes   2009-10-06 06:01:17 ---
Confirming. Currently the dialog is sizable only if the OFN_ENABLESIZING flag
is provided (Winamp does not). MSDN says that the flag is only needed if a hook
procedure or custom template is provided (Winamp does not). Preliminary test
confirms this.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.30

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #12 from unimatrix   2009-10-06 09:59:55 ---
(In reply to comment #11)
> Confirming. Currently the dialog is sizable only if the OFN_ENABLESIZING flag
> is provided (Winamp does not). MSDN says that the flag is only needed if a hook
> procedure or custom template is provided (Winamp does not). Preliminary test
> confirms this.

Then what is the 3rd option? Obviously it has to exist since Windows makes it
resizable.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #13 from Rein Klazes   2009-10-06 11:05:21 ---
Created an attachment (id=23953)
 --> (http://bugs.winehq.org/attachment.cgi?id=23953)
preliminary patch.

Well here is a patch that fixes winamp's file dialog here.

I will need to add some tests to see if the details are correct, before I can
submit a final version.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

--- Comment #14 from Rein Klazes   2009-10-07 04:19:36 ---
Patch is submitted:

http://www.winehq.org/pipermail/wine-patches/2009-October/079592.html

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comdlg32

--- Comment #15 from Nikolay Sivov   2009-10-07 10:14:19 ---
Should be fixed with:

http://source.winehq.org/git/wine.git/?a=commit;h=3e76f88d2794e9979fe4a2dded...

Retest please.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Rein Klazes   2009-10-07 11:01:25 ---
Patch was committed, that means Wine is following the mentioned msdn
description now.

Marking fixed.

[Bug 20270] Open file dialog in Winamp not resizable

http://bugs.winehq.org/show_bug.cgi?id=20270

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2009-10-09 11:14:29 ---
Closing bugs fixed in 1.1.31.