[Bug 49068] New: 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

Bug ID: 49068
           Summary: 'Access violation in riched20.dll' with certain
                    GOG.com installers
           Product: Wine
           Version: 5.7
          Hardware: x86
               URL: https://www.gog.com/game/teenagent
                OS: Linux
            Status: NEW
          Keywords: Installer, regression
          Severity: normal
          Priority: P2
         Component: richedit
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 650aebadb7ade8b95766b5f2a9062c2210b0eca1
      Distribution: ---

Some (but not all) of the game installers from GOG.com are plagued by this
problem.
After the language selecting dialogue the following error messages are shown:

"Access violation at address 7AC51DD3 in module riched20.dll."

Followed by

"System error. Code: 1400. Invalid window handle."

Afterwards the installer quits prematurely.

Reverting commit 650aebadb7ade8b95766b5f2a9062c2210b0eca1 fixes the problem.
'winetricks riched20' also acts as a workaround.

Plain terminal output doesn't show anything unusual.
Looks like the problem occurs when Wine is compiled using the "--without-mingw"
flag.

The game 'Teenagent' is available for free on GOG. If you have an account then
you can reproduce the problem with that (download size ~20 MB). Otherwise just
let me know what debug log would be helpful.
https://www.gog.com/game/teenagent

wine-5.7-141-g0c27d244f7

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 67055
  --> https://bugs.winehq.org/attachment.cgi?id=67055
Foobar2000 installer crashlog

Foobar2000 installer crashes in riched20.dll on the license agreement screen.
In this case some sort of backtrace is generated.
Reverting commit 650aebadb7ade8b95766b5f2a9062c2210b0eca1 fixes the crash.
The problem is not present with a MingW-enabled Wine.

https://www.foobar2000.org/download

foobar2000_v1.5.3.exe
md5sum: 85fd7a0e515572819e196e27d66d98fd

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

--- Comment #2 from Jacek Caban  ---
This patch should help:
https://source.winehq.org/patches/data/184690

Thanks for the report.

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Jacek Caban from comment #2)
> This patch should help:
> https://source.winehq.org/patches/data/184690
>
> Thanks for the report.

The patch works for both cases, thank you.

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9763f5189f1312c82c98b3ce25c
                   |                            |b8100ae4cb420
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Béla Gyebrószki  ---
Fixed with
https://source.winehq.org/git/wine.git/commit/9763f5189f1312c82c98b3ce25cb81...

[Bug 49068] 'Access violation in riched20.dll' with certain GOG.com installers

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49068

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 5.8.