[Bug 30750] New: [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Bug #: 30750
           Summary: [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom
           Product: Wine
           Version: 1.5.4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dos
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 40271
  --> http://bugs.winehq.org/attachment.cgi?id=40271
patch v1

The 16 bit app coled EG (Evangelisches Gesangbuch), can't recognize cdrom to
install database. The reason is a bug in krnl386.exe16/int21.c code.
Suddenly i didn't found any documentation what correct flags should be set for
cdrom on 4409 (is drive remote) request. But this app has fallowing logic, an
this logic works on windows including XP, so i assume it is correct:
- first it ask interrupt 21h if the drive is remote.
- if it get response and 1000h (12bit) flag is set, then 
- it ask interrupt 2Fh to check if it is really cdrom.

if 1000h is not set, then deice is not cdrom.
Attached patch fixes this bug for me.

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

--- Comment #1 from Austin English  2012-05-22 15:59:32 CDT ---
Patches should be sent to [e-mail]

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, win16

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

--- Comment #2 from Oleksij Rempel  2012-05-25 03:56:34 CDT ---
Ok, i will send it.

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |75555c3011484b980f4e2b8dc6d
                   |                            |237abbba4a0ea
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #3 from Dan Kegel  2012-05-25 10:55:00 CDT ---
Committed,
http://source.winehq.org/git/wine.git/?a=commit;h=75555c3011484b980f4e2b8dc6...

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2012-05-25 13:43:04 CDT ---
Closing bugs fixed in 1.5.5.

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 30750] [patch] krnl386.exe16/int21.c: set (1<<12) for cdrom

http://bugs.winehq.org/show_bug.cgi?id=30750

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---