[Bug 9357] New: 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Summary: 1964 crashes:wine client error:9: write: Bad address
           Product: Wine
           Version: CVS
          Platform: Other
               URL: http://prdownloads.sourceforge.net/schibo/1964_099.exe?d
                    ownload
        OS/Version: Linux
            Status: UNCONFIRMED
          Keywords: download
          Severity: enhancement
          Priority: P2
         Component: wine-misc
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hi, a user submitted this into appdb, rated garbage. It crashes immediately
with:
wine client error:9: write: Bad address

To me it looks like there's something going wrong in advapi32.RegSetValueEx

Maybe this needs a small test case, and see if that's really the problem.
Attached is a +all trace

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #1 from Louis Lenders   2007-08-18 05:33:31 ---
Created an attachment (id=7648)
 --> (http://bugs.winehq.org/attachment.cgi?id=7648)
last lines of +all

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
          Component|wine-misc                   |wine-advapi32

--- Comment #2 from Louis Lenders   2007-08-18 06:09:38 ---
Just another note, it seems is indeed problem with RegsetValueEx. Next hack
makes the application start fine:

diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c
index e62206b..290c16e 100644
--- a/dlls/advapi32/registry.c
+++ b/dlls/advapi32/registry.c
@@ -1014,6 +1014,7 @@ LONG WINAPI RegSetValueExW( HKEY hkey, LPCWSTR name,
DWORD
 LONG WINAPI RegSetValueExA( HKEY hkey, LPCSTR name, DWORD reserved, DWORD
type,
                             CONST BYTE *data, DWORD count )
 {
+return 0;
     ANSI_STRING nameA;
     WCHAR *dataW = NULL;
     NTSTATUS status;

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Paul Vriens   2007-08-18 07:09:30 ---
If you look at the trace it seems that the application doesn't pass a pointer
to a DWORD but an actual value! (0x280). 
I've installed this one on Windows and it doesn't crash but the registry keys
aren't created as well.
I think this is a case where we should either catch an exception or check if
the passed pointer is valid.

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #4 from Paul Vriens   2007-08-18 07:24:33 ---
Created an attachment (id=7651)
 --> (http://bugs.winehq.org/attachment.cgi?id=7651)
Registry file for 1964

I've created this registry file based on the failures adding DWORDs (as shown
in a +reg trace). Of course this is just a workaround. It also shows there is
only an issue with the DWORD (I've add the 'pointer' as the exact value).
Needless to say that a) The program is at fault here b) we should handle it
better

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #5 from Paul Vriens   2007-08-18 07:36:47 ---
Another note. This issue is only present during install. When you start 1964
and delete some of the DWORD's in the registry and then close/exit 1964 the
DWORD's are properly created. The trace show they are proper pointers now
instead of values.

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Louis Lenders   2007-08-18 09:05:17 ---
> This issue is only present during install.

So maybe the bug is in the installer, and that's why the developers of 1964
didn't notice this bug, i guess?

Anyway, i'll drop a note in the appDB, so users will be able to start the
application , using the 1964-registry file. Thanks for looking

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

rhy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from rhy   2007-08-18 12:45:17 ---
So how do you delete those dwords?  Which ones specifically?  Without a fixed
registry file you can't open roms which means you effectively can't use the
emulator.  I'm really trying to find a decent n64 emulator for Ubuntu as that
is one of the primary functions of a computer I would like to get rid of
Windows on.  Everything else is neatly covered!

Thanks in advance!
rhY

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #8 from Louis Lenders   2007-08-18 13:10:04 ---
> So how do you delete those dwords?

I dropped a note in the appdb. If you just import the registry file, from
comment #4 (regedit 1964.reg) the app should start fine. So no need to delete
DWORDS (and if you want, do 'regedit' and look under HKCU/software/1964/Gui). 
If it the app works further on i don't know

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #9 from Louis Lenders   2007-08-18 13:19:13 ---
Oh, a last remark for "rhy":
if you really want this to be fixed quickly, you might want to contact the
developers about the bug in their code. I saw they had a kind of forum (it's
open source), where they discuss things

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

--- Comment #10 from Paul Vriens   2007-08-20 08:03:42 ---
The Wine part is fixed in current GIT :
(http://source.winehq.org/git/wine.git?a=commit;h=7378fac50582b46b89e0d97f36f...)

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Louis Lenders   2007-08-21 15:27:17 ---
<The Wine part is fixed in current GIT :
<(http://source.winehq.org/git/wine.git?a=commit;h=7378fac50582b46b89e0d97f36f...)

Yip, is fixed. Thx

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Louis Lenders   2007-08-21 15:27:50 ---
closed

[Bug 9357] 1964 crashes:wine client error:9: write: Bad address

http://bugs.winehq.org/show_bug.cgi?id=9357

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified