[Bug 23193] New: wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Summary: wine notepad: Slow to open large files
           Product: Wine
           Version: 1.2-rc1
          Platform: x86
               URL: http://winehq.org
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28858)
 --> (http://bugs.winehq.org/attachment.cgi?id=28858)
Long text file (3.1M uncompressed)

gunzip the attached file and open it in notepad. For me, it takes > 5 seconds
to open on a quadcore. WinXP notepad (both virtualbox and native) will open it
instantly.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23196

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Wylda   2010-06-15 07:27:03 ---

Sound similar to bug 21417. Is it fast in 1.1.34?

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #2 from Jerome Leclanche   2010-06-15 07:35:16 ---
(In reply to comment #1)
> Sound similar to bug 21417. Is it fast in 1.1.34?

*reverts and compiles*

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Jeff Zaroyko   2010-06-15 08:02:18 ---
Confirming.  I see the same thing.  A quick look at oprofile shows a lot of
time spent in gdi32.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #4 from Jeff Zaroyko   2010-06-15 08:03:58 ---
Created an attachment (id=28863)
 --> (http://bugs.winehq.org/attachment.cgi?id=28863)
oprofile report and annotated source

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28858|text/plain                  |application/x-gzip
          mime type|                            |

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #5 from Jerome Leclanche   2010-06-15 08:09:04 ---
(In reply to comment #1)
> Sound similar to bug 21417. Is it fast in 1.1.34

It is an issue in wine-1.1.34.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #6 from Dmitry Timoshkov   2010-06-15 11:10:54 ---
Is native notepad any better?

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

--- Comment #7 from Alexander Scott-Johns   2010-06-15 11:28:17 ---
This may have the same cause as bug 23196.
Is word wrap on?

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #8 from Jerome Leclanche   2010-06-15 11:34:40 ---
(In reply to comment #7)
> This may have the same cause as bug 23196.
> Is word wrap on?

(In reply to comment #7)
> This may have the same cause as bug 23196.
> Is word wrap on?

Word wrap is on, but the opening is still very slow without it.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Bruno Jesus  2011-10-25 20:59:09 CDT ---
Notepad crash silently (no bt) here while trying to open the test file (after
hanging the system for about 30 seconds. Tested in wine-1.3.31-89-g8d4245d.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends on|                            |30294

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #10 from Jerome Leclanche  2012-05-04 08:02:50 CDT ---
Seems worse in wine-1.5.3-101-g9c19ba6; takes about 11 seconds to open.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #11 from Aric Stewart  2012-05-04 08:37:25 CDT ---
(In reply to comment #10)
> Seems worse in wine-1.5.3-101-g9c19ba6; takes about 11 seconds to open.

worse then when?  Could you give me a bisect?  I have no outstanding patches
here and i felt like it was mostly resolved.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #12 from Jerome Leclanche  2012-05-04 08:51:23 CDT ---
(In reply to comment #11)
Well I can't tell you if it's actually worse, I was going by my original report
which said "> 5 seconds". I should retest on windows...

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Bug 23193 depends on bug 30294, which changed state.

Bug 30294 Summary: Crash in notepad when loading big text file
http://bugs.winehq.org/show_bug.cgi?id=30294

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #13 from Frédéric Delanoy  2012-05-04 13:07:30 CDT ---
(In reply to comment #12)
> (In reply to comment #11)
> Well I can't tell you if it's actually worse, I was going by my original report
> which said "> 5 seconds". I should retest on windows...

In my case, it loads in 54 seconds under wine, and <1s under Windows (in a VM)

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #14 from Frédéric Delanoy  2012-05-04 16:47:21 CDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > Well I can't tell you if it's actually worse, I was going by my original report
> > which said "> 5 seconds". I should retest on windows...
>
> In my case, it loads in 54 seconds under wine, and <1s under Windows (in a VM)

That was with "line/word wrap" enabled; it takes about half the time (± 26 s)
when disabled.
FWIW, from tests on Windows, the load time when line wrap is enabled is also
twice as long compared to when it's disabled.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |performance

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #15 from Frédéric Delanoy  2012-05-07 04:01:45 CDT ---
I tested with 1.2.3 (couldn't quickly find the OP reported 1.2-rc1), and it was
actually approximately 10 s *quicker* (± 20%)

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

Rafal Stanilewicz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Rafal Stanilewicz  2012-12-14 06:29:55 CST ---
Still very slow in wine 1.5.18. On my (decent) laptop, it took approx 20 second
to open the file.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #17 from Rafal Stanilewicz  2012-12-14 06:31:13 CST ---
Still very slow in wine 1.5.18. On my (decent) laptop, it took approx 20 second
to open the file.

[Bug 23193] wine notepad: Slow to open large files

http://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #18 from Frédéric Delanoy  2013-05-28 09:05:59 CDT ---
Still ~12 times slower with 1.5.31 (vs native notepad)

[Bug 23193] wine notepad: Slow to open large files

https://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #19 from Frédéric Delanoy  ---
Still in wine-1.9.19-95-g61e6e8b

[Bug 23193] wine notepad: Slow to open large files

https://bugs.winehq.org/show_bug.cgi?id=23193

Thomas Faber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Thomas Faber  ---
Created attachment 60235
  --> https://bugs.winehq.org/attachment.cgi?id=60235
Patch: re-use script caches

I've looked at this issue in the context of the corresponding ReactOS bug
(https://jira.reactos.org/browse/CORE-14192), and found that a lot of time was
spent in GetCharABCWidthsW.
The attached patch takes the load time for the test file down from 17 to 8.5
seconds on my machine (Wine HEAD). I'll submit it after the code freeze.

[Bug 23193] wine notepad: Slow to open large files

https://bugs.winehq.org/show_bug.cgi?id=23193

--- Comment #21 from Thomas Faber  ---
fb44feb62fd speeds this up a bunch, so it might warrant a retest. It's still
noticeably slower than Windows for me though, so I'm guessing it's not enough
to call this fixed.