[Bug 15842] New: winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Summary: winecfg: You don't have a drive C. This is not so great.
           Product: Wine
           Version: 1.1.7
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

START!
run winecfg
When I click on the Drives tab, a popup message says:
"You dont have a drive C. This is not so great."
"Remember to click 'Add' in the Drives tab to create one!"

At the same time, this message appears in the terminal:
"err:winecfg:open_mountmgr failed to open mount manager err 2"

When I click Add it adds the mapping ../drive_c to the letter C:.
When I click Apply, the message again appears in the terminal:
"err:winecfg:open_mountmgr failed to open mount manager err 2"

The next time I run winecfg, all of the above happens again from the START!

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vincent Povirk   2008-10-29 16:25:21 ---
It sounds like your wine prefix is broken. Does ~/.wine/drive_c exist? Does
this still happen if you move away ~/.wine ?

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #2 from linux fan   2008-10-29 16:48:10 ---
(In reply to comment #1)
> It sounds like your wine prefix is broken. Does ~/.wine/drive_c exist? Does
> this still happen if you move away ~/.wine ?

~/.wine/drive_c exists!
This still happens in 1.1.7 if I rm -r ~/.wine

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #3 from Vitaliy Margolen   2008-10-29 17:48:18 ---
Have you verified that ~/.wine directory was really removed?

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #4 from linux fan   2008-10-29 18:27:35 ---
(In reply to comment #3)
> Have you verified that ~/.wine directory was really removed?

Yes, verified that it was really removed.

But ...
The problem starts after having changed the Windows Version to Windows 98.
Thereafter, re-running winecfg exhibits the problem.

Changing the Windows Version to XP or 2000 does not cause the problem.
However, I want to run Windows Version 98.
Why should that cause a problem?

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Austin English   2008-10-29 20:32:51 ---
Confirming. I bet it was one of Alexandre's recent mountmgr/ntdll patches...

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source

--- Comment #6 from Austin English   2008-10-30 10:09:05 ---
(In reply to comment #5)
> Confirming. I bet it was one of Alexandre's recent mountmgr/ntdll patches...

austin@austin-desktop:~/wine-git$ git bisect good
abe00bbebe6c64df9d54038b8f7a2a1d1bddbe1f is first bad commit
commit abe00bbebe6c64df9d54038b8f7a2a1d1bddbe1f
Author: Alexandre Julliard 
Date:   Thu Oct 23 16:29:11 2008 +0200

winecfg: Load the existing drive config from mountmgr instead of relying on
QueryDosDevice.

:040000 040000 a99a7824bfb1387b0250be97d3173966c25a43f3
506d47c28e5fec8b0ee9d2ef08946244109aea0e M      programs

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Alexandre Julliard   2008-10-30 15:31:12 ---
This is fixed now.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Dmitry Timoshkov   2008-10-31 12:25:07 ---
*** Bug 15865 has been marked as a duplicate of this bug. ***

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #9 from Christoph Korn   2008-10-31 13:04:34 ---
I compiled the current git head and the bug is still there.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #10 from Christoph Korn   2008-10-31 14:36:38 ---
Created an attachment (id=17011)
 --> (http://bugs.winehq.org/attachment.cgi?id=17011)
+file,+mountmgr trace

The bug is still present on latest git head.

I used the wine-1.1.7 build for testing.

The output of winecfg using +file,+mountmgr trace is attached.

This seems to be the part of interest:
trace:file:CreateFileW L"\\.\MountPointManager" GENERIC_READ GENERIC_WRITE
FILE_SHARE_READ FILE_SHARE_WRITE  creation 3 attributes 0x0
trace:file:RtlDosPathNameToNtPathName_U
(L"\\.\MountPointManager",0x32cce0,(nil),(nil))
trace:file:RtlGetFullPathName_U (L"\\.\MountPointManager" 520 0x32ca54
(nil))
warn:file:CreateFileW Unable to create file L"\\.\MountPointManager" (status
c0000034)
trace:file:CreateFileW returning 0xffffffff
err:winecfg:open_mountmgr failed to open mount manager err 2

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #11 from Christoph Korn   2008-10-31 14:46:48 ---
Created an attachment (id=17012)
 --> (http://bugs.winehq.org/attachment.cgi?id=17012)
+process trace

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #12 from Austin English   2008-10-31 15:58:56 ---
(In reply to comment #7)
> This is fixed now.

No, it's actually worse now :-(.

Before, you had to do:
$ rm -rf ~/.wine
$ winecfg # set windows mode to 98, close winecfg
$ winecfg # open drives tab
ERROR!

but now:
$ rm -rf ~/.wine
$ winecfg # open drives tab
ERROR!

And for me, C is mapping to /!

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #13 from Christoph Korn   2008-11-05 13:59:01 ---
Which patch was supposed to fix this btw?

There were only minor changes of winecfg after the regression:
winecfg: Display an nicer error when the mount manager cannot be accessed.
http://source.winehq.org/git/wine.git/?a=commit;h=6ccf01fe8ab89c436c0ba55779...

winecfg: Add ellipsis ('...') to buttons that launch other dialogs.
http://source.winehq.org/git/wine.git/?a=commit;h=bd645a8482eb4f68e4b4c7471d...

winecfg: Renamed 'Shell Folder' to 'Folder'.
http://source.winehq.org/git/wine.git/?a=commit;h=20d8e4685853ed1b3ea433b90b...

winecfg: Set default windows version to XP.
http://source.winehq.org/git/wine.git/?a=commit;h=f64fbe2ef3838ad54bab332600...

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Austin English   2008-11-05 14:04:52 ---
(In reply to comment #13)
> Which patch was supposed to fix this btw?
>
> There were only minor changes of winecfg after the regression:

Should've been one of these two:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=8551c8d50ea77cd15fb683...
http://source.winehq.org/git/wine.git/?a=commitdiff;h=5002bd21d12e99b69bce7d...

But I haven't tried building to be sure. On second thought, I'm going to close
this bug fixed and file a new one. The original bug is fixed. The new crash is
a different, but related.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #15 from Austin English   2008-11-05 14:08:18 ---
Bug 15916

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #16 from Alexandre Julliard   2008-11-06 02:52:46 ---
The fix for the win98 bug is 7c6302b7ff5571a5119a7dea2f946e043b956156.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2008-11-07 10:47:10 ---
Closing bugs fixed in 1.1.8.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from [e-mail]  2009-11-16 09:21:53 ---
For me this bug is not fixed; tested with a clean setup on multiple PCs:

1) install Ubuntu 9.10 amd64 in a VM
2) install Wine 1.1.33 per winehq.org instructions (had to install the wine1.2
package as installing wine package gives error messages)
3) Copied over a complete wine environment with just one application
4) ran: # WINEPREFIX=/home/user/Deadlock/ winecfg
5) Changed windows version to Windows 98 (game requires this or no sound),
removed all the desktop integration symlinks stuff, added D drive to be the
CDROM, click OK.
6) Run winecfg again; still lists my C and D drives as configured
7) ran: # WINEPREFIX=/home/user/Deadlock/ wine "C:\Deadlock\DEADLOCK.EXE"
8) Now get warning message "Warning: could not find DOS drive for current
working directory '/home/user/Deadlock/drive_c/Deadlock', starting in the
Windows directory.
9) at this point the game runs but doesn't see the CDROM; when i relaunch
winecfg both my C and D drives are gone: "You don't have a drive C. This is not
so great. Remember to click 'Addd' in the Drives tab to create one!".

This works on my other system with Ubuntu 9.04 amd64 and Wine 1.1.32. It didn't
on my new Ubuntu 9.10 + Wine 1.1.33 system, so i tried to reproduce it in a VM
and i could.

Any suggestions?

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #19 from Austin English   2009-11-19 01:53:49 ---
(In reply to comment #18)
> For me this bug is not fixed; tested with a clean setup on multiple PCs:
> - install Ubuntu 9.10 amd64 in a VM
> - install Wine 1.1.33 per winehq.org instructions (had to install the wine1.2
>
> package as installing wine package gives error messages)
> 3) Copied over a complete wine environment with just one application
> 4) ran: # WINEPREFIX=/home/user/Deadlock/ winecfg
> 5) Changed windows version to Windows 98 (game requires this or no sound),
> removed all the desktop integration symlinks stuff, added D drive to be the
> CDROM, click OK.
> 6) Run winecfg again; still lists my C and D drives as configured
> 7) ran: # WINEPREFIX=/home/user/Deadlock/ wine "C:\Deadlock\DEADLOCK.EXE"
> 8) Now get warning message "Warning: could not find DOS drive for current
> working directory '/home/user/Deadlock/drive_c/Deadlock', starting in the
> Windows directory.

You probably deleted the Z:\ symlink, and then didn't cd to somewhere that wine
can map to a drive letter, confusing it...

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #20 from [e-mail]  2009-11-23 22:13:27 ---
Quite possibly true! thanks for that comment Austin.

Though, i would think this is a bug in itself. The drive-mappings work with
absolute paths; i enter /home/user/CD for example, not C:\CD or any relative
path. So i would assume Wine is able to accept that, without needing the Z:
drive mapping.

My other concern is about security, if i give the application access to Z: it
would be almost equavalent to full root access; it would have access to network
mounted filesystems and basically everything i hold deer. My philosophy is that
applications should only have access to things they have business to do with;
and should be denied access to any part which they have no reason to access.
Right now clicking a .exe might screw the entire system; while without Z
mapping the damage will be limited as the .wine directory acts as a sort of
sandbox to the application.

Is there any bug that focuses on this, what is the opinion of the Wine project
concerning security? Any chance Wine would be modified to allow running with Z
mapping, so that i do not put my entire system at risk?

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #21 from Vincent Povirk   2009-11-23 22:22:52 ---
This isn't the place, but Wine cannot provide any real security. It has no
ability to prevent a Windows program from making native system calls and
accessing the native filesystem. Removing z: at best provides security by
obscurity, and it's confusing, so it's not recommended.

[Bug 15842] winecfg: You don't have a drive C. This is not so great.

http://bugs.winehq.org/show_bug.cgi?id=15842

--- Comment #22 from Austin English   2009-11-23 22:25:04 ---
(In reply to comment #20)
> Quite possibly true! thanks for that comment Austin.
>
> Though, i would think this is a bug in itself. The drive-mappings work with
> absolute paths; i enter /home/user/CD for example, not C:\CD or any relative
> path. So i would assume Wine is able to accept that, without needing the Z:
> drive mapping.

Somewhat, but it tries to see what current directory you are in, which is
giving you your problem.
> My other concern is about security, if i give the application access to Z: it
> would be almost equavalent to full root access; it would have access to network
> mounted filesystems and basically everything i hold deer. My philosophy is that
> applications should only have access to things they have business to do with;
> and should be denied access to any part which they have no reason to access.
> Right now clicking a .exe might screw the entire system; while without Z
> mapping the damage will be limited as the .wine directory acts as a sort of
> sandbox to the application.
>
> Is there any bug that focuses on this, what is the opinion of the Wine project
> concerning security? Any chance Wine would be modified to allow running with Z
> mapping, so that i do not put my entire system at risk?

Wine by itself can't do that. You want something like SELinux or AppArmor.