[Bug 9459] New: FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Summary: FIFA 2007 crashes with the recent versions
           Product: Wine
           Version: 0.9.44.
          Platform: PC
               URL: http://appdb.winehq.org/appview.php?iVersionId=6444&sSho
                    wAll=Show+All+Tests
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-directx
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Many of our users complain about the FIFA 2007 support of latest versions. It
has a critical issue that crashes the program after the main menu. Please check
the included URL. If you need more information I can submit it because I can
reproduce this problem.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|Hours                       |---

--- Comment #1 from Vitaliy Margolen   2007-08-25 18:44:44 ---
Please attach complete terminal output.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #2 from KAMI   2007-08-26 09:40:32 ---
Created an attachment (id=7807)
 --> (http://bugs.winehq.org/attachment.cgi?id=7807)
FIFA 2007 - Crashing - Terminal output

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #3 from KAMI   2007-08-26 09:42:07 ---
I didn't tested but some users reported this version have not been being
working since 0.9.41...

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Ari  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kennethvancoppenolle@gmail.c
                   |                            |om

--- Comment #4 from Ari   2007-08-26 13:30:42 ---
> From looking around a little I noticed people who get this error all started

getting it with the newer versions of wine, but had the game working just fine
with older versions. The highest working wine version I believe was 0.9.40

As for the problem itself, the game can start up fine, and you can do things in
the menu, but the game crashes whenever you either load a match or go to the
'create a player' screen - which might mean that it's the 3d engine causing the
problems.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #5 from Austin English   2007-08-26 13:35:32 ---
Then please run a regression test between 0.9.40 and 0.9.41 and post the
results here:

http://wiki.winehq.org/RegressionTesting

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #6 from Lei Zhang   2007-08-29 18:18:45 ---
Is this the same game as the one in bug 8292? Does the demo hve the same
problem?

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Peter Lewis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Tomasz Czapiewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Tomasz Czapiewski   2007-09-11 14:27:53 ---
I can confirm that bug, too.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Javier Pérez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Javier Pérez   2007-09-14 22:32:25 ---
I ran a regression test, here are the results:

9ba3f389f665aae45b6a8a6861f9621b020e5c25 is first bad commit
commit 9ba3f389f665aae45b6a8a6861f9621b020e5c25
Author: Stefan D��singer 
Date:   Sun Jul 8 23:33:48 2007 +0200

wined3d: Initialize surfaces at creation.

:040000 040000 f711e971d19869f9cc28c0b317ea8bd9f328350b
d3768b1530ac1f3333aa0f2ec0f86535b5038197 M  dlls

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #9 from KAMI   2007-09-17 13:29:12 ---
Same with .45

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|http://appdb.winehq.org/appv%7Chttp://download2.gamershell.
                   |iew.php?iVersionId=6444&sSho|com/cgi-
                   |wAll=Show+All+Tests         |bin/fhx.pl?auth=dJ0Nd3vkQM%2
                   |                            |FbY&id=15478&ts=1190054718&c
                   |                            |at=demo&filename=FIFA07_Demo
                   |                            |.zip
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #10 from Louis Lenders   2007-09-17 15:31:27 ---
Confirming the bug with the downloadable demo. Also the regression test proves
to have found the correct "regression causer". Simply reverting the part like
here below, makes the game start fine again. Stefan, if you have time, could
you have a look?

diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
index 7bad3d7..8f23d2d 100644
--- a/dlls/wined3d/surface.c
+++ b/dlls/wined3d/surface.c
@@ -3916,7 +3916,7 @@ static HRESULT WINAPI
IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) {
         This->glRect.bottom = This->pow2Height;
     }

-    if(This->resource.allocatedMemory == NULL) {
+    if((This->resource.allocatedMemory == NULL)
&&(GL_SUPPORT(APPLE_CLIENT_STORAGE))) {
         /* Make sure memory exists from the start, and it is initialized
properly. D3D initializes surfaces,
          * gl does not, so we need to upload zeroes to init the gl texture.
          */

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #11 from Stefan Dösinger   2007-09-17 16:04:43 ---
Does the game crash in that initialization code, or later on? Can you attach a
+d3d,+d3d_surface trace?

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #12 from KAMI   2007-09-17 23:03:47 ---
The game fails on first time when the 3D engine gets initializad. So You can
start the game, select the options, and the loading sreens is come up, but the
nothing happen and the console throve that messages that I attached.
How can I create +d3d,+d3d_surface trace?

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #13 from Austin English   2007-09-18 04:05:49 ---
$ WINEDEBUG=+d3d,+d3d_surface wine program.exe &> /tmp/d3d.txt

Attach /tmp/d3d.txt here. If it is too large, compress with bzip2 or rzip.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #14 from Stefan Dösinger   2007-09-18 04:09:41 ---
lrzip is very good for logs too. Compresses a 300 mb log to 500kb.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #15 from Louis Lenders   2007-09-18 12:48:11 ---
Created an attachment (id=8134)
 --> (http://bugs.winehq.org/attachment.cgi?id=8134)
+d3d,+d3d_surface

I only added last 10000 lines before the crash, log itsself was 517Mb....

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Gilboa Davara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Gilboa Davara   2007-09-29 09:47:36 ---
Does anyone knows if this issue was fixed in .46?

- Gilboa

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #17 from KAMI   2007-12-28 03:46:35 ---
Hello!
Gilboa: this bug is not fixed (tested todey with the latest released version).

WINE Team: can you fix this regression? How can I help the work?

KAMI

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.0.0

--- Comment #18 from Dan Kegel   2007-12-28 06:13:34 ---
Popular game, regression cause found (and it looks like mac port damage),
so nominating for 1.0

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #19 from KAMI   2007-12-28 06:20:44 ---
Thank you Dan!
I did not find the roadmap, when 1.0.0 will be available? Can you force the fix
for this issue?

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|_obsolete_directx           |-unknown

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #20 from Stefan Dösinger   2008-03-23 10:20:42 ---
Created an attachment (id=11564)
 --> (http://bugs.winehq.org/attachment.cgi?id=11564)
Proposed patch

This patch fixes the problem for me. The issue was that on a resolution change
immediately at startup the smaller memory block wasn't freed properly. This
patch frees it, so when the surface is locked the next time the surface code
reallocates it with the proper size.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #21 from Dan Kegel   2008-03-23 12:11:54 ---
Adding keyword 'patch'.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #22 from Gregor Münch   2008-03-24 10:05:29 ---
Patch works here with the fifa 2004 demo. (same engine)

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #23 from Stefan Dösinger   2008-03-27 13:51:15 ---
patch is committed

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

suawek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from suawek   2008-03-27 18:24:10 ---
Patch works perfectly with Wine 0.9.58 and Fifa 2007 Demo. Thank you

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard   2008-04-04 10:06:14 ---
Closing bugs fixed in 0.9.59.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #26 from suawek   2008-04-15 14:33:09 ---
In the newest Wine version (0.9.59) the game runs almost properly. Almost,
because although the game starts properly, a thousands of black rectangles all
over the screen can be seen during the match. I don't know whether it's
"connected" with this bug (9459), but when I've applied the patch from this
topic in Wine 0.9.58 everything was looking ok.

[Bug 9459] FIFA 2007 crashes with the recent versions

http://bugs.winehq.org/show_bug.cgi?id=9459

--- Comment #27 from suawek   2008-04-15 14:34:03 ---
Created an attachment (id=12213)
 --> (http://bugs.winehq.org/attachment.cgi?id=12213)
Black rectangles during the gameplay