http://bugs.winehq.org/show_bug.cgi?id=17970
Summary: Altium DXP 2004 combo boxes cannot be selected Product: Wine Version: 1.1.9 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: ninevoltz@metalink.net
When trying to select an item with the mouse inside any combo boxes in DXP 2004, an error is generated stating that it cannot focus an invisible or disabled window. Using the arrow keys will allow you to select an item using the keyboard. Running a regression test with git bisect reveals the following patch:
5dfcadd7a3af47f61d056441407548ae8aef2004 is first bad commit commit 5dfcadd7a3af47f61d056441407548ae8aef2004 Author: Dmitry Timoshkov dmitry@codeweavers.com Date: Wed Nov 19 13:52:36 2008 +0800
user32: Do not change focus if the window is no longer active.
:040000 040000 337de18b4bf511f2e29e9ba5678ecc3386f13a86 8013d74ba7f22df7f4a77089d20c0ff6ba86f199 M dlls
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #1 from John Voltz ninevoltz@metalink.net 2009-04-07 12:33:40 --- Created an attachment (id=20328) --> (http://bugs.winehq.org/attachment.cgi?id=20328) Patch to remove the bug
This is a patch to remove the bug from Wine. I'm not sure what the appropriate fix would be because I don't know why this line of code was introduced. What bug does it fix?
http://bugs.winehq.org/show_bug.cgi?id=17970
John Voltz ninevoltz@metalink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@codeweavers.com
http://bugs.winehq.org/show_bug.cgi?id=17970
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2009-04-07 23:32:54 --- Is there a demo version of this program available?
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #3 from John Voltz ninevoltz@metalink.net 2009-04-08 06:49:21 --- (In reply to comment #2)
No, unfortunately there is no demo version anymore, and the viewer edition is not free anymore either. What was that line of code in user32 intended to fix? I might be able to fix the regression myself if you could explain that line's purpose. I have a little bit of Windows programming experience.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #4 from Dmitry Timoshkov dmitry@codeweavers.com 2009-04-08 08:50:35 --- (In reply to comment #3)
No, unfortunately there is no demo version anymore, and the viewer edition is not free anymore either. What was that line of code in user32 intended to fix? I might be able to fix the regression myself if you could explain that line's purpose. I have a little bit of Windows programming experience.
The patch has fixed an application (a proprietary one I can't mention here) which was creating a popup window and during its initialization/creation/ activation changed focus/active window to another one. Setting focus was breaking keyboard input for that other window.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #5 from John Voltz ninevoltz@metalink.net 2009-04-09 07:32:48 --- Looking at DXP a little closer, I notice that the combo boxes are not normal Windows combo boxes. They have the appearance of a combo box, but when you click the arrow button, it is actually a tiny popup scrolling list window that appears below the box, in exactly the same size as the combo box. Weird... And it steals the focus from the rest of the application, so that you can't do anything else until you select a list item.
Dmitry, can you email me with the name of your application off the record? Is it something I might have or can download to test?
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #6 from Dmitry Timoshkov dmitry@codeweavers.com 2009-04-09 10:30:32 --- (In reply to comment #5)
Dmitry, can you email me with the name of your application off the record? Is it something I might have or can download to test?
I'm afraid I can't do that, sorry.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #7 from John Voltz ninevoltz@metalink.net 2009-04-09 11:15:13 --- Ok, what direction is forward from here? Should I close the bug as a WONTFIX and just leave the patch here for anyone who might use DXP? I don't really know of an easy way to resolve the regression unless you have an idea. It sounds like a conflict in the way these two apps are using that API functionality.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #8 from Austin English austinenglish@gmail.com 2009-04-09 17:49:44 --- (In reply to comment #7)
Ok, what direction is forward from here? Should I close the bug as a WONTFIX and just leave the patch here for anyone who might use DXP? I don't really know of an easy way to resolve the regression unless you have an idea. It sounds like a conflict in the way these two apps are using that API functionality.
No, it's still a bug. The best thing to do would be to get a testcase showing what the application does under windows.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #9 from John Voltz ninevoltz@metalink.net 2009-04-10 06:44:50 --- (In reply to comment #8)
Further investigation reveals that DXP was written in Borland Delphi. The questionable combo box controls are third party controls written by rhoStyle. They have a shareware demo available here:
http://www.rhostyle.com/xpStyle.html
The control class is called TXPComboBox. It was used as a method for the DXP programmers to make DXP windows have the appearance of running on WINXP when you ran it on WIN2k.
There is a compiled demo in the zip file:
xpStyle/Demo/ComboBox/comboDemo.exe
I have a nice little "forensic" program called rpiSpy that will tell you the class names of controls and other info. Is there someplace on WineHQ I could upload it for others to use? It's an example program from a Windows API programming book. I'm not sure if that would be legal or not, it's not a commercial program, but I'm not sure about the copyright. The source is available though, so maybe I can create a Wine version of it...or maybe nobody needs it anyway?
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #10 from John Voltz ninevoltz@metalink.net 2009-04-10 07:54:04 --- The bug doesn't appear with the demo of XP style, so never mind that.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #11 from John Voltz ninevoltz@metalink.net 2009-04-10 08:09:39 --- I suppose they may have written their own combo box control class and coincidentally named it TXPComboBox. I'm very sure that DXP was written in Delphi, because they also have their own scripting system embedded in DXP using Pascal.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #12 from Dmitry Timoshkov dmitry@codeweavers.com 2009-04-29 11:31:43 --- Is it possible to create a small sample which shows the problem?
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #13 from John Voltz ninevoltz@metalink.net 2009-04-29 12:11:58 --- (In reply to comment #12)
Is it possible to create a small sample which shows the problem?
Unfortunately, no. The third party control I thought they were using doesn't exhibit the same problem. There are no demos from Altium to use either.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #14 from Austin English austinenglish@gmail.com 2009-10-29 15:26:10 --- Is this still an issue in current (1.1.32 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=17970
greg.burley@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |greg.burley@gmail.com
--- Comment #15 from greg.burley@gmail.com 2010-03-05 16:55:14 --- (In reply to comment #14)
Is this still an issue in current (1.1.32 or newer) wine?
It is still an issue with wine-1.1.39 and AltiumDesigner Winter09.
http://bugs.winehq.org/show_bug.cgi?id=17970
Marcus Meissner marcus@jet.franken.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcus@jet.franken.de
--- Comment #16 from Marcus Meissner marcus@jet.franken.de 2010-05-29 06:08:14 --- there were still quite some changes in wines window handling in the last weeks, could you check again?
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #17 from John Voltz johnvoltz@gmail.com 2010-06-01 08:08:37 --- (In reply to comment #16)
Yes, the bug is still there. And frankly, it will remain there until the offending line of code is removed like the patch shows. But it's a quick-fix hack for some other problem, so it's not likely to get removed any time soon.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #18 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-01 09:21:17 --- This regression can't be fixed until there is a test case replicating the problem.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #19 from John Voltz johnvoltz@gmail.com 2010-06-01 09:44:26 --- (In reply to comment #18)
There is a 30 day demo of Altium Designer available now, if you are willing to download it and set it up, I can provide instructions on how to duplicate the bug. The demo is at http://www.altium.com/switch-now/evaluate.cfm they require you to fill out a form then they email you a license to use when starting it up. I can also help with any start-up issues you might encounter.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #20 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-01 09:48:56 --- (In reply to comment #19)
There is a 30 day demo of Altium Designer available now, if you are willing to download it and set it up, I can provide instructions on how to duplicate the bug. The demo is at http://www.altium.com/switch-now/evaluate.cfm they require you to fill out a form then they email you a license to use when starting it up. I can also help with any start-up issues you might encounter.
Does the demo has the same problem? If yes, please provide the instructions how to reproduce it.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #21 from John Voltz johnvoltz@gmail.com 2010-06-01 09:53:43 --- How to duplicate the bug:
1. Start Altium Designer 2. Select File->New PCB 3. Select Place->Pad 4. Press the Tab key on your keyboard and the properties dialog will appear. 5. Try to select an item from any of the combo boxes and the bug should appear as an error message.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #22 from John Voltz johnvoltz@gmail.com 2010-06-01 09:57:46 --- The demo does exhibit the bug. You will get an error message something like the following:
Cannot focus a disabled or invisible window at 1415D5AB. ADVPCB.DLL, Base Address: 140F0000.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #23 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-03 09:26:07 --- (In reply to comment #19)
There is a 30 day demo of Altium Designer available now, if you are willing to download it and set it up, I can provide instructions on how to duplicate the bug. The demo is at http://www.altium.com/switch-now/evaluate.cfm they require you to fill out a form then they email you a license to use when starting it up. I can also help with any start-up issues you might encounter.
How much time does it take to get an e-mail with a demo license? I haven't received one yet.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #24 from John Voltz johnvoltz@gmail.com 2010-06-03 09:44:23 --- (In reply to comment #23)
How much time does it take to get an e-mail with a demo license? I haven't received one yet.
Sorry, I just remembered, you have to go to http://trial.altium.com/ and click the download button to download the installer zip file. It's 1.58GB in size. While that's downloading, you can create an account to login and get a trial license. Of course you will probably end up getting a call from one of their sales drones later on after receiving your license :-\
http://bugs.winehq.org/show_bug.cgi?id=17970
Sven Plaga sven.plaga@fh-deggendorf.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sven.plaga@fh-deggendorf.de
--- Comment #25 from Sven Plaga sven.plaga@fh-deggendorf.de 2010-08-03 12:55:34 --- Bug is in 1.2 final, too.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #26 from Dmitry Timoshkov dmitry@codeweavers.com 2010-08-03 21:48:01 --- (In reply to comment #23)
(In reply to comment #19)
There is a 30 day demo of Altium Designer available now, if you are willing to download it and set it up, I can provide instructions on how to duplicate the bug. The demo is at http://www.altium.com/switch-now/evaluate.cfm they require you to fill out a form then they email you a license to use when starting it up. I can also help with any start-up issues you might encounter.
How much time does it take to get an e-mail with a demo license? I haven't received one yet.
I have received an e-mail asking me how I'm going to use the product, and I replied that my intention is to fix this bug. Haven't heard anything after that from them.
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #27 from John Voltz johnvoltz@gmail.com 2010-08-04 07:20:21 --- (In reply to comment #26)
I have received an e-mail asking me how I'm going to use the product, and I replied that my intention is to fix this bug. Haven't heard anything after that from them.
Dmitry, just go to their website and create a login. It will automatically generate a password and email it to you. Then you just login and request a trial license. It will automatically be emailed to you. Then, inside Altium Designer, under the DXP menu, click "My Account". Then "Sign In". It should automatically find your trial license from your login. You can convert it to a standalone license file from there, if you need.
http://altium.com/evaluate/download-trial.cfm
http://bugs.winehq.org/show_bug.cgi?id=17970
Alex Belits abelits@phobos.illtel.denver.co.us changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |abelits@phobos.illtel.denve | |r.co.us
--- Comment #28 from Alex Belits abelits@phobos.illtel.denver.co.us 2011-07-01 22:27:44 CDT --- As of Wine 1.3.23 the bug is still there.
http://bugs.winehq.org/show_bug.cgi?id=17970
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|dmitry@baikal.ru |
http://bugs.winehq.org/show_bug.cgi?id=17970
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5dfcadd7a3af47f61d056441407 | |548ae8aef2004
http://bugs.winehq.org/show_bug.cgi?id=17970
--- Comment #29 from Bruno Jesus 00cpxxx@gmail.com 2013-02-23 17:38:01 CST --- Is this still an issue in the latest development version of wine?
http://bugs.winehq.org/show_bug.cgi?id=17970
Joeseyefone joeseyefone@icloud.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joeseyefone@icloud.com
https://bugs.winehq.org/show_bug.cgi?id=17970
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |RESOLVED URL| |http://altium.com/evaluate/ | |download-trial.cfm CC| |focht@gmx.net Resolution|--- |ABANDONED
--- Comment #30 from Anastasius Focht focht@gmx.net --- Hello folks,
no further response from OP, resolving 'abandoned'.
Regards
https://bugs.winehq.org/show_bug.cgi?id=17970
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #31 from Austin English austinenglish@gmail.com --- Closing.