[Bug 19916] New: Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Summary: Steam client color scheme appears as green/red instead
                    of gray/brown
           Product: Wine
           Version: 1.1.29
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The Steam client color scheme now appears as green/red instead of the normal
gray/brown. I didn't see any unusual errors output in the console, but I see
from git that new ColorShifts code has been implemented so I assume this is the
problem. This problem doesn't occur in any previous wine versions I've tried.

I'm running Ubuntu Jaunty x86_64 with an Athlon X2 3400+ processor and Nvidia
7800GT video card.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #1 from Austin English   2009-09-02 18:17:48 ---
Regression test?
http://wiki.winehq.org/RegressionTesting

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|winex11.drv                 |-unknown

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Vitaliy Margolen   2009-09-02 22:11:41 ---
Confirming. Regression was introduced in the last few days.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.steampowered.com
                   |                            |/
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #3 from Vitaliy Margolen   2009-09-02 23:13:59 ---
5fc017c49734edc89a93b18d87c80f34da2444ff is first bad commit
commit 5fc017c49734edc89a93b18d87c80f34da2444ff
Author: Roderick Colenbrander 
Date:   Tue Sep 1 21:48:29 2009 +0200

winex11: Use ColorShifts from physDev in X11DRV_PALETTE_ToPhysical.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #4 from Roderick Colenbrander   2009-09-03 02:41:52 ---
Created an attachment (id=23396)
 --> (http://bugs.winehq.org/attachment.cgi?id=23396)
Possible fix

Please check if this patch fixes the problem. This is something I spotted
yesterday evening when adding some other new code.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Laissus Yoann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Laissus Yoann   2009-09-03 06:45:25 ---
Your patch fixes this issue for me. Thanks.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #6 from André H.   2009-09-03 13:39:29 ---
An other user also reported that this patch fixes some graphical issues in
steam for him

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Nephyrin zey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Nephyrin zey   2009-09-03 15:21:18 ---
I can confirm this bug:
http://www.infernalsoul.net/Junk/Dump/screenshot13.png

The patch resolves it

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Christoph Korn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #8 from Robert M. Muncrief   2009-09-05 15:29:45 ---
(In reply to comment #4)
> Created an attachment (id=23396)

--> (http://bugs.winehq.org/attachment.cgi?id=23396) [details]
> Possible fix
>
> Please check if this patch fixes the problem. This is something I spotted
> yesterday evening when adding some other new code.

Thank you Mr. Colenbrander. The patch fixes the problem for me. By the way,
I've switched to a Phenom II X4 945 since initially reporting the bug, but I
tested to make sure the bug still affected me before trying your patch.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #9 from [e-mail]  2009-09-06 13:48:41 ---
(In reply to comment #4)
> Created an attachment (id=23396)

--> (http://bugs.winehq.org/attachment.cgi?id=23396) [details]
> Possible fix

I was also affected by this bug, this patch resolves the issue on my end too.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Roderick Colenbrander   2009-09-08 11:57:09 ---
Fixed in Git.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Marcus Meissner   2009-09-10 04:14:20 ---
Roderick,

is this commit bb457f7ffd3d6957861f96846de0e1115100368e  ?

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #12 from Roderick Colenbrander   2009-09-10 04:34:55 ---
It should be:
70241904b9efacab9fb6c7d8701b1cfdb86f49f7

Roderick

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from [e-mail]  2009-09-11 08:03:58 ---
how to use the patch? How to download it? :S Just copy it?

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #14 from Marcus Meissner   2009-09-11 08:12:19 ---
unless you build your own wine, it will be useless to you.

I have applied this Patch to the SUSE RPMs and they will be published on Monday
for instance.

It also will of course be in the next release.

You can point the creator of your packages to this bug, he should know what to
do.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #15 from [e-mail]  2009-09-11 08:19:00 ---
i guess i compiled it and installed it but im very new to ubuntu, linux et c...
could you make a breif guide on what to do?

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #16 from Roderick Colenbrander   2009-09-11 08:23:10 ---
The ubuntu 1.1.29 packages also contain this fix.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #17 from [e-mail]  2009-09-11 09:22:10 ---
(In reply to comment #16)
> The ubuntu 1.1.29 packages also contain this fix.

How to get it?

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

--- Comment #18 from Christoph Korn   2009-09-11 09:29:11 ---
(In reply to comment #17)
> (In reply to comment #16)
> > The ubuntu 1.1.29 packages also contain this fix.
>
> How to get it?

https://launchpad.net/~ubuntu-wine/+archive/ppa

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Vitaliy Margolen   2009-09-23 21:10:15 ---
*** Bug 20140 has been marked as a duplicate of this bug. ***

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

http://bugs.winehq.org/show_bug.cgi?id=19916

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2009-09-25 12:26:03 ---
Closing bugs fixed in 1.1.30.

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

https://bugs.winehq.org/show_bug.cgi?id=19916

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |70241904b9efacab9fb6c7d8701
                   |                            |b1cfdb86f49f7

[Bug 19916] Steam client color scheme appears as green/red instead of gray/brown

https://bugs.winehq.org/show_bug.cgi?id=19916

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |winex11.drv