http://bugs.winehq.org/show_bug.cgi?id=21785
Summary: The Westerner: no background in menu + errors when loading Product: Wine Version: 1.1.38 Platform: x86 OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: minor Priority: P2 Component: gdiplus AssignedTo: wine-bugs@winehq.org ReportedBy: hoehle@users.sourceforge.net
commit db3d756c1e4b03b0fb33f2863ab3d2275dcf00c2 Author: Vincent Povirk vincent@codeweavers.com Date: Sun Jan 24 15:18:46 2010 -0600 gdiplus: Prefer the builtin version. causes 2 bugs in The Westerner. 1. The graphics background and mouse are missing from the main menu, after displaying this log a hundred times: fixme:gdiplus:GdipImageRotateFlip (0x0 6) stub err:d3d_surface:surface_prepare_system_memory Surface without memory or pbo has SFLAG_INSYSMEM set!
2. Afterwards, starting or loading a game (via the cursor keys), the app displays many, many requesters, each time about a different file, like this: error: no es pontencia de 2 "RData\Textures\maderas\madera_fuelle.tif w:0 h:0 I didn't click through all of them to see what would be left to see.
What's surprising is that there is a GdiPlus.dll in the app's directory. The app's installer must have added it as I found no note of adding one myself in my installation notes. This setup worked fine until Vincent's commit changed the priorities. I was not using any override except for quartz, as my AppDB entry explains.
Unlike bug #21604 about gdiplus, the above fixme+err suggest that the missing functionality is clearly identified and could be added to the builtin gdiplus, so that it becomes useable with The Westerner.
http://bugs.winehq.org/show_bug.cgi?id=21785
Jörg Höhle hoehle@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #1 from Jörg Höhle hoehle@users.sourceforge.net 2010-02-20 15:04:56 --- Forgot to mention that while I bisected on MacOS X 10.5.8 with NVidia graphics, the error is the same on Ubuntu Intrepid with Intel graphics.
http://bugs.winehq.org/show_bug.cgi?id=21785
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #2 from Vincent Povirk madewokherd@gmail.com 2010-02-20 17:55:23 --- GdipImageRotateFlip is nontrivial, unfortunately, since builtin gdiplus can't yet rotate images properly.
The second issue is probably due to the lack of tiff loading support.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #3 from Jörg Höhle hoehle@users.sourceforge.net 2010-05-19 14:57:30 --- Built-in gdiplus in wine-1.1.44 crashes in The Westerner: TIFFReadDirectory: Warning, <IStream object>: unknown field with tag 37724 (0x935c) encountered. fixme:wincodecs:tiff_get_decode_info unhandled RGB sample count 4 wine: Unhandled page fault on read access to 0x00000004 (thread 0019), starting debugger... =>0 0x6879e549 GdipImageRotateFlip+0x29(image=(nil), type=Rotate180FlipX) [dlls/gdiplus/image.c:3497] in gdiplus (0x0034e6a8)
Due to recent patches to gdiplus about Rotate etc. I had hoped this app would work now. Would you like me to send some sample file?
I've compiled this version of Wine using libtiff in Ubuntu Lucid.
http://bugs.winehq.org/show_bug.cgi?id=21785
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|gdiplus |windowscodecs
--- Comment #4 from Vincent Povirk madewokherd@gmail.com 2010-05-19 15:04:22 --- No, the FIXME is clear enough. We just need RGBA support for tiff files.
http://bugs.winehq.org/show_bug.cgi?id=21785
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani@redhat.com
--- Comment #5 from Michael Stefaniuc mstefani@redhat.com 2010-11-24 15:39:34 CST --- Vincent, doesn't commit b9beb9227da3a7df882d83d484572b7851e8c5e4 Author: Vincent Povirk vincent@codeweavers.com Date: Sat May 29 12:32:32 2010 -0500
windowscodecs: Support TIFF images with alpha data.
add the missing RGBA support for this bug?
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #6 from Vincent Povirk madewokherd@gmail.com 2010-11-24 16:17:40 CST --- Yes, this should work now, but I do not have the program to test.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #7 from Jörg Höhle hoehle@users.sourceforge.net 2010-12-31 00:43:06 CST --- Alas, the app needs more TIFF support before built-in gdiplus can be used.
TIFFReadDirectory: Warning, <IStream object>: unknown field with tag 37724 (0x935c) encountered. [twice] fixme:wincodecs:tiff_get_decode_info unhandled extra sample type 0
wine: Unhandled page fault on read access to 0x00000004 at address 0x7e77a959 (thread 001c), starting debugger... =>0 0x7e77a959 GdipImageRotateFlip+0x29(image=(nil), type=Rotate180FlipX) [dlls/gdiplus/image.c:3720] in gdiplus (0x0034e6a0) 3720 if (image->type != ImageTypeBitmap) For some reason, image is NULL.
Tested with Ubuntu Intrepid this time, with 1.3.9.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #8 from Jörg Höhle hoehle@users.sourceforge.net 2011-01-23 11:02:57 CST --- wine-1.3.13 went a little further, but still not enough
TIFFReadDirectory: Warning, <IStream object>: unknown field with tag 37724 (0x935c) encountered. [8x] fixme:wincodecs:TiffFrameDecode_GetResolution (0x1dcc70,0x32e0e4,0x32e0dc)[3x] fixme:wincodecs:tiff_get_decode_info missing RowsPerStrip value
Then crashes with GdipImageRotateFlip(image=(nil)
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #9 from Vincent Povirk madewokherd@gmail.com 2011-03-29 14:10:52 CDT --- 10080298dc7fb1ca3dee7903101dfd1de8fcfa5e should make tiled TIFF images work. Please retest.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #10 from Jörg Höhle hoehle@users.sourceforge.net 2011-04-09 10:34:46 CDT --- Still crashes in wine-1.3.17 with the same output as in comment #8.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #11 from Vincent Povirk madewokherd@gmail.com 2011-04-15 03:16:15 CDT --- I'd like to see if I can get a copy of this file. Are there any TIFF files in the application's install directory?
http://bugs.winehq.org/show_bug.cgi?id=21785
Jörg Höhle hoehle@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.4players.de/4pla | |yers.php/spielinfonews/PC-C | |DROM/3661/31331/The_Western | |er.html
--- Comment #12 from Jörg Höhle hoehle@users.sourceforge.net 2011-04-15 03:49:07 CDT --- IIRC there's no .tiff in the dirs (they get extracted at run-time?).
I had made a note to myself to check whether the demo presents the same symptoms which undoubtly would make it easier for you to nail this down, but haven't found the time to install & test that yet. Nevertheless I added the download link (220MB) to a demo version that I know worked in the past (whereas the version from chip.de was broken). See bug #18773 or AppDB about how to start the app.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #13 from Vincent Povirk madewokherd@gmail.com 2011-04-21 01:22:37 CDT --- Patch sent: http://www.winehq.org/pipermail/wine-patches/attachments/20110421/42f20a68/a...
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #14 from Jörg Höhle hoehle@users.sourceforge.net 2011-04-21 15:46:18 CDT ---
IIRC there's no .tiff
I was wrong. RData/Textures/ is full of them.
Your patch helped. Alas, gdiplus now crashes on Bmp/Piedra.tif after warn:wincodecs:tiff_get_decode_info Cannot get extra sample type for RGB data, ret=0 count=18 trace:wincodecs:TiffDecoder_Release (0x125120) refcount=0
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #15 from Vincent Povirk madewokherd@gmail.com 2011-04-25 17:30:33 CDT --- Any improvement with 9483b3ba86c41175b52dd87e9c15478c99ffda97 ?
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #16 from Jörg Höhle hoehle@users.sourceforge.net 2011-04-26 15:46:28 CDT --- With 1.3.18 + your 2 patches, there's no more crash. A few issues remain, though, with built-in gdiplus.
A) there's an opaque black square behind the mouse cross. This happens both in the menus and in-game, making it tough to select anything. The menu's cursor looks like RData/Bmp/Cursores/Puntero.tif, while Lupa.tif and others are used in-game.
B) Half the menu's screen is painted white instead of black. This may be a transparency issue. At the bottom and top, a celluloid movie strip is shown (RData/Bmp/NewMenugfx/PeliculaMenu.tif). With built-in gdiplus, it's fully visible whereas with native, there's a gradient such that the bottommost and topmost screen content is black.
C) When you press ESC in-game, a tainted screenshot of the scene in brown/sepia colors serves as background to the menu. With built-in gdiplus, the background is plain black & white as in B).
Perhaps the 3 can be explained by missing transparency and/or opacity? RData/Bmp/NewMenugfx/MenuCentral.tif seems to have both.
BTW, I see ~40 repetitions of TIFFReadDirectory: Warning, <IStream object>: unknown field with tag 37724 (0x935c) encountered.
http://bugs.winehq.org/show_bug.cgi?id=21785
--- Comment #17 from Vincent Povirk madewokherd@gmail.com 2011-06-14 14:33:18 CDT --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2011-June/103093.html
http://bugs.winehq.org/show_bug.cgi?id=21785
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.5 |Mac OS X
http://bugs.winehq.org/show_bug.cgi?id=21785
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Regression SHA1| |db3d756c1e4b03b0fb33f2863ab | |3d2275dcf00c2
--- Comment #18 from André H. nerv@dawncrow.de 2011-08-09 13:32:26 CDT --- still present in git?
http://bugs.winehq.org/show_bug.cgi?id=21785
Jörg Höhle hoehle@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #19 from Jörg Höhle hoehle@users.sourceforge.net 2011-08-21 16:24:44 CDT --- As of wine-1.3.26, there's no more visible difference in the menus between built-in gdiplus and the one installed by the app. Vincent, thank you!
http://bugs.winehq.org/show_bug.cgi?id=21785
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org 2011-08-26 13:24:30 CDT --- Closing bugs fixed in 1.3.27.
https://bugs.winehq.org/show_bug.cgi?id=21785
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |785f84a63c52530760185aa82cf | |b6d0090a316d0 Keywords| |download URL|http://www.4players.de/4pla |https://web.archive.org/web |yers.php/spielinfonews/PC-C |/20210226091558/http://dl.4 |DROM/3661/31331/The_Western |players.de/f1/pc/westerner/ |er.html |demo_westerner_de.zip CC| |focht@gmx.net