http://bugs.winehq.org/show_bug.cgi?id=19469
Summary: ResEdit crashes checking for updates Product: Wine Version: 1.1.26 Platform: PC URL: http://www.resedit.net/ResEdit-UNICODE.7z OS/Version: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: urlmon AssignedTo: wine-bugs@winehq.org ReportedBy: bunglehead@gmail.com
Created an attachment (id=22630) --> (http://bugs.winehq.org/attachment.cgi?id=22630) Crash log
ResEdit 1.4.7 (unicode build) crashes checking for updates. Attached log produced with 'Help -> Check for update' menu command.
http://bugs.winehq.org/show_bug.cgi?id=19469
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #1 from André H. nerv@dawncrow.de 2009-08-03 06:43:41 --- With wine_gecko 1.0.0 RC the same ResEdit version doesnt crash for me. just a: fixme:wininet:InternetLockRequestFile STUB
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2009-08-05 08:13:59 --- (In reply to comment #1)
With wine_gecko 1.0.0 RC the same ResEdit version doesnt crash for me. just a: fixme:wininet:InternetLockRequestFile STUB
Strange, crashes exactly the same way for me in urlmon on wine-1.1.26-351-gd97cc15.
I installed wine-gecko 1.0.0 cab, creating fresh .wine crashes wineboot after that. But 'wine iexplore' works fine.
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2009-10-06 18:37:58 --- Same crash on wine-1.1.30-416-g07ec73f.
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com 2009-10-17 08:08:04 --- Still crashes on wine-1.1.31-272-g8c743cb.
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2009-12-07 17:14:06 --- Same crash with similar backtrace on wine-1.1.34-99-g8da7a00.
http://bugs.winehq.org/show_bug.cgi?id=19469
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #22630|0 |1 is obsolete| |
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2010-10-16 16:39:20 CDT --- Created an attachment (id=31311) --> (http://bugs.winehq.org/attachment.cgi?id=31311) +tid,+urlmon running 1.3.5
There's an updated log, reproducible every time for me. It shows an attempt to display message box with not Internet connection message (which is not missing obviously).
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2011-05-09 15:02:12 CDT --- Same thing running wine-1.3.19-235-g71fe9c9.
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2012-01-27 02:03:47 CST --- Same crash running wine-1.3.37-447-ge79644e.
It crashes calling BindStatusCallback_OnProgress with BINDSTATUS_CONNECTING status code, so it probably means it's called in a wrong time.
http://bugs.winehq.org/show_bug.cgi?id=19469
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.resedit.net/ResE |http://www.resedit.net/ResE |dit-UNICODE.7z |dit-win32.7z
http://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com 2013-03-15 07:09:56 CDT --- With wine-1.5.25-234-g78b579d it throws a message box asking to check internet connection, on windows it says I have the latest version.
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #10 from Bruno Jesus 00cpxxx@gmail.com --- Created attachment 50504 --> https://bugs.winehq.org/attachment.cgi?id=50504 backtrace with debug symbols
The oldest archive link is for version 1.5.4. I'm getting a crash when I click the check for updates button.
https://bugs.winehq.org/show_bug.cgi?id=19469
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #11 from super_man@post.com --- (In reply to Bruno Jesus from comment #10)
Created attachment 50504 [details] backtrace with debug symbols
The oldest archive link is for version 1.5.4. I'm getting a crash when I click the check for updates button.
If you disable
dlls/user32/msgbox.c
line 399
like this
// return MessageBoxExW(hwnd, text, title, type, LANG_NEUTRAL);
You dont get a crash (it doesnt work either).
Something wrong here?
still valid as wine 1.9
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #12 from super_man@post.com --- http://source.winehq.org/git/wine.git/blob/d9f8cba50f4c2fc9f138d35c73ba5afc3...
1215 FIXME("not supported string type %d\n", ulStringType); 1216 return E_NOTIMPL;
Could be related to the crash. Google gives lots of issues with string type 20 and not be able to download something.
wine 1.9.6
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #13 from super_man@post.com --- Still crashes 1.9.12 and staging 1.9.11
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #14 from Gijs Vermeulen gijsvrm@gmail.com --- Created attachment 68045 --> https://bugs.winehq.org/attachment.cgi?id=68045 output
Still present in wine-5.15.
'winetricks -q urlmon' makes it work.
https://bugs.winehq.org/show_bug.cgi?id=19469
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.resedit.net/ResE |https://web.archive.org/web |dit-win32.7z |/20140228191618/http://www. | |resedit.net/ResEdit-win32.7 | |z
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #15 from Gijs Vermeulen gijsvrm@gmail.com --- Still present with wine-7.15.
To me, it seems like it needs support for BINDSTRING_ROOTDOC_URL in at least InternetBindInfo_GetBindString and HttpProtocol_open_request.
https://bugs.winehq.org/show_bug.cgi?id=19469
temp82@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |temp82@luukku.com
--- Comment #16 from temp82@luukku.com --- still crashes wine 9.8.
https://bugs.winehq.org/show_bug.cgi?id=19469
--- Comment #17 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 76438 --> https://bugs.winehq.org/attachment.cgi?id=76438 patch
ResEdit calls URLOpenStream() to check for updates. URLOpenStream() calls a helper that starts an asynchronous operation and returns (0x401e8) S_ASYNCHRONOUS. Unfortunately URLOpenStream() implementation uses stack to store an asynchronous callback which probably gets overwritten at some point and callback->lpVtbl becomes NULL, which leads to a crash when a callback is invoked.
Attached patch replaces stack by a dynamic memory allocation, and now ResEdit is able to detect that an update is available, and calls MessageBox() to inform the user. Regardless of the answer (Yes/No) right after the MessageBox() returns ResEdit crashes with an illegal instruction exception. It looks like some sort of stack smashing on API return.
Probably this could be called a progress, I'm done for now. Everyone is welcome to continue an investigation.