[Bug 9934] New: Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Summary: Space bar does not tick checkboxes in Listview
           Product: Wine
           Version: unspecified
          Platform: Other
               URL: http://www.stationplaylist.com/LV_Checkboxes.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: wine-comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

As you can see in the test app provided, the space bar does not check/uncheck
checkboxes in a listview.

This is necessary for blind users of our software and is therefore fairly
serious.

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.0.0

--- Comment #1 from Dan Kegel   2007-10-07 07:20:09 ---
IMHO accessibility is very important, and lots of apps use
commctl, so let's fix this for 1.0.

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Ross Levis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.stationplaylist.c%7Chttp://www.stationplaylist.c
                   |om/LV_Checkboxes.exe        |om/LV_Checkboxes.zip
            Version|unspecified                 |0.9.47.

--- Comment #2 from Ross Levis   2007-10-12 20:35:05 ---
Download URL now includes Delphi source code.
(Also used to demonstrate bug 9932 and 9933).

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Ross Levis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Marco Rodrigues  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Marco Rodrigues   2008-03-13 19:24:50 ---
*** This bug has been confirmed by popular vote. ***

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #4 from Lei Zhang   2008-03-13 22:42:57 ---
Created an attachment (id=11368)
 --> (http://bugs.winehq.org/attachment.cgi?id=11368)
listview patch

Something like this should do the trick.

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Lionel Debroux  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Lionel Debroux   2008-03-16 09:43:01 ---
The attached patch applied on top of latest git version works for me on the
testcase.

Of the two "sister" bugs (9932 and 9933) which the same testcase shows, 9933
looks easier to fix than 9932, isn't it ?

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11368|0                           |1
        is obsolete|                            |

--- Comment #6 from Lei Zhang   2008-03-19 17:11:41 ---
(From update of attachment 11368)
Patches sent:

http://www.winehq.org/pipermail/wine-patches/2008-March/051803.html
http://www.winehq.org/pipermail/wine-patches/2008-March/051804.html

Ignore the attached patch. It's not correct.

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Lei Zhang   2008-03-20 10:27:58 ---
Patch committed. Thank you for providing the demo program.

[Bug 9934] Space bar does not tick checkboxes in Listview

http://bugs.winehq.org/show_bug.cgi?id=9934

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2008-03-21 10:54:23 ---
Closing bugs fixed in 0.9.58.