[Bug 22264] New: Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Summary: Total Commander: Button not drawn properly when the
                    window is activated and the button was hidden
           Product: Wine
           Version: 1.1.41
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P4
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Start Total Commander, Ctrl F, left-click on the "New URL..." button, notice a
"ftp" window opens, move it so it partially covers the "New URL..." button you
just pressed (see attached screenshot), press ESC, notice the button is not
drawn correctly (see attached screenshot).

Total Commander 7.50a

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #1 from Alex Balut   2010-04-04 01:30:48 ---
Created an attachment (id=27192)
 --> (http://bugs.winehq.org/attachment.cgi?id=27192)
Screenshot with the "ftp" window partially covering the "New URL..." button
which has just been clicked

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #2 from Alex Balut   2010-04-04 01:31:59 ---
Created an attachment (id=27193)
 --> (http://bugs.winehq.org/attachment.cgi?id=27193)
Screenshot after pressing ESC, notice button is not properly drawn

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Wylda   2010-04-10 12:59:07 ---

Good catch, Alex. And subject of the commit is self explanatory.

1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION,
+DOWNLOAD, +INSTALLER

2. I did a regression test between 1.1.26 and 1.1.27:

commit 8d54f582776d590b236e288f9ef8085bb221ccab
Author: Dmitry Timoshkov 
Date:   Thu Jul 23 19:44:13 2009 +0900

user32: Draw the whole button only if requested.

:040000 040000 43df269d25d7cf4d036188e73432b07968234d79
05adaf2e05dfc60885085219e9decbf10337c15c M      dlls

3. No other bug report suffers from this commit.

4. Revert of this patch on top of wine-1.1.31 makes that problem go away.
Reverting on .32 and higher is not possible.

5. Adding author of this patch to CC.

--private keyword: bisected

Download:

http://www.ghisler.com/amazons3.php

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #4 from Wylda   2010-04-10 13:00:26 ---

Opss... Of course it's not +INSTALLER. Sorry.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Austin English   2010-04-10 14:44:41 ---
Confirming.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #6 from Dmitry Timoshkov   2010-04-13 01:50:18 ---
The following patch fixes the problem:
http://www.winehq.org/pipermail/wine-patches/2010-April/087154.html

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Dmitry Timoshkov   2010-04-13 23:12:36 ---
The patch has been committed:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=fedc194e68e18367a6d7d0...

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #8 from Wylda   2010-04-15 04:49:56 ---
Created an attachment (id=27368)
 --> (http://bugs.winehq.org/attachment.cgi?id=27368)
Missing dotted lines

(In reply to comment #6)
> The following patch fixes the problem:
> http://www.winehq.org/pipermail/wine-patches/2010-April/087154.html

Hi Dmitry, i think this patch is not correct - button is missing dotted lines
(which are also shifted +1pixel?? to the borders) and is also different from
WinXP.

Attached picture shows that better. Reopen please.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #9 from Dmitry Timoshkov   2010-04-15 06:19:58 ---
I'll have a look.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Jaime Rave   2010-04-15 13:10:44 ---
This looks related to bug 19082

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #11 from Wylda   2010-04-15 13:18:09 ---
(In reply to comment #10)
> This looks related to bug 19082

No, i think that is a different story. And also this one is already bisected
(and BTW this works without any problem till 1.1.26, but followed patches and
fixes and so on...;).

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #12 from Dmitry Timoshkov   2010-04-16 05:00:27 ---
I sent a patch with an explanation:
http://www.winehq.org/pipermail/wine-patches/2010-April/087313.html

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Dmitry Timoshkov   2010-04-16 23:24:07 ---
The patch has been committed:
http://source.winehq.org/git/wine.git/?a=commit;h=c049f833082bf57f8364d433a3...

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #14 from Wylda   2010-04-17 02:26:07 ---
(In reply to comment #12)
> I sent a patch with an explanation:
> http://www.winehq.org/pipermail/wine-patches/2010-April/087313.html

I do not want to be nitpicker, but i think the fix is still not correct ;)

If the button is pressed, then it should have the dotted line. But this works
only first time, so in this case:

1. Press (and hold for a while) "New URL" button (correctly dotted)

2. On release there is a new window

3. Click "Cancel" button and "New URL" get's dotted again <- Correct

4. Press (and hold for a while) "New URL" dotted lines are missing <- incorrect

Reopen?

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #15 from Wylda   2010-04-17 03:05:17 ---
(In reply to comment #14)

Maybe it should continue:

5. On release button is dotted for fraction of second <-- incorect

6. Than is repainted so dots are gone and new window is opened

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #16 from Dmitry Timoshkov   2010-04-17 04:45:07 ---
(In reply to comment #15)
> (In reply to comment #14)
>
> Maybe it should continue:
> -
>
> On release button is dotted for fraction of second <-- incorect
> -
>
> Than is repainted so dots are gone and new window is opened

That's a different problem, I sent a patch
http://www.winehq.org/pipermail/wine-patches/2010-April/087155.html
but Alexandre thinks it should be fixed in another way.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #17 from Wylda   2010-04-17 17:29:13 ---
(In reply to comment #16)
> That's a different problem, I sent a patch
> http://www.winehq.org/pipermail/wine-patches/2010-April/087155.html
> but Alexandre thinks it should be fixed in another way.

I finally find this patch OK. Well, i grade it by behavior not by code
cleanness.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard   2010-05-07 13:30:15 ---
Closing bugs fixed in 1.1.44.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #19 from Dmitry Timoshkov   2010-05-18 22:09:36 ---
(In reply to comment #16)
> > Maybe it should continue:
> > -
> >
> > On release button is dotted for fraction of second <-- incorect
> > -
> >
> > Than is repainted so dots are gone and new window is opened
>
> That's a different problem, I sent a patch
> http://www.winehq.org/pipermail/wine-patches/2010-April/087155.html
> but Alexandre thinks it should be fixed in another way.

This one should be fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=cc870dc484c5b9f61db35a...

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #20 from Wylda   2010-06-01 09:26:47 ---
(In reply to comment #19)
> > That's a different problem, I sent a patch
>
> This one should be fixed by
> http://source.winehq.org/git/wine.git/?a=commitdiff;h=cc870dc484c5b9f61db35a...

Hi Dmitry, you will hate me, but i think this patch is not correct ;) Based on
test on WinXP & Vista, press Ctrl+F, then:

a] Press (and hold for a while) "New URL" button (correctly dotted)

b] On release there is a new window

c] Press (and hold for a while) "Cancel" button and its get dotted <- **WRONG**

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #21 from Dmitry Timoshkov   2010-06-02 02:44:20 ---
(In reply to comment #20)
> c] Press (and hold for a while) "Cancel" button and its get dotted <- **WRONG**

What's wrong with it?

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #22 from Alex Balut   2010-06-02 02:51:37 ---
(In reply to comment #21)
> (In reply to comment #20)
> > c] Press (and hold for a while) "Cancel" button and its get dotted <- **WRONG**
>
> What's wrong with it?

In Vista, for example, the Cancel button does not get dotted when you click and
hold.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #23 from Wylda   2010-06-02 02:56:01 ---
(In reply to comment #21)
> (In reply to comment #20)
> > c] Press (and hold for a while) "Cancel" button and its get dotted <- **WRONG**
>
> What's wrong with it?

Like Alex replied, there are some kind of windows (child windows??) which
should receive dots inside the button.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #24 from Dmitry Timoshkov   2010-06-02 02:56:30 ---
(In reply to comment #22)
> In Vista, for example, the Cancel button does not get dotted when you click and
> hold.

Because Vista uses themed buttons, which use different hilighting.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #25 from Wylda   2010-06-02 03:37:23 ---
(In reply to comment #23)
> > What's wrong with it?
>
> Like Alex replied, there are some kind of windows (child windows??) which
> should receive dots inside the button.

Of course i wanted to say "_shouldn't_ receive dots inside the button.". I just
notice that in outlook under WinXP (accounts managemnt window).

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #26 from Wylda   2010-06-02 03:41:07 ---
Created an attachment (id=28512)
 --> (http://bugs.winehq.org/attachment.cgi?id=28512)
WinXP behaviour

No theme under winxp (or rather say clasic). Cancel button is pressed and
doesn't show dots.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #27 from Dmitry Timoshkov   2010-06-02 03:44:50 ---
(In reply to comment #26)
> Created an attachment (id=28512)

--> (http://bugs.winehq.org/attachment.cgi?id=28512) [details]
> WinXP behaviour
>
> No theme under winxp (or rather say clasic). Cancel button is pressed and
> doesn't show dots.

You should compare with win9x behaviour, win2000 and up has theming, and
a setting for focus painting (without dots).

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #28 from Wylda   2010-06-02 04:09:59 ---
Created an attachment (id=28513)
 --> (http://bugs.winehq.org/attachment.cgi?id=28513)
Win98 behaviour
> You should compare with win9x behaviour, win2000 and up has theming, and
> a setting for focus painting (without dots).

Ahh... that's it. Thank you for explanation. Then the behaviour is correct :)

Sorry for the noise.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28513|text/plain                  |image/png
          mime type|                            |

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

--- Comment #29 from Nikolay Sivov   2010-06-02 06:23:49 ---
(In reply to comment #27)
> (In reply to comment #26)
> > Created an attachment (id=28512)

--> (http://bugs.winehq.org/attachment.cgi?id=28512) [details] [details]
> > WinXP behaviour
> >
> > No theme under winxp (or rather say clasic). Cancel button is pressed and
> > doesn't show dots.
>
> You should compare with win9x behaviour, win2000 and up has theming, and
> a setting for focus painting (without dots).

Exactly. All recent versions from XP (and 2000 to probably, I don't remember)
have a special handling for a focus rectangle and accelerator marks. You could
still activate a focus rectangle painting running XP (or Vista without
composition) pressing Alt before click. There's a special message to activate
focus and accelerators - WM_UPDATEUISTATE. Wine could possible implement this
thing too, but we need a properly working theme support and updated user32
controls implemented in comctl32 first, after that such minor things could make
sense.

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

http://bugs.winehq.org/show_bug.cgi?id=22264

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |cc870dc484c5b9f61db35ac15af
                   |                            |ae0873c2afc26
            Version|1.1.41                      |1.1.27
    Regression SHA1|                            |8d54f582776d590b236e288f9ef
                   |                            |8085bb221ccab

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

https://bugs.winehq.org/show_bug.cgi?id=22264

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |user32

[Bug 22264] Total Commander: Button not drawn properly when the window is activated and the button was hidden

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=22264

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20210210215033/http://tota
                   |                            |lcommander.ch/win/old/tcmd7
                   |                            |50a.exe