http://bugs.winehq.org/show_bug.cgi?id=19588
Summary: Symantec LiveUpdate 3.4 - wrong permissions set on folder Product: Wine Version: 1.1.26 Platform: PC URL: ftp://ftp.symantec.com/public/english_us_canada/liveup date/3.4/lusetup.exe OS/Version: Linux Status: NEW Keywords: download, Installer Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: kennybobs@o2.co.uk
Created an attachment (id=22841) --> (http://bugs.winehq.org/attachment.cgi?id=22841) wine-1.1.26-391-g914a9ca installation console output
The installer for Symantec LiveUpdate 3.4 does complete despite this error, because it is a fairly simple application.
Basically, incorrect permissions are set on a program folder.
$ ls -l /home/test/.wine2/drive_c/users/Public/Application\ Data total 232 -rw-r--r-- 1 test test 228661 2009-08-05 23:11 LuInstall.LiveUpdate dr-xrwsr-x 3 test test 4096 2009-08-05 23:11 Symantec
Attempting to remove this folder (without root access) results in PERMISSION DENIED.
http://en.wikipedia.org/wiki/Setgid#setgid_on_directories
Wine shouldn't be setting setgid, Windows does not support it.
http://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |pbronline-wine@yahoo.co.uk Component|-unknown |wineserver Version|1.1.26 |1.1.8 Target Milestone|--- |1.2.0 Summary|Symantec LiveUpdate 3.4 - |Wine is setting setgid in |wrong permissions set on |some instances |folder |
--- Comment #1 from Ken Sharp kennybobs@o2.co.uk 2009-08-15 13:06:38 --- Similar story for Family Feud. http://downloads.popcap.com/www/popcap_downloads/FamilyFeudSetup.exe
drwx-wSrwx 10 test test 4096 2009-08-15 18:17 Family Feud
Turns out this is a regression.
6435a5ddabda596d1c60d94a8f99ce19be95ac6d is first bad commit commit 6435a5ddabda596d1c60d94a8f99ce19be95ac6d Author: Paul Bryan Roberts pbronline-wine@yahoo.co.uk Date: Mon Nov 3 22:37:17 2008 +0000
server: Clone file_get_sd() and file_set_fd() for directories.
:040000 040000 e5bb86cf0ca04d954d32572549263678a2967ffe c0bf4c2549114331254abfafaf908269e9af6e49 M dlls :040000 040000 23349a07c684fdd05478fdfa449fb840edaa267b e4ba31cd1e60853ad020f15bef20883951424793 M server
http://source.winehq.org/git/wine.git/?a=commit;h=6435a5ddabda596d1c60d94a8f...
http://bugs.winehq.org/show_bug.cgi?id=19588
--- Comment #2 from Mike Kaplinskiy mike.kaplinskiy@gmail.com 2009-08-16 22:20:58 --- Created an attachment (id=23130) --> (http://bugs.winehq.org/attachment.cgi?id=23130) Initialize mode
Does the attached help?
http://bugs.winehq.org/show_bug.cgi?id=19588
Mike Kaplinskiy mike.kaplinskiy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #23130|0 |1 is obsolete| |
--- Comment #3 from Mike Kaplinskiy mike.kaplinskiy@gmail.com 2009-08-17 11:42:39 --- (From update of attachment 23130) Never mind, Alexandre fixed it in git.
http://bugs.winehq.org/show_bug.cgi?id=19588
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #4 from Alexandre Julliard julliard@winehq.org 2009-08-17 14:00:55 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | Summary|Wine is setting setgid in |Wine is setting incorrect |some instances |permissions in some | |instances
--- Comment #5 from Ken Sharp kennybobs@o2.co.uk 2009-08-17 19:05:43 --- OK, I apologise for not seeing this first time round. Permissions are still slightly wrong.
dr-xr-xr-x 3 test test 4096 2009-08-17 23:24 Symantec
should be
drwxr-xr-x 3 test test 4096 2009-08-18 01:01 Symantec
Setgid is certainly fixed, but the permissions are still off. It's the same regression so the same bug.
Result being the same, nobody has write access so only root can do anything with it.
http://bugs.winehq.org/show_bug.cgi?id=19588
--- Comment #6 from Ben Peddell klightspeed@netspace.net.au 2009-11-17 02:53:19 --- Created an attachment (id=24798) --> (http://bugs.winehq.org/attachment.cgi?id=24798) Take into account owner groups in server/file.c::sd_to_mode()
Does this patch solve this issue? It should apply to any wine source since 0.9.49 (November 2007).
Is it possible to trace the permission changing with `WINEDEBUG=+advapi32`?
http://bugs.winehq.org/show_bug.cgi?id=19588
--- Comment #7 from Ken Sharp kennybobs@o2.co.uk 2009-12-08 10:03:34 --- The attached patch does fix the problem. An +advapi32 trace doesn't print any additional output.
http://bugs.winehq.org/show_bug.cgi?id=19588
--- Comment #8 from Ben Peddell klightspeed@netspace.net.au 2009-12-11 23:39:59 --- (From update of attachment 24798) Obsoleted by commit b419df1de48609086c7460fdb5d8a20d119e47ee
(In reply to comment #7)
The attached patch does fix the problem. An +advapi32 trace doesn't print any additional output.
Sorry, I should have asked you to use +advapi.
http://bugs.winehq.org/show_bug.cgi?id=19588
Ben Peddell klightspeed@netspace.net.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #24798|0 |1 is obsolete| |
http://bugs.winehq.org/show_bug.cgi?id=19588
Ben Peddell klightspeed@netspace.net.au changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |klightspeed@netspace.net.au
--- Comment #9 from Ben Peddell klightspeed@netspace.net.au 2009-12-19 11:16:13 --- (In reply to comment #7)
The attached patch does fix the problem. An +advapi32 trace doesn't print any additional output.
Is the bug fixed in 1.1.35?
http://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED
--- Comment #10 from Ken Sharp kennybobs@o2.co.uk 2010-02-04 11:42:40 --- Yes, this is fixed in latest git.
http://bugs.winehq.org/show_bug.cgi?id=19588
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2010-02-05 11:39:01 --- Closing bugs fixed in 1.1.38.
http://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |6435a5ddabda596d1c60d94a8f9 | |9ce19be95ac6d
https://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |714abcb7cdd8cab7d9383bded5b | |5426e55d98791 Distribution|--- |Ubuntu
https://bugs.winehq.org/show_bug.cgi?id=19588
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1|714abcb7cdd8cab7d9383bded5b |b419df1de48609086c7460fdb5d |5426e55d98791 |8a20d119e47ee