[Bug 49543] New: Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Bug ID: 49543
           Summary: Several games require bcrypt DH support
           Product: Wine
           Version: 5.12
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bcrypt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

There are a few games that need DH support in bcrypt.

- The Rockstar Games Launcher, GTA V, and RDR 2 all open DH and generate+export
a public key. With DH unimplemented, the only effect I know of is that RDR 2's
online mode fails to load.
- Astroneer dedicated server (see
https://www.reddit.com/r/wine_gaming/comments/gvaa9a/bcryptopenalgorithmprov...).
> From a disassembler, it looks like the server imports/exports public/private

keys, and uses BCryptDeriveKey() with the "HASH" KDF and SHA256.

Microsoft has sample code which tests (some of) the functionality:
https://github.com/microsoft/Windows-classic-samples/blob/master/Samples/Sec...

Unfortunately GnuTLS doesn't currently export the needed functionality. There's
an issue open: https://gitlab.com/gnutls/gnutls/-/issues/894

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Anya  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
*** Bug 51445 has been marked as a duplicate of this bug. ***

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
It *appears* that gnutls now supports DH, any update on incorporating this in
wine?

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Zeb Figura  ---
(In reply to muetakappaepsilon from comment #2)
> It *appears* that gnutls now supports DH, any update on incorporating this
> in wine?

Does it? The linked bug report is still open and hasn't been touched since July
2020.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Olivier F. R. Dierick  ---
Created attachment 72356
  --> https://bugs.winehq.org/attachment.cgi?id=72356
1/3 include: Add DH-related bcrypt constants

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #5 from Olivier F. R. Dierick  ---
Created attachment 72357
  --> https://bugs.winehq.org/attachment.cgi?id=72357
2/3 bcrypt: Implement DH algorithm using libgmp

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #6 from Olivier F. R. Dierick  ---
Created attachment 72358
  --> https://bugs.winehq.org/attachment.cgi?id=72358
3/3 bcrypt/tests: Test DH algorithm

Hello,

Here is a DH implementation from Proton (Glorious Eggroll) with tests based on
the reference from comment 0.

All the tests pass for me (except for BCryptDeriveKey which I had to mark
'todo_wine' because the function is only a stub.)

Regards.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Ker noa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
Hello,

Not sure I understand, but does that mean if I build wine from source with
these patches beforehand, bcrypt DH should be supported OK?

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #8 from Olivier F. R. Dierick  ---
(In reply to Wobak from comment #7)
> Hello,
>
> Not sure I understand, but does that mean if I build wine from source with
> these patches beforehand, bcrypt DH should be supported OK?

Hello,

It should, but the patches may need to be rebased for the newest Wine version.
That is: There are minor corrections to do because some other ciphers were
added since my last attachment, but it should be straightforward (I have
updated patches, if needed).

It also depends on libgmp (libgmp:amd64 and/or :i386 for execution; libgmp-dev
for compilation).

Regards.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #9 from Wobak  ---
Could you attach the updated patches to this bug?

As I'm not 100% familiar with compiling wine (and still fighting it tbh), if I
can avoid a struggle of rebasing the patches, I'd highly appreciate it :)

Thanks !

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72356|0                           |1
        is obsolete|                            |

--- Comment #10 from Olivier F. R. Dierick  ---
Created attachment 73060
  --> https://bugs.winehq.org/attachment.cgi?id=73060
1/3 include: Add DH-related bcrypt constants

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72357|0                           |1
        is obsolete|                            |

--- Comment #11 from Olivier F. R. Dierick  ---
Created attachment 73061
  --> https://bugs.winehq.org/attachment.cgi?id=73061
2/3 bcrypt: Implement DH algorithm using libgmp

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72358|0                           |1
        is obsolete|                            |

--- Comment #12 from Olivier F. R. Dierick  ---
Created attachment 73062
  --> https://bugs.winehq.org/attachment.cgi?id=73062
3/3 bcrypt/tests: Test DH algorithm

Hello,

Here is a rebased patchset for Wine 7.16 & 7.17.

Apply each from the root of the building directory,
with 'git am --3way file.patch' if compiling from git,
or 'patch -p1 < file.patch' if compiling from tar source.

Regards.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #13 from [e-mail] ---
Any update on getting this into the trunk of wine?

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #14 from Hans Leidekker  ---
(In reply to muetakappaepsilon from comment #13)
> Any update on getting this into the trunk of wine?

We would like to avoid adding another library dependency. Someone tried to add
ECDH support to GnuTLS a while ago (which could be generalized to handle both
DH and ECDH) but it seems the effort has stalled:

https://gitlab.com/gnutls/gnutls/-/merge_requests/1395

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from [e-mail]  ---
(In reply to Hans Leidekker from comment #14)
> (In reply to muetakappaepsilon from comment #13)
> > Any update on getting this into the trunk of wine?
>
> We would like to avoid adding another library dependency. Someone tried to
> add ECDH support to GnuTLS a while ago (which could be generalized to handle
> both DH and ECDH) but it seems the effort has stalled:
>
> https://gitlab.com/gnutls/gnutls/-/merge_requests/1395

It seems implemented in GnuTLS 3.8.2 recently?

https://gitlab.com/gnutls/gnutls/-/merge_requests/1773
https://gitlab.com/gnutls/gnutls/-/blob/3.8.2/NEWS?ref_type=tags#L13

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

soredake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|broaden_acid002@simplelogin |
                   |.com                        |

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #16 from Hans Leidekker  ---
(In reply to Davy from comment #15)
> (In reply to Hans Leidekker from comment #14)
> > (In reply to muetakappaepsilon from comment #13)
> > > Any update on getting this into the trunk of wine?
> >
> > We would like to avoid adding another library dependency. Someone tried to
> > add ECDH support to GnuTLS a while ago (which could be generalized to handle
> > both DH and ECDH) but it seems the effort has stalled:
> >
> > https://gitlab.com/gnutls/gnutls/-/merge_requests/1395
>
> It seems implemented in GnuTLS 3.8.2 recently?
>
> https://gitlab.com/gnutls/gnutls/-/merge_requests/1773
> https://gitlab.com/gnutls/gnutls/-/blob/3.8.2/NEWS?ref_type=tags#L13

Yes, it looks promising. We probably need some extra changes to handle
importing/exporting DH keys.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |be9f66c62bc6f168e3fb4168239
                   |                            |1b0b37c999047

--- Comment #17 from Hans Leidekker  ---
DH is supported starting from be9f66c62bc6f168e3fb41682391b0b37c999047. Note
that this needs GnuTLS 3.8.2.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  ---
Closing bugs fixed in 9.0-rc1.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]    |

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

Wiley A  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Wiley A  ---
For Astroneer this issue is still present in Proton 9.0-3 > Wine Mono to 9.2.0.
You're unable to connect to dedicated servers running encryption for crossplay
with Windows, Xbox and Playstation consoles.

Testing was done using a Steam Deck.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #20 from Hans Leidekker  ---
(In reply to Wiley A from comment #19)
> For Astroneer this issue is still present in Proton 9.0-3 > Wine Mono to
> 9.2.0.
> You're unable to connect to dedicated servers running encryption for
> crossplay with Windows, Xbox and Playstation consoles.
>
> Testing was done using a Steam Deck.

The version of GnuTLS on Steam Deck is too old.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #21 from [e-mail] ---
Some context from me:

- This issue is happening with the dedicated server and the game client
- With the current wine-staging version 9.22 and GnuTLS 3.8.3 on Ubuntu 24.04,
the application starts, but once a player tries to join, the error
`0170:fixme:bcrypt:BCryptExportKey encryption of key not yet supported` appears
in the output log
- This was tested with the server running using WINE and the client on a native
platform (Windows)

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #22 from Hans Leidekker  ---
(In reply to joejoetv from comment #21)
> `0170:fixme:bcrypt:BCryptExportKey encryption of key not yet supported`

That's a separate bug, can you open a bug report for it? This bug is closed.

[Bug 49543] Several games require bcrypt DH support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49543

--- Comment #23 from [e-mail] ---
(In reply to Hans Leidekker from comment #22)
> (In reply to joejoetv from comment #21)
> > `0170:fixme:bcrypt:BCryptExportKey encryption of key not yet supported`
>
> That's a separate bug, can you open a bug report for it? This bug is closed.

Ok, I have filed this here as a separate bug report:
https://bugs.winehq.org/show_bug.cgi?id=57492

If it needs more information, please tell me.