http://bugs.winehq.org/show_bug.cgi?id=28881
Bug #: 28881 Summary: CommandLineToArgvW last argument is not equal to NULL Product: Wine Version: 1.3.31 Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: martijn.jstn@gmail.com Classification: Unclassified
Created attachment 37108 --> http://bugs.winehq.org/attachment.cgi?id=37108 Test application
The last argument given by CommandLineToArgvW should be equal to NULL which it is not. This causes application which use a pointer to increment and check for NULL to crash.
Should be an easy fix, allocate argv to hold one more pointer and set it to NULL.
http://bugs.winehq.org/show_bug.cgi?id=28881
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other Severity|normal |minor
http://bugs.winehq.org/show_bug.cgi?id=28881
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com 2011-10-24 20:48:23 CDT --- A 2008 comment in msdn says that is not true.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb776391%28v=vs.85%2...
The application maybe reading an out of bounds value.
http://bugs.winehq.org/show_bug.cgi?id=28881
--- Comment #2 from Martijn martijn.jstn@gmail.com 2011-10-25 04:59:54 CDT --- Odd, when testing it under Windows it will work. Then I must have been very lucky for it to be zeroed out all this time, or the comment is false? Anyway, I think I'll just stick to using argc just to be safe. Apologies for the inconvenience.
http://bugs.winehq.org/show_bug.cgi?id=28881
--- Comment #3 from Bruno Jesus 00cpxxx@gmail.com 2011-10-25 06:05:02 CDT --- No, no. I don't mean the comment is true. I was just looking for bibliography about the subject =)
http://bugs.winehq.org/show_bug.cgi?id=28881
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com 2011-10-25 18:27:06 CDT --- After using wine testbot to check this issue I started to agree with Martijn that after Win2003 the function adds a NULL after the last parameter as seen on : https://testbot.winehq.org/JobDetails.pl?Key=15111
Win XP, NT and 2003 do not seem to add the extra NULL.
I guess this bug is valid then.
http://bugs.winehq.org/show_bug.cgi?id=28881
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase
http://bugs.winehq.org/show_bug.cgi?id=28881
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE
--- Comment #5 from Bruno Jesus 00cpxxx@gmail.com 2012-04-07 10:24:36 CDT --- I'm closing this as duplicate after agreeing with Anastasius Focht that bug 22829 is older and it's related to a real world application.
Further conversations about this bug can be done there.
*** This bug has been marked as a duplicate of bug 22829 ***
http://bugs.winehq.org/show_bug.cgi?id=28881
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Frédéric Delanoy frederic.delanoy@gmail.com 2012-04-30 14:52:07 CDT --- Closing DUPLICATE bugs.