http://bugs.winehq.org/show_bug.cgi?id=23908
Summary: regedit fails to process some registry files Product: Wine Version: 1.3.0 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, regression, testcase Severity: minor Priority: P2 Component: programs AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com CC: aeikum@codeweavers.com
Created an attachment (id=30015) --> (http://bugs.winehq.org/attachment.cgi?id=30015) registry file
Regression (I'm reasonably certain it's caused by 8851a4eb1f51fa56e5ac55d4a1d4a762abb21e3b). I noticed when trying to do 'winetricks mingw'. Winetricks attempts to set the path, using the registry, and now, crashes: + WINEDLLOVERRIDES=mshtml= wine regedit c:\winetrickstmp\path.reg Warning! unrecognized line: " wine: Unhandled page fault on read access to 0x0000003d at address 0x68068af3 (thread 0024), starting debugger... Unhandled exception: page fault on read access to 0x0000003d in 32-bit code (0x68068af3). ... Backtrace: =>0 0x68068af3 HEAP_MakeInUseBlockFree+0x123(subheap=0x110014, pArena=0x111908) [/home/austin/wine-git/dlls/ntdll/heap.c:640] in ntdll (0x0032f348) 1 0x68068ca9 RtlFreeHeap+0x78(heap=0x110000, flags=0x0002, ptr=0x111910) [/home/austin/wine-git/dlls/ntdll/heap.c:1756] in ntdll (0x0032f3e8) 2 0x6829de68 processRegEntry+0x1c7(stdInput=<is not available>, isUnicode=<is not available>) [/home/austin/wine-git/programs/regedit/regproc.c:551] in regedit (0x0032f468) 3 0x6829e9ca import_registry_file+0x219(reg_file=0x1116c8) [/home/austin/wine-git/programs/regedit/regproc.c:748] in regedit (0x0032fce8) 4 0x6829ce0d PerformRegAction+0x1fc(action=<is not available>, s="") [/home/austin/wine-git/programs/regedit/regedit.c:170] in regedit (0x0032fdc8) 5 0x6829c525 WinMain+0x24(hInstance=0x68290000, hPrevInstance=(nil), lpCmdLine="c:\winetrickstmp\path.reg", nCmdShow=0x0001) [/home/austin/wine-git/programs/regedit/main.c:179] in regedit (0x0032fe48) 6 0x682a2954 main+0xa3(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/austin/wine-git/dlls/winecrt0/exe_main.c:48] in regedit (0x0032fe90) 7 0x682a289c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/austin/wine-git/dlls/winecrt0/exe_entry.c:36] in regedit (0x0032fea8) 8 0x681637bc call_process_entry+0xb() in kernel32 (0x0032fee8) 9 0x68165aab start_process+0x5a(peb=0x7ffdf000) [/home/austin/wine-git/dlls/kernel32/process.c:996] in kernel32 (0x0032fef8) 10 0x68091170 call_thread_func+0xb() in ntdll (0x0032ffc8) 11 0x68091340 call_thread_entry_point+0x6f(entry=0x68165a50, arg=0x7ffdf000) [/home/austin/wine-git/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 12 0x6806c8da start_process+0x29(kernel_start=0x68165a50) [/home/austin/wine-git/dlls/ntdll/loader.c:2612] in ntdll (0x00000000) 0x68068af3 HEAP_MakeInUseBlockFree+0x123 [/home/austin/wine-git/dlls/ntdll/heap.c:640] in ntdll: movl 0x0(%edi),%edx 640 size += (pFree->size & ARENA_SIZE_MASK) + sizeof(ARENA_FREE);
I'll attach the full terminal output and the corresponding registry file.
http://bugs.winehq.org/show_bug.cgi?id=23908
--- Comment #1 from Austin English austinenglish@gmail.com 2010-08-05 05:32:52 --- Created an attachment (id=30016) --> (http://bugs.winehq.org/attachment.cgi?id=30016) sh -x winetricks mingw
http://bugs.winehq.org/show_bug.cgi?id=23908
--- Comment #2 from Andrew Eikum aeikum@codeweavers.com 2010-08-05 08:57:54 --- Created an attachment (id=30018) --> (http://bugs.winehq.org/attachment.cgi?id=30018) regedit: Improve importing of REG_SZ with invalid quote characters
This patch will fix it. The commit mentioned in the bug report exposed this bug later in the codepath.
It's worth noting that the reg file you uploaded is invalid; it doesn't actually import anything on native regedit either. I'm not sure where you sourced it from, but it might be worth telling them about the error.
http://bugs.winehq.org/show_bug.cgi?id=23908
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=23908
--- Comment #3 from Andrew Eikum aeikum@codeweavers.com 2010-08-16 12:47:44 --- This should be fixed by
commit dcfdfbaa54cfbcd7546f1a14217cdbaa1e96c80c Author: Andrew Eikum aeikum@codeweavers.com Date: Thu Aug 5 11:57:55 2010 -0500
regedit: Improve importing of REG_SZ with invalid quoting.
Please retest to confirm.
http://bugs.winehq.org/show_bug.cgi?id=23908
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #4 from Andrew Nguyen arethusa26@gmail.com 2010-08-16 17:44:40 --- Importing the test registry file yields:
regedit: ERROR Key HKEY_LOCAL_MACHINE\System\CurrentControlSet\Control\Session Manager\Environment not created. Value: PATH, Data: "C:\MinGW\bin;C:\MinGW\bin;C:\windows\system32;C:\windows;C:\windows\system32\wbem regedit: warning: unexpected EOL
so the bug is fixed.
http://bugs.winehq.org/show_bug.cgi?id=23908
--- Comment #5 from Austin English austinenglish@gmail.com 2010-08-18 15:56:20 --- (In reply to comment #2)
It's worth noting that the reg file you uploaded is invalid; it doesn't actually import anything on native regedit either. I'm not sure where you sourced it from, but it might be worth telling them about the error.
It's now fixed in winetricks as well.
Cheers.
http://bugs.winehq.org/show_bug.cgi?id=23908
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2010-08-20 12:39:41 --- Closing bugs fixed in 1.3.1.
-
wine-bugs＠winehq.org