[Bug 36299] New: valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Bug ID: 36299
           Summary: valgrind shows a few possible leaks in
                    msxml3/tests/httpreq.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: msxml3
          Assignee: [e-mail]
          Reporter: [e-mail]

==30801== 16 bytes in 1 blocks are possibly lost in loss record 132 of 690
==30801==    at 0x7BC4C735: notify_alloc (heap.c:255)
==30801==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==30801==    by 0x4C6C0FA: alloc_bstr (oleaut.c:162)
==30801==    by 0x4C6C490: SysAllocStringLen (oleaut.c:324)
==30801==    by 0x49B1C66: alloc_str_from_narrow (httpreq.c:95)
==30801==    by 0x49B1D13: _bstr_ (httpreq.c:109)
==30801==    by 0x49B5C64: _test_open (httpreq.c:1418)
==30801==    by 0x49B8937: test_safe_httpreq (httpreq.c:1749)
==30801==    by 0x49B8A05: func_httpreq (httpreq.c:1768)
==30801==    by 0x49EB96C: run_test (test.h:584)
==30801==    by 0x49EBD5B: main (test.h:654)
==30801==

==5517== 128 bytes in 1 blocks are possibly lost in loss record 1,323 of 1,706
==5517==    at 0x7BC4C735: notify_alloc (heap.c:255)
==5517==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==5517==    by 0x4F080FA: alloc_bstr (oleaut.c:162)
==5517==    by 0x4F08490: SysAllocStringLen (oleaut.c:324)
==5517==    by 0x4F2C9C2: MSFT_ReadValue (typelib.c:2344)
==5517==    by 0x4F2CBA3: MSFT_CustData (typelib.c:2398)
==5517==    by 0x4F2FB99: ITypeLib2_Constructor_MSFT (typelib.c:3616)
==5517==    by 0x4F2F3B8: TLB_ReadTypeLib (typelib.c:3460)
==5517==    by 0x4F276DC: LoadTypeLibEx (typelib.c:478)
==5517==    by 0x4F27618: LoadTypeLib (typelib.c:454)
==5517==    by 0x4F3C082: ITypeInfo_fnGetRefTypeInfo (typelib.c:7730)
==5517==    by 0x4F36DC5: ITypeInfoImpl_GetInternalDispatchFuncDesc
(oaidl.h:1532)
==5517==    by 0x4F36E00: ITypeInfoImpl_GetInternalDispatchFuncDesc
(typelib.c:6014)
==5517==    by 0x4F37036: ITypeInfo_fnGetFuncDesc (typelib.c:6090)
==5517==    by 0x63F0C5C: preprocess_dispex_data (oaidl.h:1505)
==5517==    by 0x63F0E79: get_dispex_data (dispex.c:323)
==5517==    by 0x63F1446: DispatchEx_GetDispID (dispex.c:420)
==5517==    by 0x4C661D5: test_selection (dispex.h:296)
==5517==    by 0x4C7AAD7: func_domdoc (domdoc.c:11916)
==5517==    by 0x4CB496C: run_test (test.h:584)
==5517==

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

--- Comment #1 from Austin English  ---
==22969== 28 bytes in 1 blocks are possibly lost in loss record 225 of 735
==22969==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==22969==    by 0x537CBB8: apartment_getclassobject (compobj.c:526)
==22969==    by 0x537FFC6: get_inproc_class_object (compobj.c:2894)
==22969==    by 0x5382D2F: CoGetClassObject (compobj.c:3032)
==22969==    by 0x53834B7: CoCreateInstance (compobj.c:3197)
==22969==    by 0x4D9CB10: create_xhr (httpreq.c:1335)
==22969==    by 0x4DA066A: func_httpreq (httpreq.c:1764)
==22969==    by 0x4DC9310: run_test (test.h:584)
==22969==    by 0x4DC96FF: main (test.h:654)
==22969==

==22969== 32 bytes in 1 blocks are definitely lost in loss record 265 of 735
==22969==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==22969==    by 0x539CC95: CreateStreamOnHGlobal (hglobalstream.c:591)
==22969==    by 0x539CD73: HGLOBALStreamImpl_Clone (hglobalstream.c:552)
==22969==    by 0x665114C: httprequest_get_responseStream.isra.1
(objidl.h:4412)
==22969==    by 0x6651215: XMLHTTPRequest_get_responseStream
(httprequest.c:1511)
==22969==    by 0x4DA21B6: func_httpreq (msxml.h:9406)
==22969==    by 0x4DC9310: run_test (test.h:584)
==22969==    by 0x4DC96FF: main (test.h:654)
==22969==

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

--- Comment #2 from Austin English  ---
==10860== 96 bytes in 1 blocks are possibly lost in loss record 449 of 711
==10860==    at 0x7BC49E0E: notify_alloc (heap.c:254)
==10860==    by 0x7BC4E044: RtlAllocateHeap (heap.c:1715)
==10860==    by 0x5ACAAC7: heap_alloc_zero (internet.h:98)
==10860==    by 0x5ACBA96: create_netconn (netconnection.c:348)
==10860==    by 0x5ABC3BA: open_http_connection (http.c:4818)
==10860==    by 0x5ABC9A3: HTTP_HttpSendRequestW (http.c:4949)
==10860==    by 0x5ABD5E9: AsyncHttpSendRequestProc (http.c:5212)
==10860==    by 0x5AC8AF7: INTERNET_WorkerThreadFunc (internet.c:3836)
==10860==    by 0x7BC89323: worker_thread_proc (threadpool.c:164)
==10860==    by 0x7BC8023F: ??? (signal_i386.c:2682)
==10860==    by 0x7BC80286: call_thread_func (signal_i386.c:2741)
==10860==    by 0x7BC8021D: ??? (signal_i386.c:2682)
==10860==    by 0x7BC8726D: start_thread (thread.c:443)
==10860==    by 0x4214EFA: start_thread (pthread_create.c:309)
==10860==    by 0x431362D: clone (clone.S:129)
==10860==

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

--- Comment #3 from Nikolay Sivov  ---
(In reply to Austin English from comment #1)
> ==22969== 32 bytes in 1 blocks are definitely lost in loss record 265 of 735
> ==22969==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
> ==22969==    by 0x539CC95: CreateStreamOnHGlobal (hglobalstream.c:591)
> ==22969==    by 0x539CD73: HGLOBALStreamImpl_Clone (hglobalstream.c:552)
> ==22969==    by 0x665114C: httprequest_get_responseStream.isra.1
> (objidl.h:4412)
> ==22969==    by 0x6651215: XMLHTTPRequest_get_responseStream
> (httprequest.c:1511)
> ==22969==    by 0x4DA21B6: func_httpreq (msxml.h:9406)
> ==22969==    by 0x4DC9310: run_test (test.h:584)
> ==22969==    by 0x4DC96FF: main (test.h:654)
> ==22969==

https://www.winehq.org/pipermail/wine-patches/2015-December/145560.html for
that particular leak. And I have a fix for

(In reply to Austin English from comment #0)
> ==30801== 16 bytes in 1 blocks are possibly lost in loss record 132 of 690
> ==30801==    at 0x7BC4C735: notify_alloc (heap.c:255)
> ==30801==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
> ==30801==    by 0x4C6C0FA: alloc_bstr (oleaut.c:162)
> ==30801==    by 0x4C6C490: SysAllocStringLen (oleaut.c:324)
> ==30801==    by 0x49B1C66: alloc_str_from_narrow (httpreq.c:95)
> ==30801==    by 0x49B1D13: _bstr_ (httpreq.c:109)
> ==30801==    by 0x49B5C64: _test_open (httpreq.c:1418)
> ==30801==    by 0x49B8937: test_safe_httpreq (httpreq.c:1749)
> ==30801==    by 0x49B8A05: func_httpreq (httpreq.c:1768)
> ==30801==    by 0x49EB96C: run_test (test.h:584)
> ==30801==    by 0x49EBD5B: main (test.h:654)
> ==30801==

the rest looks too generic, like typelib warnings, or
apartment_getclassobject().

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

--- Comment #4 from Nikolay Sivov  ---
One leak is fixed with
http://source.winehq.org/git/wine.git/?a=commit;h=08be561fbf959a127d2deb44c3....

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |08be561fbf959a127d2deb44c32
                   |                            |397a473a41e1e
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
(In reply to Nikolay Sivov from comment #4)
> One leak is fixed with
> http://source.winehq.org/git/wine.git/?a=commit;
> h=08be561fbf959a127d2deb44c32397a473a41e1e.

Fixed.

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 36299] valgrind shows a few possible leaks in msxml3/tests/httpreq.c

https://bugs.winehq.org/show_bug.cgi?id=36299

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.2.