http://bugs.winehq.org/show_bug.cgi?id=16135
Summary: msvcrt.dll._wtmpnam not implemented Product: Wine Version: 1.1.8 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: msvcrt AssignedTo: wine-bugs@winehq.org ReportedBy: holy@wustl.edu
Created an attachment (id=17376) --> (http://bugs.winehq.org/attachment.cgi?id=17376) A small head start on implementing wtmpnam
In running an old program, I received the following error: wine: Call from 0x7b845450 to unimplemented function msvcrt.dll._wtmpnam, aborting
I downloaded the source code for 1.1.8 and took a stab at implementing it. A diff (relative to wine-1.1.8/dlls/msvcrt/file.c) is attached.
Note: I don't really know Wine, and I did not even get as far as building it to test it (if MSVCRT_tmpname gets initialized, where is that?)---so please don't take this as anything other than an attempt at a start.
http://bugs.winehq.org/show_bug.cgi?id=16135
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #1 from Vijay Kamuju infyquest@gmail.com 2008-11-20 17:17:29 --- Please send the patches to wine-patches@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #2 from Vijay Kamuju infyquest@gmail.com 2008-11-20 17:18:11 --- also generate the patch properly using diff -Urn or using git
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #3 from Austin English austinenglish@gmail.com 2009-05-29 11:43:04 --- Still present in git.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #4 from Austin English austinenglish@gmail.com 2009-05-29 12:19:50 --- Is this still an issue in current (1.1.22 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #5 from Tim Holy holy@wustl.edu 2009-05-30 04:54:31 --- There is a patch available: for the final version, see http://marc.info/?l=wine-patches&m=122805886523427&w=2
I don't know of any reason this couldn't be applied to the source tree. (It wasn't sufficient to fix my problem because of another error with the application. But at least this patch seems to work properly.)
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #6 from Austin English austinenglish@gmail.com 2010-01-04 13:35:48 --- Still unimplemented: http://source.winehq.org/git/wine.git/?a=blob;f=dlls/msvcrt/msvcrt.spec#l612
You might resend it and ask for comments.
http://bugs.winehq.org/show_bug.cgi?id=16135
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #7 from Dan Kegel dank@kegel.com 2010-01-05 05:27:55 --- When you repost your patch (or heck, in a comment here) please name the old program. Bugs/patches are always more convincing when they're concrete. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=16135
Tim Holy holy@wustl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #17376|0 |1 is obsolete| |
--- Comment #8 from Tim Holy holy@wustl.edu 2010-01-05 05:44:58 --- Created an attachment (id=25554) --> (http://bugs.winehq.org/attachment.cgi?id=25554) A patch to implement msvcrt.dll._wtmpnam
This patch benefitted from several rounds of feedback from Juan Lang back in Novemeber, 2008. It may not be current anymore, but it's such a small and self-contained patch that it should be obvious how to apply it manually.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #9 from Tim Holy holy@wustl.edu 2010-01-05 05:48:47 --- Oh, and with regards to the name of the "old program": I don't remember its name any more, but it was a scientific utility to convert mass spectrometry data from one format to another.
I am now using a different instrument to collect the data, so I personally don't use that program anymore.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #10 from Austin English austinenglish@gmail.com 2011-03-29 19:27:43 CDT --- Still unimplemented, please resend.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #11 from Tim Holy holy@wustl.edu 2011-03-30 04:59:47 CDT --- (In reply to comment #10)
Still unimplemented, please resend.
Are you a wine developer? If so, can you tell me what resending means? Option 1: I can mail my old patch as-is to wine-patches. This is very easy, and I am happy to do it. But, it probably won't apply cleanly to the source tree now, because it is more than two years old. Option 2: I can download the wine source tree (I don't have it any more), try to figure where my patch applies, update my patch, and re-send it to the list.
Option 2 is not hard, but would take me a nontrivial amount of time (I don't use git, etc.). I'm willing to put some effort in for the sake of the community, but there seems little reason to do it without some evidence that it is more likely to get applied this time. This particular issue no longer affects me, so my own intrinsic motivation is fairly low, especially since it was never accepted in the first place despite some very helpful review by Juan Lang (a wine developer).
If you are a wine developer and simply asking me to clean up my work before you ensure it gets in, I am happy to do that: it is a small exchange for the many benefits I receive from running wine! If you're not a wine developer, but this issue affects you, then the problem is that I could do #2 and it still might not get in. In that case, I think you may be better suited to push for this yourself, because you can give examples that fail without it (I can't do that anymore, because I don't run that old program anymore, so I can't even test this patch, though it did work in 2008), and you care about the outcome. You could certainly download the patch and do #2 on your own.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #12 from Jerome Leclanche adys.wh@gmail.com 2011-03-30 08:41:46 CDT --- Created an attachment (id=33864) --> (http://bugs.winehq.org/attachment.cgi?id=33864) Updated patch
Updated patch to work with wine-1.3.16-145-g9ea9a05.
Cleanly applies to current git. Send this to wine-patches if it looks correct. It compiles fine, but I've no idea about functionality.
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #13 from Austin English austinenglish@gmail.com 2011-03-30 17:50:31 CDT --- (In reply to comment #12)
Created an attachment (id=33864)
--> (http://bugs.winehq.org/attachment.cgi?id=33864) [details]
Updated patch
Updated patch to work with wine-1.3.16-145-g9ea9a05.
Cleanly applies to current git. Send this to wine-patches if it looks correct. It compiles fine, but I've no idea about functionality.
You need to add forwards in the msvcr{70,71,80,90,100}.
http://bugs.winehq.org/show_bug.cgi?id=16135
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #33864|0 |1 is obsolete| |
--- Comment #14 from Jerome Leclanche adys.wh@gmail.com 2011-03-30 19:55:48 CDT --- Created an attachment (id=33872) --> (http://bugs.winehq.org/attachment.cgi?id=33872) Updated patch with forwards
(In reply to comment #13)
(In reply to comment #12)
Created an attachment (id=33864)
--> (http://bugs.winehq.org/attachment.cgi?id=33864) [details] [details]
Updated patch
Updated patch to work with wine-1.3.16-145-g9ea9a05.
Cleanly applies to current git. Send this to wine-patches if it looks correct. It compiles fine, but I've no idea about functionality.
You need to add forwards in the msvcr{70,71,80,90,100}.
Like this?
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #15 from Austin English austinenglish@gmail.com 2011-03-31 02:07:42 CDT --- (In reply to comment #14)
Created an attachment (id=33872)
--> (http://bugs.winehq.org/attachment.cgi?id=33872) [details]
Updated patch with forwards
(In reply to comment #13)
(In reply to comment #12)
Created an attachment (id=33864)
--> (http://bugs.winehq.org/attachment.cgi?id=33864) [details] [details] [details]
Updated patch
Updated patch to work with wine-1.3.16-145-g9ea9a05.
Cleanly applies to current git. Send this to wine-patches if it looks correct. It compiles fine, but I've no idea about functionality.
You need to add forwards in the msvcr{70,71,80,90,100}.
Like this?
Add msvcr71, then yes :).
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #16 from Tim Holy holy@wustl.edu 2011-03-31 02:22:01 CDT --- Thanks all for doing the update!
http://bugs.winehq.org/show_bug.cgi?id=16135
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #17 from Jerome Leclanche adys.wh@gmail.com 2011-03-31 06:26:15 CDT --- (In reply to comment #15)
Add msvcr71, then yes :).
msvcr71 already has the call (how could that even work?)
@ cdecl _wtmpnam(ptr) msvcrt._wtmpnam
http://bugs.winehq.org/show_bug.cgi?id=16135
--- Comment #18 from Austin English austinenglish@gmail.com 2011-03-31 12:09:33 CDT --- (In reply to comment #17)
(In reply to comment #15)
Add msvcr71, then yes :).
msvcr71 already has the call (how could that even work?)
@ cdecl _wtmpnam(ptr) msvcrt._wtmpnam
You're right, sorry. I misread grep's output.
http://bugs.winehq.org/show_bug.cgi?id=16135
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #19 from Austin English austinenglish@gmail.com 2011-05-03 13:45:34 CDT --- Fixed by http://source.winehq.org/git/wine.git/commitdiff/2a3484a22d6a2de286debb2b893...
http://bugs.winehq.org/show_bug.cgi?id=16135
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org 2011-05-13 13:34:12 CDT --- Closing bugs fixed in 1.3.20.
http://bugs.winehq.org/show_bug.cgi?id=16135
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other
--- Comment #21 from Austin English austinenglish@gmail.com 2012-02-23 15:27:40 CST --- Removing deprecated 'All' Platform.
-
wine-bugs＠winehq.org