[Bug 14403] New: regression - VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

Summary: regression - VFP8-SP1-Runtime crashes on a certain
                    function
           Product: Wine
           Version: 1.1.0
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P1
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=14717)
 --> (http://bugs.winehq.org/attachment.cgi?id=14717)
wine output for crash

the program (an inhouse Visual FoxPro SP1-based) application crashes on
a certain dialog in wine 1.1.0 while it ran well in wine 1.0.
According to the printout, the crash occurs in the VFP runtime.
The patch which introduced the regression is:
$ git bisect bad
ada3ca6f0990b265baff0c29f621cb9c4afd401f is first bad commit
commit ada3ca6f0990b265baff0c29f621cb9c4afd401f
Author: Rob Shearman 
Date:   Mon Jun 23 22:28:50 2008 +0100

widl: Set the type of the type_t node constructured for dispinterfaces to
RPC_FC_IP, like we do for interfaces.

:040000 040000 3b8b062ebc9ba9aa587d23b3940c3523ee1cb506
2e7f1ccc53d1999fc9f9f90c99893a8a91578997 M      tools

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|regression-VFP8SP2          |
           Severity|critical                    |normal
          Component|-unknown                    |rpc
           Keywords|                            |regression
           Priority|P1                          |P2
            Summary|regression - VFP8-SP1-      |VFP8-SP1-Runtime crashes on
                   |Runtime crashes on a certain|a certain function
                   |function                    |

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #1 from Rob Shearman   2008-07-10 11:52:34 ---
Does reverting the patch with "git revert" and then recompiling fix the crash
for you?

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #2 from Hans Baier   2008-07-10 21:21:12 ---
I used git reset --hard HEAD~1
and that fixed the crash.

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #3 from Hans Baier   2008-07-10 21:23:45 ---
That means if I use git bisect visualize,
I exactly got the revision before the mentioned patch
and that fixes it.

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #4 from Hans Baier   2008-07-11 05:51:39 ---
I think now I understand you (sorry, still new to git):
I used:
git bisect reset
git revert ada3ca6f0990b265baff0c29f621cb9c4afd401f

after that I rebuilt and it still works,
though I dont know whether I screwed up my git repository.....

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #5 from Hans Baier   2008-07-11 06:17:02 ---
Now I did a
git fetch ; git rebase origin
and recompile/install, where git placed my revert on
top of all patches (which are now up to date, 10 Jul).
And the regression is gone....

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #6 from Hans Baier   2008-07-11 22:55:24 ---
Just now I pulled in the changes from 1.1.1 and reverted the mentioned patch
and it works fine.

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #7 from Hans Baier   2008-07-28 03:58:30 ---
Just now I pulled in the changes from 1.1.2 and reverted the mentioned patch
and it works fine.

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

Rob Shearman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Rob Shearman   2008-09-11 01:16:39 ---
Fix committed:
http://source.winehq.org/git/wine.git/?a=commit;h=39978c68f9ed140f7181110952...

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

--- Comment #9 from Austin English   2008-09-11 02:14:08 ---
Fixed then?

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

Hans Baier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Hans Baier   2008-09-12 03:38:28 ---
Yes! Great! Good work!

[Bug 14403] VFP8-SP1-Runtime crashes on a certain function

http://bugs.winehq.org/show_bug.cgi?id=14403

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2008-09-19 11:17:33 ---
Closing bugs fixed in 1.1.5.