[Bug 49453] New: ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

Bug ID: 49453
           Summary: ExtractNow: buttons do nothing / don't work / function
                    (needs comctl32 version 6)
           Product: Wine
           Version: 5.11
          Hardware: x86
               URL: https://www.extractnow.com/
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

This came up on the forum and I was bored. ExtractNow is a simple looking
archive extractor thing. Problem is the buttons in the main window don't do
anything on mainline wine. Works on staging though, tracked it down to this
patch:

commit 14c33edf03750722193658b9f9a72fc21b7fb988
Author: Dmitry Timoshkov 
Date:   Tue Nov 12 18:13:20 2019 +0800

comctl32: Bump version to 6.0.

An application that I have here checks comctl32.dll version information
    and refuses to run, changing DLL version to 6.0 makes it run.

Signed-off-by: Dmitry Timoshkov

:040000 040000 2e914614641b09648642ff928d0777005f8ad070
99f4dbca57a429a7d038e014d0dd1b68a6b3ffaf M    dlls
:040000 040000 89a1c48068de16510fc9ca1d1eb1800849fc1065
a501c8d94188aa8d9c5f03435b4ee7dd370045d7 M    include

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #1 from Nikolay Sivov  ---
Does it run on Windows without embedded manifest? (using comctl32 v5)

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

Michael McGuire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Michael McGuire  ---
I'm not sure what that means? Would I need to try the program on an XP install?
Or whatever version, I don't know what windows version has which comctl
version.

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #3 from Dmitry Timoshkov  ---
(In reply to Michael McGuire from comment #2)
> I'm not sure what that means? Would I need to try the program on an XP
> install? Or whatever version, I don't know what windows version has which
> comctl version.

This needs an investigation: if an application checks the DLL version what does
it do then? Perhaps it depends on some specific behaviour? Does the application
work under XP?

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #4 from Michael McGuire  ---
(In reply to Dmitry Timoshkov from comment #3)
> This needs an investigation: if an application checks the DLL version what
> does it do then? Perhaps it depends on some specific behaviour? Does the
> application work under XP?

My hunch is this particular application isn't checking at all. Whatever that's
worth.

I did fire up an XP SP3 vm and it does work. I think though that's already
using version 6. I found a page detailing comctl32 versions and if I'm reading
it right any version of XP has v6 available.

I could try something older assuming I still have any. Or if there's some way
to force v5. Don't know.

https://www.geoffchappell.com/studies/windows/shell/comctl32/history/index.h...

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #5 from Michael McGuire  ---
Or I guess that doesn't make sense since all that patch does is change the
version. So yeah, don't know.

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from joaopa  ---
Confirming. Can be tested with
https://www.01net.com/telecharger/windows/Utilitaire/compression_et_decompre...

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #7 from Nikolay Sivov  ---
XP is a first release to provide version 6 along with version 5, and all
followed releases do the same, so version 5 remains supported in all current
Windows 10 builds. What I was asking as a test, was to remove manifest resource
from inside main application exe, that specifies comctl32 v6 dependency.
Without manifest it will load version 5 module, and the question is if
application is able to deal with this properly. That of course is not a hard
proof, because presence of the context is visible to application too and might
trigger different path, but at least it gives some insight.

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #8 from joaopa  ---
> What I was asking as a test, was to remove manifest resource from inside main application exe

And how do you do that?

[Bug 49453] ExtractNow: buttons do nothing / don't work / function (needs comctl32 version 6)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49453

--- Comment #9 from Michael McGuire  ---
Seems to be there in plain text, amazingly enough. Even more amazingly, I
naively snipped the Common Controls dependency bit out and extractnow didn't
seem to mind and appears to work. Hopefully this is useful information?