[Bug 51827] New: d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

Bug ID: 51827
           Summary: d3dx10_34:d3dx10 crashes on all versions of Windows
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d-util
          Assignee: [e-mail]
          Reporter: [e-mail]

d3dx10_34:d3dx10 crashes on all versions of Windows:

d3dx10.c:2377: this is the last test seen before the exception
00b8:d3dx10: unhandled exception c0000005 at 000000006C50064B

https://test.winehq.org/data/patterns.html#d3dx10_34:d3dx10

The crash is random but pretty frequent and happens on AMD, NVidia and QEmu
GPUs from Windows 8.1 to Windows 10.

The other d3dx10_*:d3dx10 tests don't crash despite using the same source. So
that means d3dx10_34 is different and the test fails to take that into account.

This test was introduced by the following commit:

commit a15527ff29d919b34ae1f599a5319a4b9678f4e2
Author: Nikolay Sivov 
Date:   Tue Sep 21 08:52:10 2021 +0300

d3dx10_34/tests: Enable tests.

Signed-off-by: Nikolay Sivov 
    Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |a15527ff29d919b34ae1f599a53
                   |                            |19a4b9678f4e2
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

--- Comment #1 from Nikolay Sivov  ---
Created attachment 70950
  --> https://bugs.winehq.org/attachment.cgi?id=70950
patch

Could you check if this helps? Reducing range like this patch does, seems to
affect testbot results. I don't see all affected test machines available for
testbot, is there a way to run on all of them, before submitting?

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

--- Comment #2 from François Gouget  ---
Attachment 70950 does fix the crash so I guess you can submit it.

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from François Gouget  ---
Strangely the commit below did not fix the crashes:

commit 1c7323b1926dbab4c81fd4b22b04d330459c3748
Author: Nikolay Sivov 
Date:   Wed Dec 8 21:06:27 2021 +0300

d3dx10/tests: Remove crashing tests.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51827
    Signed-off-by: Nikolay Sivov 
    Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

Yet the only material difference with attachment 70950 seems to be that 10 was
replaced with 5. Some additional tests on wtbw7u-de show that using 5 or 7
leads to a crash but 8, 9 and 10 succeed!

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

--- Comment #4 from Matteo Bruni  ---
FTR there's been some recent movement related to this bug on
https://gitlab.winehq.org/wine/wine/-/merge_requests/46.

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

--- Comment #5 from Sven Baars  ---
This was fixed by 07cb8ef5d02ba280c317b3ebb78ab9e7f28bd97f

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |07cb8ef5d02ba280c317b3ebb78
                   |                            |ab9e7f28bd97f

--- Comment #6 from Nikolay Sivov  ---
Thank you, marking fixed.

[Bug 51827] d3dx10_34:d3dx10 crashes on all versions of Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51827

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 7.9.