[Bug 12845] New: Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Summary: Mono 1.9.1 installer EULA is not rendered due to
                    richedit regression
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://ftp.novell.com/pub/mono/archive/1.9.1/windows-
                    installer/2/mono-1.9.1-gtksharp-2.10.4-win32-2.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

When running the Mono 1.9.1 installer with today's Git
(wine-0.9.60-354-g4055751), the EULA text box is rendered blank. Regression
testing showed the bad commit in question to be:

4f95cf707254653a3199caff3553fd0f732f23df is first bad commit
commit 4f95cf707254653a3199caff3553fd0f732f23df
Author: Alex Villacís Lasso 
Date:   Thu Apr 24 10:07:12 2008 -0500

riched20: Reject RTF that is recognized as invalid.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

scguy318  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Austin English   2008-04-28 04:47:52 ---
Confirming.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

--- Comment #2 from Alex Villacís Lasso   2008-04-28 13:04:42 ---
Currently downloading installer...

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Alex Villacís Lasso  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Difficulty|---                         |Hours

--- Comment #3 from Alex Villacís Lasso   2008-04-29 09:36:28 ---
When I added the code to reject invalid RTF instead of silently adding text as
SF_TEXT, I forgot to check what happened to dwError in the EDITSTREAM
structure. Native richedit sets dwError to -16 when loaded stream is not valid
RTF.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Alex Villacís Lasso  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #4 from Alex Villacís Lasso   2008-04-29 09:38:24 ---
Created an attachment (id=12566)
 --> (http://bugs.winehq.org/attachment.cgi?id=12566)
Set dwError to -16 when detecting invalid RTF. Test included.

This patch implements the needed behavior and fixes the bug for me. Test
included. Already sent to wine-patches.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Alex Villacís Lasso  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #5 from Alex Villacís Lasso   2008-04-29 09:38:53 ---
Adding patch keyword.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Alex Villacís Lasso  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Alex Villacís Lasso   2008-04-30 09:49:00 ---
Patch was committed to current GIT, so marking as FIXED.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

--- Comment #7 from scguy318   2008-05-01 23:14:08 ---
Thanks, I can confirm this patch fixes the issue.

[Bug 12845] Mono 1.9. 1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2008-05-02 12:37:46 ---
Closing bugs fixed in 0.9.61.

[Bug 12845] Mono 1.9.1 installer EULA is not rendered due to richedit regression

http://bugs.winehq.org/show_bug.cgi?id=12845

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 12845] Mono 1.9.1 installer EULA is not rendered due to richedit regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=12845

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|unspecified                 |0.9.60
    Regression SHA1|                            |4f95cf707254653a3199caff355
                   |                            |3fd0f732f23df
      Fixed by SHA1|                            |2ab63774f1654a45ab82aac9d41
                   |                            |cf759af3b9a4a