[Bug 20696] New: Regression: PAF5 with Wine 1.1.33 crashes when leaving 'Individual' tab for another tab.
http://bugs.winehq.org/show_bug.cgi?id=20696
Summary: Regression: PAF5 with Wine 1.1.33 crashes when leaving 'Individual' tab for another tab. Product: Wine Version: 1.1.33 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: rm.riches@verizon.net
Created an attachment (id=24723) --> (http://bugs.winehq.org/attachment.cgi?id=24723) first log of crash
PAF (Personal Ancestral File) 5 and Wine 1.1.33 crash with an unhandled page fault when an attempt is made to switch from the Individual tab to either the Family tab or the Pedigree tab. This application function has worked fine for many Wine versions up to and including 1.1.32.
To duplicate, 1) Install PAF5 into a fresh prefix area. 2) Bring up PAF5. 3) Click on 'New'. 4) Browse somewhere and enter a file name. 5) Click 'Cancel' in the two dialogs that will follow. 6) Click on the 'Individual' tab. 7) Click on either the 'Family' tab or 'Pedigree' tab. 8) Observe the crash.
For me, the symptom happens 100% of the time. I will attach log files from two runs.
I doubt I will have time to do a Git regression run, but I will try to make time to do it.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #1 from Robert Riches rm.riches@verizon.net 2009-11-13 22:52:25 --- Created an attachment (id=24724) --> (http://bugs.winehq.org/attachment.cgi?id=24724) second crash log
http://bugs.winehq.org/show_bug.cgi?id=20696
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression: PAF5 with Wine |PAF5 crashes when leaving |1.1.33 crashes when leaving |'Individual' tab for |'Individual' tab for |another tab. |another tab. |
--- Comment #2 from Jeff Zaroyko jeffz@jeffz.name 2009-11-13 23:16:28 --- please post the results of your regression test http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=20696
Clinton Stimpson cjstimpson@utwire.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cjstimpson@utwire.net
--- Comment #3 from Clinton Stimpson cjstimpson@utwire.net 2009-11-14 01:13:19 --- a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 is first bad commit commit a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 Author: Owen Rudge orudge@codeweavers.com Date: Thu Nov 12 10:27:40 2009 -0600
comctl32: Add basic structure for IImageList interface.
:040000 040000 936b499314ad5be116b0990f2565c79a46eb448c e454f1e24ff5ae1669c69c7e70bc4f121731e5b6 M dlls
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #4 from Jeff Zaroyko jeffz@jeffz.name 2009-11-14 01:25:06 --- (In reply to comment #3)
a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 is first bad commit commit a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 Author: Owen Rudge orudge@codeweavers.com Date: Thu Nov 12 10:27:40 2009 -0600
comctl32: Add basic structure for IImageList interface.:040000 040000 936b499314ad5be116b0990f2565c79a46eb448c e454f1e24ff5ae1669c69c7e70bc4f121731e5b6 M dlls
Does reverting this commit (git revert a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4) make the application work again?
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #5 from Clinton Stimpson cjstimpson@utwire.net 2009-11-14 01:37:25 --- Yes, it no longer crashes if I do a git revert a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4.
http://bugs.winehq.org/show_bug.cgi?id=20696
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |owen@owenrudge.net
--- Comment #6 from Jeff Zaroyko jeffz@jeffz.name 2009-11-14 01:55:49 --- adding author cc.
http://bugs.winehq.org/show_bug.cgi?id=20696
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2009-11-14 02:25:31 --- (In reply to comment #3)
a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 is first bad commit commit a4f2ab9d14bb4ed76958a5405aa463c4569fb9e4 Author: Owen Rudge orudge@codeweavers.com Date: Thu Nov 12 10:27:40 2009 -0600
comctl32: Add basic structure for IImageList interface.:040000 040000 936b499314ad5be116b0990f2565c79a46eb448c e454f1e24ff5ae1669c69c7e70bc4f121731e5b6 M dlls
It was faster than I expected. Probably it's time to fully revert this one and try to implement v6 manifest dependency.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2009-11-14 03:10:58 --- (In reply to comment #7)
It was faster than I expected. Probably it's time to fully revert this one and try to implement v6 manifest dependency.
We could first try with a more compatible layout. There's no reason that all the fields need to be moved.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com 2009-11-14 03:19:44 --- (In reply to comment #8)
(In reply to comment #7)
It was faster than I expected. Probably it's time to fully revert this one and try to implement v6 manifest dependency.
We could first try with a more compatible layout. There's no reason that all the fields need to be moved.
That's great. All we need currently is a vtable at zero offset, we could move refcount to the end as well as magic field. After that all others we be at the same offsets.
Now we can even drop magic field evaluation, we could check vtable pointer instead.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com 2009-11-14 07:29:53 --- Created an attachment (id=24730) --> (http://bugs.winehq.org/attachment.cgi?id=24730) Keep compatible layout
Hi, Robert.
Please try this patch on top of 1.1.33 tree.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #11 from Clinton Stimpson cjstimpson@utwire.net 2009-11-14 10:03:38 ---
That patch fixes it for me.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #12 from Robert Riches rm.riches@verizon.net 2009-11-14 11:47:08 --- The patch fixes it for me, also.
Thank you.
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #13 from Nikolay Sivov bunglehead@gmail.com 2009-11-15 03:50:55 --- Updated patch sent:
http://www.winehq.org/pipermail/wine-patches/2009-November/081394.html
http://bugs.winehq.org/show_bug.cgi?id=20696
--- Comment #14 from Robert Riches rm.riches@verizon.net 2009-11-15 11:13:29 --- Created an attachment (id=24766) --> (http://bugs.winehq.org/attachment.cgi?id=24766) What I copied from the HTML page and applied to a vanilla 1.1.33 tree.
This is what I copied and pasted from the above HTML page. When applied to a vanilla 1.1.33 tree, this patch worked for me.
http://bugs.winehq.org/show_bug.cgi?id=20696
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #15 from Nikolay Sivov bunglehead@gmail.com 2009-11-16 19:46:19 --- Fixed by commit 3e20458acafcf2c92cce4dfb30dafb28bb6dc99f.
http://bugs.winehq.org/show_bug.cgi?id=20696
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org 2009-12-04 12:16:29 --- Closing bugs fixed in 1.1.34.
http://bugs.winehq.org/show_bug.cgi?id=20696
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3e20458acafcf2c92cce4dfb30d | |afb28bb6dc99f Regression SHA1| |a4f2ab9d14bb4ed76958a5405aa | |463c4569fb9e4
-
wine-bugs＠winehq.org