http://bugs.winehq.org/show_bug.cgi?id=28086
Summary: Army Builder v3.1c: buttons not clickable Product: Wine Version: 1.3.26 Platform: x86 URL: http://www.armybuilder.com/download/ab31c_install.exe OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: gdi32 AssignedTo: wine-bugs@winehq.org ReportedBy: gyebro69@gmail.com CC: bunglehead@gmail.com Regression SHA1: 352e2ff6eb5116d2ac91db9258ae288733e3a271
Symptom: when starting the application, a number of dialogue boxes appear, showing tips etc. Clicking on the <OK> or any other buttons with the mouse has no effect. The buttons can be activated by selecting them with the mouse and pressing <Space> or <Enter>.
Nothing relevant in the terminal, only: fixme:ntdll:NtLockFile I/O completion on lock not implemented yet
This problem once has been reported in bug #14702. It went away in 1.1.35 but as a side effect, text has disappeared on the buttons. The problem with the unclickable buttons was re-introduced in Wine-1.1.43 and regression testing resulted the following commit:
352e2ff6eb5116d2ac91db9258ae288733e3a271 is the first bad commit commit 352e2ff6eb5116d2ac91db9258ae288733e3a271 Author: Nikolay Sivov nsivov@codeweavers.com Date: Mon Apr 12 13:00:45 2010 +0400
gdi32: Use supplied hdc for DIB_RGB_COLORS if it's valid.
This is about fixing regression introduced with 2854884a428e222cbb9078d875068a72f25365c4. Initial patch fixed MSVS 2005 toolbars blackness, this one doesn't break a fix, and fixes regressed Animation control glitches (and probably reported games related problems).
:040000 040000 a62c5e889d4dcc28feb9192da502d7ccff91d3e7 dc93afa4776b556c17cdf8a465096919c1cb6a85 M dlls
I could revert the patch cleanly on Wine-1.3.15 and that fixed the problem (although text is missing again on the buttons with the reverted patch)
Author of the patch added to CC. Download link to the demo version added to URL.
Fedora 15 x86 Gnome 3
http://bugs.winehq.org/show_bug.cgi?id=28086
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
--- Comment #1 from GyB gyebro69@gmail.com 2011-08-14 14:03:09 CDT --- Added some keywords.
http://bugs.winehq.org/show_bug.cgi?id=28086
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.armybuilder.com/ |http://www.lonewolfdevel.co |download/ab31c_install.exe |m/submit/get_product.asp?pr | |oduct=ab Summary|Army Builder v3.1c: buttons |Army Builder v3.3b: buttons |not clickable |not clickable
--- Comment #2 from GyB gyebro69@gmail.com 2011-08-14 14:13:29 CDT --- Um, sorry...I confused with the version numbers of the app. Actually, it is Army Builder v3.3b that shows the reported problem. AB v3.1c suffers from a different bug. Now I corrected both the download link and the title of the bug report.
http://bugs.winehq.org/show_bug.cgi?id=28086
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2011-08-14 15:41:50 CDT --- I'm not sure how to test that. If I manually revert this commit on current tree I still can't get button work with mouse.
How does it look on Windows by the way? I mean when you press it with mouse click does it different bitmap indicating 'pressed' button state? My guess is that SetDIBits fails for some reason and some code path after repainting is skipped.
http://bugs.winehq.org/show_bug.cgi?id=28086
--- Comment #4 from GyB gyebro69@gmail.com 2011-08-14 21:39:35 CDT --- Created an attachment (id=35960) --> (http://bugs.winehq.org/attachment.cgi?id=35960) screenshot - buttons in Windows
I could only try the application in Virtualbox (Win XP guest). The screenshot shows what the buttons look like in normal and in pressed state.
http://bugs.winehq.org/show_bug.cgi?id=28086
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2011-10-02 13:44:04 CDT --- SetDIBits() was significantly changed recently with 5f35075c8be21f46d5c73d782d2aa7435f5d576f, so I'm not sure regression results mean too much now. Also I wasn't able to reproduce that when patch was revertible.
http://bugs.winehq.org/show_bug.cgi?id=28086
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2011-10-03 10:07:00 CDT --- It should definitely be retested with current git.
http://bugs.winehq.org/show_bug.cgi?id=28086
--- Comment #7 from GyB gyebro69@gmail.com 2011-10-03 10:32:18 CDT --- Buttons are still not clickable in Army Builder 3.3.b, using wine-1.3.29-121-gfdda702.
http://bugs.winehq.org/show_bug.cgi?id=28086
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f6c7e96a61bf6755f005bb7d188 | |3154ffacc65c3 Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #8 from GyB gyebro69@gmail.com 2011-10-20 15:27:08 CDT --- Buttons are clickable in Army Builder 3.3b, thanks to this commit: http://source.winehq.org/git/wine.git/commit/f6c7e96a61bf6755f005bb7d1883154...
http://bugs.winehq.org/show_bug.cgi?id=28086
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2011-10-21 13:50:03 CDT --- Closing bugs fixed in 1.3.31.