[Bug 33913] New: Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Bug #: 33913
           Summary: Radio button rendering broken with
                    ClientSideGraphics=y
           Product: Wine
           Version: 1.6-rc4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 45042
  --> http://bugs.winehq.org/attachment.cgi?id=45042
Test program

When ClientSideGraphics registry key is set to "n", rendering is correct [1].
But when it is either set to "y" or doesn't exist (as default), rendering is
wrong [2]. It appears to look wrong because something goes wrong with
gdi32!Pie() function implementation - with ClientSideGraphics it calculates
positions differently from gdi32!Ellipse() with same rect passed.
You can see this using test program in attachment (compare top and bottom at
[3] - notice different pies at top-left and and the rightmost one).

[1]: http://i0.simplest-image-hosting.net/picture/csrn.png
[2]: http://i0.simplest-image-hosting.net/picture/csry.png
[3]: http://i0.simplest-image-hosting.net/picture/pens.png

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Nikolay Sivov  2013-06-30 02:39:49 CDT ---
I can confirm that, it looks like dib engine draws arcs slightly different and
it becomes more visible for smaller arc sizes. CC'ing Huw.

Please attach these screenshots here instead of using external links.

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

--- Comment #2 from Alexandre Julliard  2013-06-30 02:55:59 CDT ---
Created attachment 45047
  --> http://bugs.winehq.org/attachment.cgi?id=45047
Arc limits

This should help.

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

--- Comment #3 from Nikolay Sivov  2013-06-30 03:38:54 CDT ---
Created attachment 45048
  --> http://bugs.winehq.org/attachment.cgi?id=45048
test image with a patch

Yes, it's much better with this patch, but it's not pixel-identical, not sure
if it's even a goal. See attached image, left part with "y" setting, right -
with "n".

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a973df332457ed97abacf52e11f
                   |                            |f9eabf19acd30
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Alexandre Julliard  2013-07-01 14:48:29 CDT ---
Fixed by a973df332457ed97abacf52e11ff9eabf19acd30.

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 33913] Radio button rendering broken with ClientSideGraphics=y

http://bugs.winehq.org/show_bug.cgi?id=33913

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-07-12 13:48:20 CDT ---
Closing bugs fixed in 1.6-rc5.