[Bug 16240] New: really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

Summary: really long lines fail to import into registery
           Product: Wine
           Version: CVS/GIT
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=17500)
 --> (http://bugs.winehq.org/attachment.cgi?id=17500)
registery file that fails to import

segfaults at this line
http://source.winehq.org/git/wine.git/?a=blob;f=programs/regedit/regproc.c;h...

I tried to add in traces but sadly I didn't get any more details.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

--- Comment #1 from Danny Rawlins   2008-11-28 05:21:29 ---
Created an attachment (id=17501)
 --> (http://bugs.winehq.org/attachment.cgi?id=17501)
my attempt to trace the bug

failed attempt to trace this but maybe i still ran the wrong regedit from the
path, or have i made a mistake in my edit? Note I tried ULIMIT64 to see if that
was a limit reached issue, which it appears it is not.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal
            Version|CVS/GIT                     |1.1.9

--- Comment #2 from Jeff Zaroyko   2008-11-28 05:26:20 ---
not a blocker, please don't use the CVS/GIT version tag, it's deprecated.

The file imports fine for me if I convert it to ASCII, it looks like it's in
UTF-16 or something as-is.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs
           Keywords|                            |download, source

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

--- Comment #3 from Danny Rawlins   2008-11-29 01:34:51 ---
Hi,

That file is in UTF-16 as "Windows Registry Editor Version 5.0" exports as
UTF-16 and that routine does deal with wide chars, so clearly there is a bug in
the wide char parsing and not in the line lengths that i got the seh backtrace
to that line 814. I clearly can't read all bug traces correctly yet.

As for the version I tested with wine-1.1.9-91-gf552c90 and that the version is
not the 1.1.9 but a higher than version so that's why i chose cvs/git as it is
git. The fact it's obsolete means it should no longer exist on the form. So I
will submit a bug for the bug tracker for that to be rectified.

So clearly there is a bug in WCHAR to ASCII conversion or whatever it exactly
does.

I didn't set a module as there is no regedit and it is a program in wine so why
is that not included?

I set it to blocker because it blocks importing that reg file. Armed with new
information I will now look at the locale parser/conversion more.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

--- Comment #4 from André H.   2008-12-11 10:33:17 ---
Created an attachment (id=17836)
 --> (http://bugs.winehq.org/attachment.cgi?id=17836)
good example that it just fails at lines with ""

I Guess it has some Problems with the ""
In my regfile it imports everything until the lines with "" comes, then
regedit crashes.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

--- Comment #5 from Andrew Nguyen   2009-03-09 22:50:45 ---
This appears to be fixed by 5bd7e306b47b16a5c5c9edc1b3980b504aca47d9.

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #6 from André H.   2009-09-06 10:58:36 ---
yes, this was fixed 6 month ago...

[Bug 16240] really long lines fail to import into registery

http://bugs.winehq.org/show_bug.cgi?id=16240

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2009-09-25 12:25:12 ---
Closing bugs fixed in 1.1.30.