[Bug 46691] New: comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Bug ID: 46691
           Summary: comctl32/tests/propsheet.c shows uninitalized memory
                    use
           Product: Wine
           Version: 4.2
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: Gentoo

../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p
comctl32_test.exe.so propsheet && touch propsheet.ok
==30493== Syscall param write(buf) points to uninitialised byte(s)
==30493==    at 0x4253C7F: write (write.c:27)
==30493==    by 0x7BC75AAB: send_request (server.c:213)
==30493==    by 0x7BC767F0: server_call_unlocked (server.c:288)
==30493==    by 0x7BC76845: wine_server_call (server.c:321)
==30493==    by 0x4FA5FFD: PostQuitMessage (message.c:3762)
==30493==    by 0x5975F8E: do_loop (propsheet.c:2781)
==30493==    by 0x5976031: PROPSHEET_PropertySheet (propsheet.c:2815)
==30493==    by 0x5976612: PropertySheetA (propsheet.c:2865)
==30493==    by 0x4AE4E8F: test_bad_control_class (propsheet.c:1167)
==30493==    by 0x4AE82D7: func_propsheet (propsheet.c:1208)
==30493==    by 0x4B2C64C: run_test (test.h:617)
==30493==    by 0x4B2D08A: main (test.h:701)
==30493==  Address 0x4c6fb58 is on thread 1's stack
==30493==  in frame #4, created by PostQuitMessage (message.c:3758)
==30493==  Uninitialised value was created by a stack allocation
==30493==    at 0x5975EC4: do_loop (propsheet.c:2762)
==30493==

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

--- Comment #1 from Nikolay Sivov  ---
Created attachment 63653
  --> https://bugs.winehq.org/attachment.cgi?id=63653
patch

Maybe something like this.

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Austin English  ---
(In reply to Nikolay Sivov from comment #1)
> Created attachment 63653 [details]
> patch
>
> Maybe something like this.

Works for me, thanks

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |71004a825f166f8aa11ad15ecc2
                   |                            |3d7e4b1de7103
                 CC|[e-mail]        |
    Regression SHA1|                            |4ee173dfdd7b98190e8758782ce
                   |                            |a3ba88d2237cc
         Resolution|---                         |FIXED
           Keywords|                            |regression

--- Comment #3 from Nikolay Sivov  ---
Marking fixed, 71004a825f166f8aa11ad15ecc23d7e4b1de7103.

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 4.3.

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 46691] comctl32/tests/propsheet.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46691

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.1.