[Bug 15312] New: Visual Studio 2005 requires SetDIBits to handle a NULL DC and DOB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Summary: Visual Studio 2005 requires SetDIBits to handle a NULL
                    DC and DOB_RGB_COLORS
           Product: Wine
           Version: 1.1.4
          Platform: PC-x86-64
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=16144)
 --> (http://bugs.winehq.org/attachment.cgi?id=16144)
patch

Currently we have only a FIXME for this case. It seems to cause only a small
visual glitch - the panes' titles backgrounds are black. The attached patch can
be used to check that this is the problem. Of course, it is not a correct
solution of the problem.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Mikolaj Zalewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Visual Studio 2005 requires |Visual Studio 2005 requires
                   |SetDIBits to handle a NULL  |SetDIBits to handle a NULL
                   |DC and DOB_RGB_COLORS       |DC and DIB_RGB_COLORS

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #1 from Austin English   2009-03-30 13:20:26 ---
Is this still an issue in current (1.1.18 or newer) wine?

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Nicholas Doyle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Nicholas Doyle   2009-04-18 16:14:26 ---
(In reply to comment #1)
> Is this still an issue in current (1.1.18 or newer) wine?

Yes. On wine 1.1.19 I can confirm that the backgrounds for the toolbox pane are
still black, and the toolbox icons do not display properly.  Also, the titles
for the toolbox tabs do not appear unless you select them. I will attach a
screen shot.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #3 from Nicholas Doyle   2009-04-18 16:27:58 ---
Created an attachment (id=20531)
 --> (http://bugs.winehq.org/attachment.cgi?id=20531)
Shows black background in toolbox and other panes

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #4 from Nikolay Sivov   2009-10-18 08:27:43 ---
Created an attachment (id=24218)
 --> (http://bugs.winehq.org/attachment.cgi?id=24218)
Always create a context for DIB_RGB_COLORS

Hi, Mikolaj.

Does this patch look right?

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #5 from Nikolay Sivov   2009-10-21 17:30:12 ---
http://bugs.winehq.org/attachment.cgi?id=24218

Could somebody test a patch? VS2005 Express seems to be unavailable from
official locations.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #6 from Mikolaj Zalewski   2009-10-21 23:26:12 ---
Hi,
I'm currently unable to test this, but I should be able to give it a try in a
week. The patch looks correct, but I'm not a gdi expert (it might not have the
best performance because of creating a DC for every bitblt, but it's still
better than broken functionality)

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #7 from Dmitry Timoshkov   2009-10-21 23:50:40 ---
winetricks should be able to download and install VS2005 Express.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

--- Comment #8 from Nikolay Sivov   2009-10-22 04:38:11 ---
(In reply to comment #7)
> winetricks should be able to download and install VS2005 Express.

Ha, you're right. I just tried and it certainly works. Patch sent.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Nikolay Sivov   2009-10-22 10:49:56 ---
Fixed by commit:

http://source.winehq.org/git/wine.git/?a=commit;h=2854884a428e222cbb9078d875...

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

http://bugs.winehq.org/show_bug.cgi?id=15312

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2009-10-23 13:18:49 ---
Closing bugs fixed in 1.1.32.

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

https://bugs.winehq.org/show_bug.cgi?id=15312

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2854884a428e222cbb9078d8750
                   |                            |68a72f25365c4
                 CC|                            |[e-mail]

[Bug 15312] Visual Studio 2005 requires SetDIBits to handle a NULL DC and DIB_RGB_COLORS

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=15312

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20161115203751/http://down
                   |                            |load.microsoft.com/download
                   |                            |/6/f/5/6f5f7a01-50bb-422d-8
                   |                            |742-c099c8896969/En_vs_2005
                   |                            |_vsts_180_Trial.img
           Keywords|                            |download