https://bugs.winehq.org/show_bug.cgi?id=54295
Bug ID: 54295 Summary: Touhou Puppet Dance Performance: Shard of Dreams Can't Locate Base Game Data After Installation Product: Wine Version: 8.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: rjtulloh@gmail.com Distribution: ---
Created attachment 73863 --> https://bugs.winehq.org/attachment.cgi?id=73863 Log file produced by the expansion when it can't find the base game's files.
Shard of Dreams is an expansion to Touhou Puppet Dance Performance by developer FocasLens. In order to be played, the base game needs to be installed on the same system as the expansion.
On Windows, the expansion can be launched immediately after: - Installing the base game - Installing the expansion
Using Wine, the expansion won't launch after running the same installers.
The expansion can be launched by adding a symbolic link with the name "notkey" in the expansion's installation folder which points to the base game folder. But this workaround is not needed on Windows.
The expansion also produces an error log when launched without the notkey link. The log is attached.
https://bugs.winehq.org/show_bug.cgi?id=54295
Robert T rjtulloh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.fo-lens.net/enbu | |_ap/
https://bugs.winehq.org/show_bug.cgi?id=54295
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=54295
Robert T rjtulloh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|8.0-rc3 |8.12
--- Comment #1 from Robert T rjtulloh@gmail.com --- This issue is still present in 8.12.
https://bugs.winehq.org/show_bug.cgi?id=54295
Robert T robertthesable@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|8.12 |8.17
--- Comment #2 from Robert T robertthesable@gmail.com --- This issue is still present in 8.17.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #3 from Robert T robertthesable@gmail.com --- Created attachment 75232 --> https://bugs.winehq.org/attachment.cgi?id=75232 Relay log for Shard of Dreams failing to launch due to this bug.
Adding a +relay log for this bug in wine 8.17.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #4 from Fabian Maurer dark.shadow4@web.de --- Could you give us instructions on how to reproduce? Preferably using direct links for donwloads.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #5 from Robert T robertthesable@gmail.com --- The game is not free, so I cannot provide direct links.
Both the base game and expansion may be purchased via DLSite.
Base game: https://www.dlsite.com/home/work/=/product_id/RJ179146.html Expansion: https://www.dlsite.com/home/work/=/product_id/RJ179149.html
Steps to reproduce: - Install the base game via the official installer. - Install the expansion via the official installer. - Try to run the expansion.
The expansion will fail to launch and will produce a "Log.txt" file with similar messages to the first log I attached.
It is possible to workaround this issue by copying or linking the base game into a "notkey" folder within the expansion's installation path. However, this workaround is not required on Windows.
https://bugs.winehq.org/show_bug.cgi?id=54295
Robert T robertthesable@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #6 from Robert T robertthesable@gmail.com --- Based on some testing I believe the root cause is a bug in ExpandEnvironmentStringsA involving Japanese glyphs. Not sure if other non-ASCII glyphs are affected as well.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #7 from Robert T robertthesable@gmail.com --- Created attachment 75236 --> https://bugs.winehq.org/attachment.cgi?id=75236 Sample program which can be used for testing.
Since there's no free download, I wrote a sample program which i believe reproduces one of the causes of the issue. This runs as expected on Windows.
https://bugs.winehq.org/show_bug.cgi?id=54295
Robert T robertthesable@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |kernel32
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #8 from Fabian Maurer dark.shadow4@web.de --- Created attachment 75237 --> https://bugs.winehq.org/attachment.cgi?id=75237 WIP patch
First off, many thanks for the sample it is very useful.
Can you see if the attached test helps? I think I found the issue, the example now works, but it would be good to see if the game does as well.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #9 from Robert T robertthesable@gmail.com --- Yes, the expansion launches without the notkey workaround after applying the patch.
Thank you for your work on this.
https://bugs.winehq.org/show_bug.cgi?id=54295
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #10 from Fabian Maurer dark.shadow4@web.de --- Created a MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/4045
Would you mind retesting if that works as well? Just to be extra safe.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #11 from Robert T robertthesable@gmail.com --- The expansion launches with the merge request as well.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #12 from Robert T robertthesable@gmail.com --- Any progress on the MR?
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #13 from Fabian Maurer dark.shadow4@web.de --- I'm afraid not, I'm still waiting for someone to review it. I too wish my merge requests would be addressed quicker, but there's not much I can do.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #14 from Robert T robertthesable@gmail.com --- Any progress on the MR in the new year? I saw it was paused because of the code freeze, is that still in effect?
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #15 from Fabian Maurer dark.shadow4@web.de --- No, codefreeze is over. I'll need to rework this one. I kinda wanted to wait until my other MRs got reviewed, but seeing how they are just sitting there... Not sure what I should do to speed things up.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #16 from Robert T robertthesable@gmail.com --- The bug still occurs in Wine 9.8.
https://bugs.winehq.org/show_bug.cgi?id=54295
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase Version|8.17 |8.0-rc2
--- Comment #17 from Ken Sharp imwellcushtymelike@gmail.com --- Please don't change the Wine version once logged.
https://bugs.winehq.org/show_bug.cgi?id=54295
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f666b3c89a1869823d739e75ab2 | |d7e58a0692ab5 Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #18 from Fabian Maurer dark.shadow4@web.de --- Fixed by https://gitlab.winehq.org/wine/wine/-/commit/f666b3c89a1869823d739e75ab2d7e5...
https://bugs.winehq.org/show_bug.cgi?id=54295
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.21.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #20 from Robert T robertthesable@gmail.com --- My current distro unfortunately hasn't packaged Wine 9.21 or 9.22 yet, so I wasn't able to check if the game works until I found an alternate installation source today.
I can confirm that the Shard of Dream expansion launches without and workarounds.
Many thanks to Fabian, Nikolay, Alexandre, and anyone else who helped in getting this fix delivered! It may seem like a small issue, but your work is appreciated.
https://bugs.winehq.org/show_bug.cgi?id=54295
--- Comment #21 from Fabian Maurer dark.shadow4@web.de --- (In reply to Robert T from comment #20)
Many thanks to Fabian, Nikolay, Alexandre, and anyone else who helped in getting this fix delivered! It may seem like a small issue, but your work is appreciated.
You're welcome, always glad if my efforts are appreciated!