https://bugs.winehq.org/show_bug.cgi?id=55082
Bug ID: 55082 Summary: Zoria and the Cursed Land demo crashes due to HLSL compilation failure ('Multiple variables bound to s0') Product: vkd3d Version: 1.7 Hardware: x86-64 URL: https://store.steampowered.com/app/1622110/Zoria_and_t he_Cursed_Land/ OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: hlsl Assignee: wine-bugs@winehq.org Reporter: gijsvrm@gmail.com Distribution: ---
Created attachment 74632 --> https://bugs.winehq.org/attachment.cgi?id=74632 output
This happens after character creation.
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- This happens because there are indeed to sampler object bound to the same register, but one of them is never used. I'll take a look, but it seems we simply need to eliminate such unused variables before allocating registers, but after dce-related passes were completed.
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239
https://bugs.winehq.org/show_bug.cgi?id=55082
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |1c1f1094a5a1a748eebc5fcb456 | |ff8404981a00e
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- I think this should be fixed now, with https://source.winehq.org/git/vkd3d.git/commit/1c1f1094a5a1a748eebc5fcb456ff....
https://bugs.winehq.org/show_bug.cgi?id=55082
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED
--- Comment #4 from Gijs Vermeulen gijsvrm@gmail.com --- Nikolay, I'm still getting these messages with latest vkd3d-git and wine-git:
01b0:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4. 01b0:err:d3dcompiler:D3DCompile2 Shader log: 01b0:err:d3dcompiler:D3DCompile2 <anonymous>:28:19: E5015: Multiple variables bound to s0. 01b0:err:d3dcompiler:D3DCompile2 <anonymous>:3:11: Variable 'gm_BaseTexture' is already bound to s0. 01b0:err:d3dcompiler:D3DCompile2
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 74694 --> https://bugs.winehq.org/attachment.cgi?id=74694 failing shader
Yes, you are right. Attaching failing shader. I'll see what's different from our tests.
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com --- This has something to do with sampler registers specifically, we don't have a test for those, probably because it will fail anyway on SM4+.
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com --- Submitted another test https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/249, it's probably about the order, when the first declared object is used, it works, otherwise it fails.
https://bugs.winehq.org/show_bug.cgi?id=55082
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com --- Test got in, the fix is submitted https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/253.
https://bugs.winehq.org/show_bug.cgi?id=55082
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1|1c1f1094a5a1a748eebc5fcb456 |d4b5e79c8b676024c5aee3f8dad |ff8404981a00e |bc8eea4c9d9ec Status|REOPENED |RESOLVED
--- Comment #9 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Nikolay Sivov from comment #8)
Test got in, the fix is submitted https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/253.
Fix committed as https://gitlab.winehq.org/wine/vkd3d/-/commit/d4b5e79c8b676024c5aee3f8dadbc8...
Confirming this one is fixed now.
https://bugs.winehq.org/show_bug.cgi?id=55082
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com --- Closing bugs fixed in 1.9.