http://bugs.winehq.org/show_bug.cgi?id=18490
Summary: Empire: Total War crashes when loading a map Product: Wine Version: 1.1.21 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: nwarrenfl@gmail.com
Created an attachment (id=21123) --> (http://bugs.winehq.org/attachment.cgi?id=21123) Wine output when loading a map
It seems there was no bug report concerning that yet, so i tested it with Wine 1.1.20 and it still crashes when the game tries to load a map.
The game requires multiple buffers, so i used fbo as OffscreenRenderingMode, otherwise it doesn't load at all.
Now that fbo is used, the game loads, but crashes when loading a map, i've attached the wine output.
I suppose this isn't enough to find the problem, so if other debug channels are needed to find the problem, please ask and i'll do it.
Thanks in advance.
http://bugs.winehq.org/show_bug.cgi?id=18490
Igor igor.demyanov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #1 from Igor igor.demyanov@gmail.com 2009-07-14 16:47:12 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=18490
Mathieu Belanger b747xx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |b747xx@gmail.com
--- Comment #2 from Mathieu Belanger b747xx@gmail.com 2009-08-16 19:47:04 --- Empire Total war crash when loading a battle.
http://bugs.winehq.org/show_bug.cgi?id=18490
naur mig21@static.int.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mig21@static.int.pl
--- Comment #3 from naur mig21@static.int.pl 2009-09-02 20:02:29 --- This crash happens because SetPixelFormat is called on screen device context (GetDC(NULL)). Wine refuses to set pixel format and returns FALSE which causes the crash. Note that technically Windows returns TRUE from SetPixelFormat when it gets the DC of desktop window (and most of the time this causes problems later, but that's off-topic). Based on those facts, I've made a simple and hackish workaround patch for this problem. After applying it, SetPixelFormat will save the pixel format in the X11DRV_PDEVICE and return TRUE instead of FALSE. This allows the game to run, although it degrades error checking. So I'm not expecting this to get included in Wine's repository. :-) My solution is also rather incomplete since Wine cannot actually modify the X root window. Besides, the real cause of problem is located higher in the the backtrace. The game is D3D9 based, so the bug might be located somewhere in Wine's D3D9 libraries. I'm including a backtrace from the point where SetPixelFormat receives invalid DC. The pPresentationParameters structure passed to D3D9 CreateDevice function has hDeviceWindow set to NULL and Windowed set to 1.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #4 from naur mig21@static.int.pl 2009-09-02 20:08:41 --- Created an attachment (id=23393) --> (http://bugs.winehq.org/attachment.cgi?id=23393) SetPixelFormat patch to accept screen DC
Allows the game to run, slightly fixes compatibility with Windows.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #5 from naur mig21@static.int.pl 2009-09-02 20:12:15 --- Created an attachment (id=23394) --> (http://bugs.winehq.org/attachment.cgi?id=23394) Backtrace from the point of SetPixelFormat failure
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #6 from Warren Dumortier nwarrenfl@gmail.com 2009-10-11 12:47:39 --- I've contacted Stefan Dossinger and he says this is because X11 doesn't allow opengl rendering to the root window. He also said we should write a test that does this on Windows and see what it returns:
Q1: What does Windows return? Q2: If Windows creates the device properly, what happens if you render to it? Q3: What happens if you present the rendering with a dest window override in swapchain::present? Q4: What happens if you present without a dest window override?
The crash happens because SetPixelFormat is called on screen device context (GetDC(NULL)). Wine refuses to set pixel format and returns FALSE which causes the crash.
It seems there could be a solution if we know the answer of Q3. In d3d, you can change the window the rendering is copied to at the end of the draw, so the app might set up the device to draw to the NULL window first and later on send the output to a non-NULL window. For this we could render offscreen, and later when we get the real window switch to onscreen rendering.
http://bugs.winehq.org/show_bug.cgi?id=18490
larlin@lysator.liu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |larlin@lysator.liu.se
--- Comment #7 from larlin@lysator.liu.se 2009-11-26 07:38:00 --- The patch works for me also, some notes:
I can't get pbuffer to work at all. It crashes on map load I'm on a nvidia card with nvidia proprietary driver. With fbo it works with the black boxes for most soldiers in battle.
Good work on finding this problem, is there anyone working to fix the original problem where that now may be?
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #8 from larlin@lysator.liu.se 2009-11-26 08:11:21 --- Created an attachment (id=24961) --> (http://bugs.winehq.org/attachment.cgi?id=24961) Outpu when loading battle in Empire
Making a new test what really happens is that the game at the end of the load process uses alot of resources making the computer go to a crawl and then it fails to display the battle scene.
I attach a file containing what was in the termenal. This was with pbuffer on a GeForce 7300 GT with nvidia driver version 185.18.36. Hope this help in some way.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #9 from naur mig21@static.int.pl 2010-05-15 21:08:20 --- I've investigated this issue again, this time in "Napoleon: Total War". It turns out, that IDirect3D9::createDevice method has different behaviour in Windows and Wine, when the device is created with desktop as focus window (GetWindowDesktop() handle passed in hFocusWindow argument). The Windows version of this method succeeds if D3DDEVTYPE_NULLREF or D3DDEVTYPE_REF device type is requested (and fails for other types). The Wine version of this method will always fail, regardless of the requested device type.
Note that Windows fails to perform actual rendering on devices created in that way. Hovewer, such device can still be used to perform some tasks, like loading textures in a worker thread (as described in this post: http://discussms.hosting.lsoft.com/SCRIPTS/WA-MSD.EXE?A2=ind0606C&L=DIRE... ).
I'm not really sure what's the best way to handle this situation. Perhaps Wine should create a dummy window for reference and null reference D3D9 devices?
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #10 from larlin@lysator.liu.se 2010-05-18 11:50:09 --- This sounds like some progress at last. Just want to post to give some encouragement. Hope this can lead to a patch that is acceptable for wine.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #11 from Johannes johannes.schw@gmx.de 2010-05-22 03:16:35 --- Created an attachment (id=28169) --> (http://bugs.winehq.org/attachment.cgi?id=28169) last output in terminal
http://bugs.winehq.org/show_bug.cgi?id=18490
Johannes johannes.schw@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johannes.schw@gmx.de
--- Comment #12 from Johannes johannes.schw@gmx.de 2010-05-22 03:18:27 --- This bug also occurs in the Demo of the game Napoleon: Total War.
I've attached an traceback. http://bugs.winehq.org/attachment.cgi?id=28169
http://bugs.winehq.org/show_bug.cgi?id=18490
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
--- Comment #13 from Austin English austinenglish@gmail.com 2010-06-24 07:56:10 --- *** Bug 23357 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=18490
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #14 from Dan Kegel dank@kegel.com 2010-06-26 10:56:06 --- I'm seeing this now, too. (Used wisotool napoleon_total_war_demo_steam to install.)
http://bugs.winehq.org/show_bug.cgi?id=18490
edward savage epssyis@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |epssyis@gmail.com
--- Comment #15 from edward savage epssyis@gmail.com 2010-06-27 03:32:15 --- (In reply to comment #9)
I've investigated this issue again, this time in "Napoleon: Total War".
Your patch still allows the battle part of the game to be played. Thanks for that.
http://bugs.winehq.org/show_bug.cgi?id=18490
Daniel Harvison sirbubbles01@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sirbubbles01@yahoo.com.au
--- Comment #16 from Daniel Harvison sirbubbles01@yahoo.com.au 2010-11-14 08:56:56 CST --- With 1.3.7, naval battles seem to work fine, but trying anything to do with normal land battles causes a crash.
http://bugs.winehq.org/show_bug.cgi?id=18490
Fest fest.in@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fest.in@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=18490
Christopher May maquis196@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |maquis196@yahoo.co.uk
--- Comment #17 from Christopher May maquis196@yahoo.co.uk 2011-08-27 08:31:38 CDT --- Bug still present with 1.3.27.
Also, is there anything I can do to convince someone to make the previous patch compatible with the 1.3 branch? I can't even get it to work on 1.2 anymore.
Cheers, Maq
http://bugs.winehq.org/show_bug.cgi?id=18490
greggory.hz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |greggory.hz@gmail.com
--- Comment #18 from greggory.hz@gmail.com 2011-10-08 10:52:30 CDT --- (In reply to comment #17)
Bug still present with 1.3.27.
Also, is there anything I can do to convince someone to make the previous patch compatible with the 1.3 branch? I can't even get it to work on 1.2 anymore.
Cheers, Maq
It's fairly easy to apply this patch by hand. Just edit dlls/winex11.drv/opengl.c. You'll find the relevant bits of code around line 1633. I haven't tested this yet (waiting on a steam download) and I haven't even tried to build it yet (waiting on build-deps download), but if/when I get this set up and tested, I'll post an updated version of the patch if it works.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #19 from greggory.hz@gmail.com 2011-10-08 19:16:37 CDT --- Created attachment 36782 --> http://bugs.winehq.org/attachment.cgi?id=36782 Same patch as before, just for 1.3.29
Here's the patch I promised. For me, it seems to fix the crash. However, the game isn't playable on my laptop (only place I've been able to test) because I think it lacks the horse power (intel hd 3000 integrated doesn't seem to be enough ...).
Like I said, it got rid of the crash for me, but I only tested by going directly do a battle and not through a campaign. I was able to replicate the crash this way. Building wine with this patch successfully got rid of the crash.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #20 from Christopher May maquis196@yahoo.co.uk 2011-12-20 07:43:42 CST --- Thanks greggory.hz! I just noticed the patch you put up, I should really have CC'd myself in.
I'll test it tonight but once again thank you!
On a side note - the latest in the total war series (shogun 2) works fine with just dll overrides :S.
http://bugs.winehq.org/show_bug.cgi?id=18490
Saulius K. saulius2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=18490
Jeff Cook jeff@deserettechnology.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeff@deserettechnology.com
--- Comment #21 from Jeff Cook jeff@deserettechnology.com 2012-01-02 18:42:53 CST --- Just wanted to update this bug with the status of the patch that naur uploaded. There is a thread on wine-devel about it here: http://www.winehq.org/pipermail/wine-devel/2011-December/093617.html .
The patch is considered a hack and also was likely never proposed for inclusion on wine-patches.
The thread on the mailing list says that functionality required to make D3D render properly without a window will be added after Wine 1.4 is released and that it will be "fairly invasive". The freeze and RC cycle is expected "fairly soon" by Henri Verbeet. Indeed, just 12 hours ago Alexandre posted a message to the list ( http://www.winehq.org/pipermail/wine-devel/2012-January/093629.html ) indicating that 1.4rc1 will probably come after 1.3.37, and any major changes must come into place in the next "3 weeks or so" if they are to make it into Wine 1.4 and/or the 1.4 release candidates.
In summary, official patch/support should come in the relatively near future after Wine 1.4 is released (roughly March-May sometime?).
http://bugs.winehq.org/show_bug.cgi?id=18490
streetmg@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |streetmg@hotmail.com
--- Comment #22 from streetmg@hotmail.com 2012-05-25 19:42:40 CDT --- (In reply to comment #19)
Created attachment 36782 [details] Same patch as before, just for 1.3.29
Here's the patch I promised. For me, it seems to fix the crash. However, the game isn't playable on my laptop (only place I've been able to test) because I think it lacks the horse power (intel hd 3000 integrated doesn't seem to be enough ...).
Like I said, it got rid of the crash for me, but I only tested by going directly do a battle and not through a campaign. I was able to replicate the crash this way. Building wine with this patch successfully got rid of the crash.
Hi,
I've manually patched this code a few times now (TW player) ;) and the lines that are replaced have changed in 1.5.5 (maybe before, I haven't compiled since 1.4).
Bug still present without this patch, but I didn't fully test.
http://bugs.winehq.org/show_bug.cgi?id=18490
Alexey Loukianov mooroon2@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mooroon2@mail.ru
--- Comment #23 from Alexey Loukianov mooroon2@mail.ru 2012-05-28 00:22:12 CDT --- Still present in Wine 1.5.5. Not surprisingly though as wined3d hadn't been rewritten "fairy invasive" yet to correctly support windowless rendering. Hopefully Henri would find some time to look into this problem during summer.
http://bugs.winehq.org/show_bug.cgi?id=18490
Michal R rost.michal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rost.michal@gmail.com
--- Comment #24 from Michal R rost.michal@gmail.com 2012-07-18 17:59:04 CDT --- Still present in 1.5.9. Everybody knows that this is a bug for almost three years. Can't developers of wine just simply add the patch to the wine, it won't be so hard.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #25 from Mark Strout streetmg@hotmail.com 2012-07-19 08:55:29 CDT --- (In reply to comment #24)
Still present in 1.5.9. Everybody knows that this is a bug for almost three years. Can't developers of wine just simply add the patch to the wine, it won't be so hard.
It's not as easy as it would appear (read up the thread). There seems to be a rewrite in process of the associated code in the dev branch, but so far no luck.
In case any smarter-than-me guys wants to take a stab at a new patch:
Here's the diff for /dlls/winex11.drv/opengl.c that works in 1.4.1: http://bugs.winehq.org/attachment.cgi?id=36782&action=diff
And here's a pastebin of the corresponding (rewritten) section of 1.5.9: http://pastebin.com/1hcLb5FM
Many thanks and appreciation in advance.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #26 from naur mig21@pr0n.pl 2012-09-01 11:38:02 CDT --- Created attachment 41548 --> http://bugs.winehq.org/attachment.cgi?id=41548 Use backup DC for D3D devices created using desktop window
One more patch from me. This time I'm switching to a dummy window (swapchain's backup DC) when the desktop window handle is passed to IDirect3D9::CreateDevice.
This solution is much cleaner that my previous patch.
Tested on Napoleon: Total War - no glitches at full details (including SSAO and HDR).
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #27 from Mark Strout streetmg@hotmail.com 2012-09-02 08:08:41 CDT --- (In reply to comment #26)
Created attachment 41548 [details] Use backup DC for D3D devices created using desktop window
One more patch from me. This time I'm switching to a dummy window (swapchain's backup DC) when the desktop window handle is passed to IDirect3D9::CreateDevice.
This solution is much cleaner that my previous patch.
Tested on Napoleon: Total War - no glitches at full details (including SSAO and HDR).
Confirmed working in 1.5.12 with Empire and Napoleon. No glitches, full detail.
Many thanks, naur!
http://bugs.winehq.org/show_bug.cgi?id=18490
adam.bognar@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adam.bognar@hotmail.com
--- Comment #28 from adam.bognar@hotmail.com 2012-09-30 07:20:27 CDT --- Regarding the patch by Naur, I may have done something wrong? I am unable to "make" when compiling the patched wine. I am using Xubuntu 12.04 and I hope someone can help me, terminal error output:
2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o context.o context.c context.c: In function ‘context_create’: context.c:1323:15: warning: missing terminating " character [enabled by default] context.c:1324:10: warning: missing terminating " character [enabled by default] context.c:2499:0: error: unterminated argument list invoking macro "__WINE_DBG_LOG" ../../include/wine/debug.h:88:8: error: ‘__WINE_DBG_LOG’ undeclared (first use in this function) ../../include/wine/debug.h:88:8: note: each undeclared identifier is reported only once for each function it appears in context.c:1323:1: error: expected ‘;’ at end of input context.c:1323:1: error: expected declaration or statement at end of input context.c:1323:1: warning: unused variable ‘__dbcl’ [-Wunused-variable] context.c:1323:1: warning: unused variable ‘__dbch’ [-Wunused-variable] context.c:1323:1: error: expected declaration or statement at end of input context.c:1323:1: error: expected declaration or statement at end of input context.c:1314:9: error: label ‘out’ used but not defined context.c:1281:9: warning: variable ‘hdc’ set but not used [-Wunused-but-set-variable] context.c:1280:11: warning: unused variable ‘ctx’ [-Wunused-variable] context.c:1279:11: warning: unused variable ‘state’ [-Wunused-variable] context.c:1278:9: warning: unused variable ‘swap_interval’ [-Wunused-variable] context.c:1277:18: warning: unused variable ‘s’ [-Wunused-variable] context.c:1276:9: warning: unused variable ‘pixel_format’ [-Wunused-variable] context.c:1275:10: warning: unused variable ‘auxBuffers’ [-Wunused-variable] context.c:1273:34: warning: unused variable ‘color_format’ [-Wunused-variable] context.c: At top level: context.c:833:13: warning: ‘context_update_window’ defined but not used [-Wunused-function] context.c:1088:13: warning: ‘context_enter’ defined but not used [-Wunused-function] context.c:1123:12: warning: ‘context_choose_pixel_format’ defined but not used [-Wunused-function] context.c:1234:13: warning: ‘bind_dummy_textures’ defined but not used [-Wunused-function] context.c: In function ‘context_create’: context.c:1323:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [context.o] Error 1 make[1]: Leaving directory `/home/.../Desktop/wine-1.4.1/dlls/wined3d' make: *** [dlls/wined3d] Error 2
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #29 from adam.bognar@hotmail.com 2012-09-30 08:12:49 CDT --- Excuse me, was able to make file with the patch of Naur
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #30 from adam.bognar@hotmail.com 2012-09-30 18:40:12 CDT --- So I tried to patch a wine, but it refused to configure, because lib32 dev. libraries (Xfree/Xlib <- or similar) supposedly are missing, but I've got every related, necessary and unecessary package I can think of, so I just configured it without freetype, but after install winecfg striked since 32bit software cannot run in an 64 environment. Well, I am using Xubuntu 12.04 (64 bit version as it seems) and I am a little bit frustrated with wine today, for additional various other reasons, though I keep in mind that in many cases things worked without trouble.
Well, am I doomed to use auto resolve now? I've got an unfix-able windows and I won't spent money on a new one (lost my serial-key -_-) The only thing I'm considering is to Install a 32-bit version of Xubuntu, but I've got already set up this one for quite a while now and feel quite comfortable with it, so I don't think I will trouble myself with a new OS just so I can play 1 game without 1 bug (a very unpleasant bug indeed). And there is no point of having another OS next to this one. 4 are enough......
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #31 from Austin English austinenglish@gmail.com 2012-10-01 02:49:12 CDT --- Please use the forum for help with building wine.
http://bugs.winehq.org/show_bug.cgi?id=18490
yed prior36@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |prior36@gmail.com
--- Comment #32 from yed prior36@gmail.com 2013-06-18 10:57:16 CDT --- PlayOnLinux have made a build with the naur's 2012-09-01 patch if you have problems for compile it : "wine-1.5.22-NapoleonTotalWAR"
Bye
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #33 from Ryan Libby rlibby@gmail.com 2013-09-09 23:37:06 CDT --- Created attachment 45914 --> http://bugs.winehq.org/attachment.cgi?id=45914 Use backup DC for D3D devices created using desktop window (wine-1.7.1)
I ported the previous patch (attachment 41548) to wine-1.7.1 due to a conflict created by 74faebd6 (wined3d: Store the current GLSL program per-context). The resolution was trivial but I haven't tested the result except to say that it compiles.
http://bugs.winehq.org/show_bug.cgi?id=18490
Ryan Libby rlibby@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #45914|0 |1 is obsolete| |
--- Comment #34 from Ryan Libby rlibby@gmail.com 2013-10-01 03:12:02 CDT --- Created attachment 46160 --> http://bugs.winehq.org/attachment.cgi?id=46160 Use backup DC for D3D devices created using desktop window (wine-1.7.3)
Another port of attachment 41548, this time to wine-1.7.3, and because of a conflict created by 112617f0 (wined3d: Move tex_unit_map and friends into the context). Again, trivial resolution, but not tested.
http://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #35 from Anastasius Focht focht@gmx.net --- *** Bug 27365 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=18490
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://store.steampowered.c | |om/app/34330/
--- Comment #36 from Austin English austinenglish@gmail.com --- (In reply to comment #35)
*** Bug 27365 has been marked as a duplicate of this bug. ***
Adding demo link.
http://bugs.winehq.org/show_bug.cgi?id=18490
Robert Munteanu robert.munteanu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |robert.munteanu@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=18490
Malina Salina lakmilis@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lakmilis@hotmail.com
--- Comment #37 from Malina Salina lakmilis@hotmail.com --- http://bugs.winehq.org/attachment.cgi?id=41548&action=diff
Naur's patch, ported by Ryan apparently, works for the latest wine-git (wine-1.7.14-142-gbd69346) and indeed made Napoeleon work perfectly, from no battles, etc.
I can imagine that with voluntary devs, with a project of this magnitude, keeping things proper is important, but also a task of priority. Like others though, as a non-initiate, I still wish this was in the build, despite it being not ideal?
I suspect, that it simply fell out, due to the desired reworks of some of the code, but which apparently didn't happen quite?
Still, wouldn't it sometimes be good to backtrack, add in these things and rather see the oppurutnity of new regression bugs or so, as potentially beneficial to further realise what would indeed be the best code to use in the future?
Either way.. thanks for the patch... the original patch wouldn't work, and I tried with my meager understanding to patch the current code, which compiled, but crashed nonetheless in the battles ,p
So, recompiling (thank you ccache.. down from 15 mins to 5 mins), with the latest patch on here... all is swell. :)
http://bugs.winehq.org/show_bug.cgi?id=18490
Jarkko K jarkko_korpi@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi@hotmail.com
--- Comment #38 from Jarkko K jarkko_korpi@hotmail.com --- The bug is still 1.7.15
http://bugs.winehq.org/show_bug.cgi?id=18490
felix moreno info@justdust.es changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |info@justdust.es
--- Comment #39 from felix moreno info@justdust.es --- Still in 1.7.18 Bests
http://bugs.winehq.org/show_bug.cgi?id=18490
Vladimír Čunát vcunat@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vcunat@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=18490
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |seamusdalton85@gmail.com
--- Comment #40 from Austin English austinenglish@gmail.com --- *** Bug 33358 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #41 from Mark Strout streetmg@hotmail.com --- Did this bug just get fixed?!?
Went to compile 1.7.24 (Stephan D's CSMT fork), added the usual 4-line patch to context.c, didn't want to make install.
Compiled from same source (with original context.c), make/install'd fine. Fired up E:TW and loaded into a land battle without the usual crash.
Can someone confirm? If this is true, I would be so, so very happy. :)
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #42 from felix moreno info@justdust.es --- (In reply to Mark Strout from comment #41)
Did this bug just get fixed?!?
Went to compile 1.7.24 (Stephan D's CSMT fork), added the usual 4-line patch to context.c, didn't want to make install.
Compiled from same source (with original context.c), make/install'd fine. Fired up E:TW and loaded into a land battle without the usual crash.
Can someone confirm? If this is true, I would be so, so very happy. :)
No, it's not working with wine 1.7.24 the bug is still there...
https://bugs.winehq.org/show_bug.cgi?id=18490
Jaro jaromir@mailinator.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jaromir@mailinator.com
--- Comment #43 from Jaro jaromir@mailinator.com --- The empire total war games has been relased today (9.12) for linux. Of course it doesnt fix this bug here.
Happy gaming folks.
https://bugs.winehq.org/show_bug.cgi?id=18490
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |curran.michaelp@gmail.com
--- Comment #44 from Anastasius Focht focht@gmx.net --- *** Bug 24592 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Summary|Empire: Total War crashes |Multiple games fail to set |when loading a map |pixel format on D3D device | |context created on desktop | |window (Empire: Total War, | |Napoleon: Total War, Utopia | |City)
--- Comment #45 from Anastasius Focht focht@gmx.net --- Hello folks,
confirming, still present,
Refining the summary to collect more games (dupes) here and raise awareness.
@D3D folks: feel free to correct the summary again to be technically more correct.
$ wine --version wine-1.7.45-146-gaf55ae1
Regards
https://bugs.winehq.org/show_bug.cgi?id=18490
tt_1 herrtimson@yahoo.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |herrtimson@yahoo.de
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #46 from tt_1 herrtimson@yahoo.de --- Any news on this for the stable wine-2.0 branch? I used to have a working patch for 1.7 which also worked for 1.8 but now it seems as if everyone has to move on once again!
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #47 from tt_1 herrtimson@yahoo.de --- Created attachment 60523 --> https://bugs.winehq.org/attachment.cgi?id=60523 fixes setpixelformat for wine-2.0
Using this patch for some time now and it works as intended, but beyond now oldstable wine-2.0.x I'm kinda lost. Anyone willing to pick this up for wine-3.0?
https://bugs.winehq.org/show_bug.cgi?id=18490
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #48 from joaopa jeremielapuree@yahoo.fr --- Utopia demo: no need of Steam to try it https://www.gamepressure.com/download.asp?ID=11256
https://bugs.winehq.org/show_bug.cgi?id=18490
Robert Walker bob.mt.wya@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya@gmail.com
--- Comment #49 from Robert Walker bob.mt.wya@gmail.com --- Created attachment 60546 --> https://bugs.winehq.org/attachment.cgi?id=60546 wine-3.2_use_backup_dc.patch
(In reply to tt_1 from comment #47)
Created attachment 60523 [details] fixes setpixelformat for wine-2.0
Using this patch for some time now and it works as intended, but beyond now oldstable wine-2.0.x I'm kinda lost. Anyone willing to pick this up for wine-3.0?
Re-based the patch against Wine 3.2 for a Wine user on the WineHQ forums. I've build-tested the patch - but not tested the demo game.
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #50 from tt_1 herrtimson@yahoo.de --- Created attachment 60548 --> https://bugs.winehq.org/attachment.cgi?id=60548 same patch for wine-3.0
I can confirm this patch is working for wine-3.0, have it attached because it needed minimal adjustment. Very likely to work for wine-3.2 as well, but I only need the stable branch with this patch on top.
Speaking of branches, it makes me wonder why this patch is around for so long now but never made it even into staging. Is it that much of a dirty hack?
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |z.figura12@gmail.com Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/d3d9-DesktopWind | |ow
--- Comment #51 from Zebediah Figura z.figura12@gmail.com --- Marking this bug as STAGED.
Note the staged patch allows setting the pixel format on the desktop window (as in comment 4) rather than using a backup DC.
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #52 from tt_1 herrtimson@yahoo.de --- which wine version and which staging are we talking about in terms of this being fixed?
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #53 from Zebediah Figura z.figura12@gmail.com --- (In reply to tt_1 from comment #52)
which wine version and which staging are we talking about in terms of this being fixed?
In theory, the patch has been staged since 1.7.45. The linked patch should also apply against current git, although I haven't tested it since I don't own any of these games.
If it doesn't work, please let us know and we'll do what we can to fix the patch.
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #54 from tt_1 herrtimson@yahoo.de --- Well, if I remember it correctly there was no need to add more patches on top of wine-2.2x + staging, therefore I can agree to you that this is fixed in staging. However, both maintainer of the staging patchset have retired and even though there is some effort made by a team of individuals, to get staging back to live and rebased for >=wine-3.x, it is not yet fixed.
The patch from #4 does not apply anymore.
https://bugs.winehq.org/show_bug.cgi?id=18490
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #55 from tt_1 herrtimson@yahoo.de --- With wine-3.3 + latest patch https://bugs.winehq.org/attachment.cgi?id=60546 from #49 the battle mode in Napoleon Total War does crash again while loading the battle map.
Staging is back to live with 3.3, so maybe I'll test it.
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #56 from tt_1 herrtimson@yahoo.de --- Just to confirm, it does not work with wine-3.3 and the rebased staging patchset. It does work partially with the patch from #49 on top, but only in so fare as that you can start a battle and switch from campain mode to the battle mode, but the game crashes again if you want to quit the battle mode and return to the campaign mode.
(This description is meant for Napoleon: Total War)
Also I have problems with some of the textures, but this should be another bug.
https://bugs.winehq.org/show_bug.cgi?id=18490
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #57 from joaopa jeremielapuree@yahoo.fr --- Problem still occurs with wine-3.21 with the demo of Utopia https://download.cnet.com/Utopia-City-demo/3001-7441_4-10516576.html
Can an administrator put the link at the url place?
https://bugs.winehq.org/show_bug.cgi?id=18490
--- Comment #58 from Christopher May-Townsend chris@maytownsend.co.uk --- For Total War: Napoleon, wine-4.0-rc3 (Staging) doesn't isn't affected by this bug. Battles and returning to the campaign screen work fine.
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rafael.raccuia@blindekinder | |.com
--- Comment #59 from Zebediah Figura z.figura12@gmail.com --- *** Bug 33484 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |edmundzed@gmail.com
--- Comment #60 from Zebediah Figura z.figura12@gmail.com --- *** Bug 46574 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0922237c8308f583b9dd27bed38 | |6223be87c7057 Resolution|--- |FIXED Status|STAGED |RESOLVED
--- Comment #61 from Zebediah Figura z.figura12@gmail.com --- This should be fixed by https://source.winehq.org/git/wine.git/commitdiff/0922237c8308f583b9dd27bed386223be87c7057. Please file new bugs for any remaining issues with any of these applications.
https://bugs.winehq.org/show_bug.cgi?id=18490
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #62 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.12.
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |qsniyg@mail.com
--- Comment #63 from Zebediah Figura z.figura12@gmail.com --- *** Bug 46774 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa@gmail.com
--- Comment #64 from Zebediah Figura z.figura12@gmail.com --- *** Bug 33476 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69@gmail.com
--- Comment #65 from Béla Gyebrószki gyebro69@gmail.com --- *** Bug 24613 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18490
shurican95 shurican95@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shurican95@mail.ru
-
wine-bugs＠winehq.org -
WineHQ Bugzilla