[Bug 39484] New: Logically dead code in stub_manager_notify_unmarshal (Coverity #731557)
https://bugs.winehq.org/show_bug.cgi?id=39484
Bug ID: 39484 Summary: Logically dead code in stub_manager_notify_unmarshal (Coverity #731557) Product: Wine Version: 1.7.53 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ole32 Assignee: wine-bugs@winehq.org Reporter: alexhenrie24@gmail.com Distribution: ---
dead_error_condition: The condition ifstub->flags & MSHLFLAGS_NORMAL cannot be true.
CID 731557 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: if (m->norm_refs) m->norm....
https://bugs.winehq.org/show_bug.cgi?id=39484
Alex Henrie alexhenrie24@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adam.r.martinson@gmail.com, | |bunglehead@gmail.com, | |julliard@winehq.org, | |marcus@jet.franken.de, | |mike@plan99.net, | |robertshearman@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=39484
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead@gmail.com |
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- What's a point of this mass
https://bugs.winehq.org/show_bug.cgi?id=39484
--- Comment #2 from Alex Henrie alexhenrie24@gmail.com --- Assuming that you were trying to ask "What's the point of this mess?", the problem is that MSHLFLAGS_NORMAL is defined to be 0 and (ifstub->flags & 0) can never be true. Take a look at https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee...
https://bugs.winehq.org/show_bug.cgi?id=39484
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- No, sorry, hit a button too soon. If you're trying to move some Coverity issues here so more people can notice them, please provide code fragment if it's compact or links (that will expire by code moves). Maybe it makes sense to clone the most important/core issues here, but definitely not all of them.
https://bugs.winehq.org/show_bug.cgi?id=39484
--- Comment #4 from Alex Henrie alexhenrie24@gmail.com --- I'm only copying issues that I personally verified but was unable to personally fix. That means that for the moment, I have only copied five Coverity reports into Bugzilla. I will make sure to add permanent links to the bad code to each bug report, as I have now done here.
If you have knowledge of this code area, suggestions on how to fix it would be welcome (or better yet, patches).
https://bugs.winehq.org/show_bug.cgi?id=39484
--- Comment #5 from Marcus Meissner marcus@jet.franken.de --- i had submitted a patch for this already, but there were test failures.
https://www.winehq.org/pipermail/wine-patches/2015-May/139094.html https://www.winehq.org/pipermail/wine-patches/2015-May/139095.html
https://bugs.winehq.org/show_bug.cgi?id=39484
Alex Henrie alexhenrie24@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=39483
https://bugs.winehq.org/show_bug.cgi?id=39484
--- Comment #6 from François Gouget fgouget@codeweavers.com --- *** Bug 39483 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=39484
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source
https://bugs.winehq.org/show_bug.cgi?id=39484
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
-
wine-bugs＠winehq.org