[Bug 40882] New: GPU card recognize as Nvidia GTX 470

https://bugs.winehq.org/show_bug.cgi?id=40882

Bug ID: 40882
           Summary: GPU card recognize as Nvidia GTX 470
           Product: Wine
           Version: 1.9.13
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hi,

I have a laptop with a Nvidia GT 740M but this card is recognized by Wine as
Nvidia GTX 470. I saw it when I go in the settings of for example Heroes of the
Storm.

[Bug 40882] GPU card recognize as Nvidia GTX 470

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #1 from [e-mail] ---
Created attachment 54971
  --> https://bugs.winehq.org/attachment.cgi?id=54971
lspci

[Bug 40882] GPU card recognize as Nvidia GTX 470

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #2 from [e-mail] ---
Created attachment 54972
  --> https://bugs.winehq.org/attachment.cgi?id=54972
Screenshot in Heroes of the Storm settings

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
            Summary|GPU card recognize as       |Nvidia GT 740M is not
                   |Nvidia GTX 470              |correctly recognized

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
(In reply to audiger from comment #0)
> Hi,
>
> I have a laptop with a Nvidia GT 740M but this card is recognized by Wine as
> Nvidia GTX 470. I saw it when I go in the settings of for example Heroes of
> the Storm.

You'll need to post the PCI Device ID, PCI Vendor ID, and the total memory (not
total dedicated memory) for your card.

You can find all this in your Nvidia X Server settings application, if you have
it installed.

Just click on the GPU and you will see everything you need there :)

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #4 from [e-mail] ---
Sure! The PCI Device ID is 0x1292, the PCI Vendor ID is 0x10de and the total
memory of my card is 2048 Mb. I take a screenshot about these informations ;)

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #5 from [e-mail] ---
Created attachment 55005
  --> https://bugs.winehq.org/attachment.cgi?id=55005
GPU informations

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #6 from [e-mail] ---
I will take this one, at least to make my first contribution to the wine
project if possible. I found where to write the code to recognize my card:
http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/wined3d/directx.c
http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/wined3d/wined3d_privat...

I'll do a patch in the next hour.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #7 from [e-mail] ---
Created attachment 55187
  --> https://bugs.winehq.org/attachment.cgi?id=55187
Add Nvidia gt 740m card

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] ---
(In reply to audiger from comment #7)
> Created attachment 55187 [details]
> Add Nvidia gt 740m card

I think the code misses mesa recognize code.

See thig bug report as a sample bug 35847.

Also you should send the patch to wine patches list. It's not merged
automatically from bug tracker.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #9 from [e-mail] ---
I'll do it soon. But before that I had to understand how is working the mesa
recognize code.
I find the line in which the nvidia card are declared, it's locating to line
2152: cards_nvidia_mesa[]. With an lspci I find my card code name is GK208
which means NV108 according to this page
https://nouveau.freedesktop.org/wiki/CodeNames/
So if I want to add the code name NV108, what card I'm supposed to put after
it. My own "CARD_NVIDIA_GEFORCE_GT740M"?

After that I'll send the commit to the patches list.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #10 from [e-mail] ---
(In reply to audiger from comment #9)
> I'll do it soon. But before that I had to understand how is working the mesa
> recognize code.
> I find the line in which the nvidia card are declared, it's locating to line
> 2152: cards_nvidia_mesa[]. With an lspci I find my card code name is GK208
> which means NV108 according to this page
> https://nouveau.freedesktop.org/wiki/CodeNames/
> So if I want to add the code name NV108, what card I'm supposed to put after
> it. My own "CARD_NVIDIA_GEFORCE_GT740M"?
>
> After that I'll send the commit to the patches list.

Sounds correct. I didnt check the link though.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #11 from Bruno Jesus  ---
(In reply to audiger from comment #7)
> Created attachment 55187 [details]
> Add Nvidia gt 740m card

Please send the patch as is, see http://wiki.winehq.org/SubmittingPatches

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

--- Comment #12 from [e-mail] ---
The patche has been sent. I'll close this issue when the patch will be reviewed
and accepted.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.9.13                      |1.9.15

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |a7681a877c9aa953b750593a3ff
                   |                            |249c79d9a1f8f

--- Comment #13 from [e-mail] ---
Fixed with
http://source.winehq.org/git/wine.git/?a=commit;h=a7681a877c9aa953b750593a3f...

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.16.

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.8.x

[Bug 40882] Nvidia GT 740M is not correctly recognized

https://bugs.winehq.org/show_bug.cgi?id=40882

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #15 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.5.