[Bug 22575] New: Performance regression in Starcraft with wine 1.1.43

http://bugs.winehq.org/show_bug.cgi?id=22575

Summary: Performance regression in Starcraft with wine 1.1.43
           Product: Wine
           Version: 1.1.43
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=27700)
 --> (http://bugs.winehq.org/attachment.cgi?id=27700)
Regression Test Results

Updating wine to 1.1.43 causes a major decline in Starcraft's 2d graphics
performance, when running with DirectDrawRenderer="opengl" set in regedit.

The graphics are now drawn so slowly that it's immediately obvious when
navigating the menu screens. The game is unplayable as a result.

I performed a regression test which told me that
"e7a71e15b56d709c4623a472b0dc44ae6b336e08 is the first bad commit", which had
the description "wined3d: Turn blit_shader color_fixup_supported into
blit_supported." The full result is attached.

I'm running on debian x86-64 with a Radeon HD4870 using the fglrx driver if
that makes any odds.

[Bug 22575] Performance regression in Starcraft with wine 1.1.43

http://bugs.winehq.org/show_bug.cgi?id=22575

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Performance regression in   |Major decline in
                   |Starcraft with wine 1.1.43  |Starcraft's 2d graphics
                   |                            |performance

--- Comment #1 from Dmitry Timoshkov   2010-05-04 09:34:58 ---
e7a71e15b56d709c4623a472b0dc44ae6b336e08 is the first bad commit
commit e7a71e15b56d709c4623a472b0dc44ae6b336e08
Author: Roderick Colenbrander 
Date:   Tue Apr 6 22:20:42 2010 +0200

wined3d: Turn blit_shader color_fixup_supported into blit_supported.

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

--- Comment #2 from Roderick Colenbrander   2010-05-04 14:22:47 ---
I'm aware of the issue but haven't had time to fix it yet. It is basically the
blit_supported call in d3dfmt_get_conv which is the problem. If you shortcut
that call (e.g. by setting the blit_supported=1) it should work fine.

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

David  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from David   2010-05-22 10:43:19 ---
As far as I can tell, this bug seems to have been fixed as of 1.2-rc1. Cheers!

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

--- Comment #4 from Roderick Colenbrander   2010-05-22 11:06:37 ---
As far as I'm aware it isn't fixed.

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #5 from Roderick Colenbrander   2010-05-26 10:07:32 ---
The bug isn't fixed and will be fixed tomorrow. Perhaps some other change
helped but the 8-bit conversion is now done in software (on modern CPUs that
should work fine in general).

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Roderick Colenbrander   2010-05-27 11:35:41 ---
Should be fixed now by ba09e7a2a1ddd8bc9675043c8e0e3d56dd460bcf

[Bug 22575] Major decline in Starcraft's 2d graphics performance

http://bugs.winehq.org/show_bug.cgi?id=22575

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2010-05-28 12:51:51 ---
Closing bugs fixed in 1.2-rc2.