[Bug 52610] New: Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52610

Bug ID: 52610
           Summary: Memory corruption in PE build, when using FIXME in
                    krnl386.exe __wine_vxd_open() function
           Product: Wine
           Version: 7.3
          Hardware: x86-64
                OS: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build-env
          Assignee: [e-mail]
          Reporter: [e-mail]

In the PE build (only), calling FIXME("anything\n") in the krnl386.exe
__wine_vxd_open() function causes the contents of the filename parameter to get
overwritten with "l.dll".

This is a recent regression, bisected to:

6ebcc54a5c2c4b5724571f37ab41e99ee9e49acb is the first bad commit
commit 6ebcc54a5c2c4b5724571f37ab41e99ee9e49acb
Author: Alexandre Julliard 
Date:   Thu Nov 11 11:38:31 2021 +0100

makefiles: Explicitly import all the needed libraries.

Don't rely on winegcc adding any default libraries.

Signed-off-by: Alexandre Julliard

dlls/krnl386.exe16/Makefile.in |   3 +-
 tools/makedep.c                | 162 +++++++++++++++++++++--------------------
 tools/winegcc/winegcc.c        |   4 -
 3 files changed, 85 insertions(+), 84 deletions(-)

[Bug 52610] Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52610

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |6ebcc54a5c2c4b5724571f37ab4
                   |                            |1e99ee9e49acb
           Keywords|                            |regression
                 CC|                            |[e-mail]

--- Comment #1 from Damjan Jovanovic  ---
Adding author to CC.

The calling app does:

hCVxD = CreateFileA(argv[1], 0,0,0,
                        CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0);

Possibly because CreateFileA() calls file_name_AtoW() with alloc==FALSE, which
uses NtCurrentTeb()->StaticUnicodeString, which FIXME() might use too?

But then why is the ELF build unaffected?

[Bug 52610] Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52610

--- Comment #2 from Alexandre Julliard  ---
This may be fixed by 7c6f6d27756687c3e2a3b8ca743f886e694142a2.

[Bug 52610] Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52610

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |7c6f6d27756687c3e2a3b8ca743
                   |                            |f886e694142a2

--- Comment #3 from Damjan Jovanovic  ---
Yes it was fixed by 7c6f6d27756687c3e2a3b8ca743f886e694142a2, and first
released in Wine 7.8.

Thank you :). Resolving fixed.

[Bug 52610] Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52610

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.15.